Repository navigation
Make AddUnreportedExpense use new SelectionList - fixing deploy blocker issues - #76832
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Second attempt to merge this PR
|
@zfurtak can you please fix the conflict? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-10.at.09.21.35.movAndroid: mWeb ChromeScreen.Recording.2025-12-10.at.09.18.37.moviOS: HybridAppScreen.Recording.2025-12-10.at.09.22.59.moviOS: mWeb SafariScreen.Recording.2025-12-10.at.09.18.22.movMacOS: Chrome / SafariScreen.Recording.2025-12-10.at.09.16.41.mov |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Looks good to me, though Joe is already on this.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
Explanation of Change
Migrates AddUnreportedExpense to new SelectionList, fixing issues from the previous migration attempt
Previous PR was revert because of 2 issues - both are fixed now:
#76233
Screen.Recording.2025-12-08.at.13.44.53.mov
#76207
Screen.Recording.2025-12-08.at.13.36.57.mov
Fixed Issues
$ #72972
Tests
Reports>ReportsMorebutton >Add expense>Add unreported expenseAddUnreportedExpenseis working correctly (to make the textInput appear you have to have at least 15 unreported expenses)Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android_web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios_web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop