Skip to content

Fix Android text selection context menu (copy, paste) - #7815

Closed
kidroca wants to merge 3 commits into
Expensify:mainfrom
kidroca:kidroca/fix/android-text-input-context-menu
Closed

kidroca wants to merge 3 commits into
Expensify:mainfrom
kidroca:kidroca/fix/android-text-input-context-menu

Conversation

@kidroca

@kidroca kidroca commented Feb 18, 2022 •

Copy link
Copy Markdown
Contributor

Details

Related to slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1645201764524639?thread_ts=1645191589.301989&cid=C01GTK53T8Q

Using controlled selection is not allowing the user to control the selection freely
Switching to uncontrolled selection addresses the issue and improves performance a bit

Fixed Issues

$ #6876

Tests

  • Verify that no errors appear in the JS console

QA Steps

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-03-24.at.20.37.03.mov

Mobile Web

Screen.Recording.2022-03-24.at.20.39.43.mov

Desktop

iOS

Screen.Recording.2022-03-24.at.20.24.19.mov

Android

Android.Emulator.-.Pixel_2_API_29_5554.2022-02-18.18-27-36.mp4

@kidroca
kidroca force-pushed the kidroca/fix/android-text-input-context-menu branch from 81cde26 to 1797f30 Compare March 24, 2022 18:26
@kidroca

kidroca commented Sep 16, 2022

Copy link
Copy Markdown
Contributor Author

Close old PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant