Repository navigation
fix: preview is displayed cutted off when adding expense #78971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b1b8719
fix: preview is displayed cutted off when adding expense
daledah d831117
resolve conflict
daledah b1b1780
Merge branch 'main' into fix/78603
daledah 0aede45
add useEffect to reset current index
daledah 1ff84fb
Merge branch 'main' into fix/78603
daledah 5bfb0e4
Use key to rerender flatlist
daledah e38fc28
Merge branch 'main' into fix/78603
daledah 1c04dff
Merge branch 'main' into fix/78603
daledah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see we have this ref
prevCarouselTransactionLengththat does the same ... can it be used instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abzokhattab i think they serve different purposes.
prevCarouselTransactionLengthstarts at 0 and updates in the cleanup of its effect, whileprevTransactionCountForScrollstarts atcarouselTransactions.lengthand updates at the end of its effect.