Repository navigation
FIX BA - Error is shown when moving back to step 1 and clicking Next in enable Wallet flow - #79106
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| useEffect(() => { | ||
| // if we're at this step, then we have already added a bank account so we need to clear ONYX keys for the bank account | ||
| clearPersonalBankAccount(); | ||
| }, []); |
There was a problem hiding this comment.
Can you elaborate why we need this change?
There was a problem hiding this comment.
Without this change the flow would look like this
- In the wallet flow we select some bank accounts (in the plaid step for example)
- We confirm that we want to add selected bank account (I mean we select distinct account from the list from plaid flow)
- We're in the personal info step
- We decide that it's not the bank account we want to use with wallet
- We go out of the flow and delete that bank account
- We go back into wallet enable flow and we still have a list of bank account from the previous flow
- If we want to add a new bank account (one that is not in the list from previous flow) we need to click header back button to clear the data and only after it we can add fresh bank account
From my point of view it would be confusing that we need to reenter the flow twice to start fresh\
It would look like this:
Screen.Recording.2026-01-13.at.11.54.41.mov
While with above changes it looks like this:
Screen.Recording.2026-01-13.at.11.56.16.mov
There was a problem hiding this comment.
So If we clear onyx when submitting the bank account it breaks like on the following video (we get add bank account prompt which disappears after a few seconds and we can proceed with the flow as usual bot nonetheless it breaks)
Screen.Recording.2026-01-16.at.12.59.32.mov
In the case that we clear onyx data when exiting the personalInfo step on web we could go out of the flow without clearing the data (ie by clicking the backdrop), like on the following video:
Screen.Recording.2026-01-16.at.13.04.51.mov
|
Hi, @dominictb how's the review coming along? 🚀 |
heyjennahay
left a comment
There was a problem hiding this comment.
Product review not required
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-26.at.19.27.02.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-01-26.at.19.18.55.moviOS: mWeb SafariScreen.Recording.2026-01-26.at.19.21.05.movMacOS: Chrome / SafariScreen.Recording.2026-01-26.at.19.02.22.movScreen.Recording.2026-01-26.at.19.05.13.movScreen.Recording.2026-01-26.at.19.06.42.movScreen.Recording.2026-01-26.at.19.07.10.mov |
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.9-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
Explanation of Change
Changed behavior of back button in the step after the addBankAccount one,
After loading the PersonalInfo step we clear onyx data to not let the inconsistent state into bank accounts (ie we can go back to add bank account step and add it a few times, after closing the rhp and removing one of added bank accounts to not let readd the already added one)
Fixed Issues
$ #71697
PROPOSAL:
Tests
Testcase 1:
Testcase 2:
Prerequisite: bank account already added
Testcase 3:
Prerequisite: we have already added some draft bank account
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-12.at.14.02.46.mov
Android: mWeb Chrome
Screen.Recording.2026-01-12.at.13.50.37.mov
iOS: Native
Screen.Recording.2026-01-12.at.13.11.56.mov
iOS: mWeb Safari
Screen.Recording.2026-01-12.at.13.42.10.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-09.at.12.58.51.mov