Repository navigation
Fix focus tracking to skip hidden elements - #79911
Conversation
|
@marufsharifi Can you include some testing steps? Thanks. |
|
Note: Use macos voiceover |
|
@marufsharifi when can we expect the PR ready for review? |
|
@Ollyws, @rushatgabhane, I am trying to test on IOS Native Real Device, but running |
|
yeah you'll have to work on simulator because real device is difficult to setup, can you fix failing tests please |
@rushatgabhane, the voice-over is not available in the simulator, so I have to run it on a real device. I could run the app on my Real device, but the JS bundle seems to be unavailable, i will fix that and then finish testing here. thanks. |
|
@marufsharifi You can use the Accessibility Inspector in XCode to test in the simulator: |
@Ollyws, thank you so much for the help. The PR is ready for your review. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid_Native_2.movAndroid_Native.movAndroid: mWeb ChromeN/A iOS: HybridAppiOS_Native_02.moviOS_Native.moviOS: mWeb SafariN/A MacOS: Chrome / SafariN/A |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.9-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
Explanation of Change
Ensure accessibility focus logic ignores hidden and non-interactive elements to prevent incorrect focus behavior.
Fixed Issues
$ #79244
PROPOSAL: #79244 (comment)
Tests
First issue
After the OTP cells container, focus should land on the first cell.
Second issue
Offline tests
Same as Tests
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
space-announced-in-native.mp4
invisible-element-in-native.mp4
Android: mWeb Chrome
invisible-element-in-mweb.mp4
space-annoumce-in-mweb.mp4
iOS: Native
Screen.Recording.1404-11-04.at.4.21.40.PM.mov
Screen.Recording.1404-11-04.at.4.23.37.PM.mov
iOS: mWeb Safari
Screen.Recording.1404-11-04.at.4.26.38.PM.mov
Screen.Recording.1404-11-04.at.4.28.26.PM.mov
MacOS: Chrome / Safari
Screen.Recording.1404-11-04.at.4.32.16.PM.mov
Screen.Recording.1404-11-04.at.4.40.41.PM.mp4