Repository navigation
Display correct violation on scan failure - #80118
Conversation
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Hi @Gonals does this need c+ review? asking since it was requested here |
|
Yep! Let me assign you to the issue |
trjExpensify
left a comment
There was a problem hiding this comment.
Minor fix in split expense flow 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-23.at.01.14.58.movAndroid: mWeb ChromeScreen.Recording.2026-01-23.at.01.13.22.moviOS: HybridAppScreen.Recording.2026-01-23.at.01.14.58.moviOS: mWeb SafariScreen.Recording.2026-01-23.at.01.13.22.movMacOS: Chrome / SafariScreen.Recording.2026-01-23.at.01.12.07.mov |
abzokhattab
left a comment
There was a problem hiding this comment.
@Gonals Nice catch, looks good to me, but I would recommend adding a test case for this scenario
|
@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.9-0 🚀
|
Huh. Weird. I will investigate. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
Explanation of Change
Fixed Issues
$ #79743
PROPOSAL:
Tests
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari