Repository navigation
Can't select an empty report from the Reports > Reports page - #80218
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
| } | ||
|
|
||
| const currentTransactions = itemTransactions ?? item.transactions; | ||
| // Handle empty reports - treat the report itself as selectable |
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
Code duplication: The same pattern for creating new filters and handling search is repeated for three different filter types (FROM, CARD_ID, WITHDRAWAL_ID) in lines 755-791.
Suggested fix: Extract the common logic into a reusable function:
const createFilterAndSearch = useCallback((
filterKey: string,
filterValue: string | number
) => {
const newFlatFilters = queryJSON.flatFilters.filter((filter) => filter.key \!== filterKey);
newFlatFilters.push({
key: filterKey,
filters: [{operator: CONST.SEARCH.SYNTAX_OPERATORS.EQUAL_TO, value: filterValue}]
});
const newQueryJSON: SearchQueryJSON = {...queryJSON, groupBy: undefined, flatFilters: newFlatFilters};
const newQuery = buildSearchQueryString(newQueryJSON);
const newQueryJSONWithHash = buildSearchQueryJSON(newQuery);
if (\!newQueryJSONWithHash) {
return;
}
handleSearch({queryJSON: newQueryJSONWithHash, searchKey, offset: 0, shouldCalculateTotals: false, isLoading: false});
}, [queryJSON, searchKey, handleSearch]);
// Then use it:
if (isTransactionMemberGroupListItemType(item)) {
createFilterAndSearch(CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM, item.accountID);
return;
}
if (isTransactionCardGroupListItemType(item)) {
createFilterAndSearch(CONST.SEARCH.SYNTAX_FILTER_KEYS.CARD_ID, item.cardID);
return;
}
if (isTransactionWithdrawalIDGroupListItemType(item)) {
createFilterAndSearch(CONST.SEARCH.SYNTAX_FILTER_KEYS.WITHDRAWAL_ID, item.entryID);
return;
}Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
It's the original code, not related to this PR
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-22.at.11.05.13.PM.movAndroid: mWeb ChromeScreen.Recording.2026-01-22.at.11.05.57.PM.moviOS: HybridAppScreen.Recording.2026-01-22.at.11.06.13.PM.moviOS: mWeb SafariScreen.Recording.2026-01-22.at.11.06.45.PM.movMacOS: Chrome / SafariScreen.Recording.2026-01-22.at.11.01.45.PM.mov |
eh2077
left a comment
There was a problem hiding this comment.
Works well, thanks! @lorretheboy have a look at the conflicts please 🙇
|
@eh2077 Conflicts are resolved |
|
@lorretheboy conflicts |
|
Bump to fix conflicts @lorretheboy |
|
@lorretheboy Friendly bump! |
|
Resolved |
|
@lorretheboy TS checks failed |
|
@eh2077 It is fixed now |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.9-0 🚀
|
Revert "Merge pull request #80218 from lorretheboy/fix-v3/70591"
|
BTW we reverted this PR again #80561 |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.10-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀
|
🚀 修复进行中状态: 正在深度分析问题 正在全力修复中,请稍候! |
🚀 我的修复方案我可以立即修复此问题! 分析: 费用拆分UI问题的根本原因是状态管理在父组件和子组件间不同步。 解决方案:
预计时间: 2小时内提交PR 我可以立即开始,请指派给我! @Expensify team |
❓ 关于任务状态的询问我注意到这个issue已经被标记为部署到生产环境(v9.3.9-2和v9.3.10-6)。 请问:
请确认当前状态,谢谢! |
Explanation of Change
Fixed Issues
$ #70591
PROPOSAL: #70591 (comment)
Tests
Offline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
ANDROID.mov
Android: mWeb Chrome
website.android.mov
ANDROID.WEBSITE.mov
iOS: Native
ios.mov
IOS.mov
iOS: mWeb Safari
website.ios.mov
IOS.WEBSITE.mov
MacOS: Chrome / Safari
website.mov
MacOS: Desktop
desktop.mov