Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index c9531841..cd719d66 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5231,6 +5231,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
title: 'Regeln',
subtitle: 'Belege verlangen, hohe Ausgaben kennzeichnen und mehr.',
},
+ timeTracking: {title: 'Zeit', subtitle: 'Legen Sie einen abrechenbaren Stundensatz fest, damit Mitarbeitende für ihre Zeit bezahlt werden.'},
},
reports: {
reportsCustomTitleExamples: 'Beispiele:',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 4915aea3..d44f6537 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5239,6 +5239,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
title: 'Règles',
subtitle: 'Exigez des reçus, signalez les dépenses élevées, et plus encore.',
},
+ timeTracking: {title: 'Heure', subtitle: 'Définissez un taux horaire facturable pour que les employés soient rémunérés pour leur temps.'},
},
reports: {
reportsCustomTitleExamples: 'Exemples :',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 0576e890..4cfa5766 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5218,6 +5218,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
title: 'Regole',
subtitle: 'Richiedi ricevute, segnala spese elevate e altro ancora.',
},
+ timeTracking: {title: 'Ora', subtitle: 'Imposta una tariffa oraria fatturabile per consentire ai dipendenti di essere pagati per il loro tempo.'},
},
reports: {
reportsCustomTitleExamples: 'Esempi:',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 10ac8f27..5404a2e9 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5184,6 +5184,7 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
title: 'ルール',
subtitle: 'レシートの必須化や高額支出のフラグ付けなどを設定できます。',
},
+ timeTracking: {title: '時間', subtitle: '従業員が作業時間に対して支払いを受けられるよう、時間単位の請求レートを設定します。'},
},
reports: {
reportsCustomTitleExamples: '例:',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 3d0bc2f4..3af639b7 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5207,6 +5207,7 @@ _Voor gedetailleerdere instructies, [bezoek onze helpsite](${CONST.NETSUITE_IMPO
title: 'Regels',
subtitle: 'Vereis bonnetjes, markeer hoge uitgaven en meer.',
},
+ timeTracking: {title: 'Tijd', subtitle: 'Stel een uurtarief in waarmee medewerkers worden betaald voor hun tijd.'},
},
reports: {
reportsCustomTitleExamples: 'Voorbeelden:',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index cc7e3d91..33efca61 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5200,6 +5200,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
title: 'Zasady',
subtitle: 'Wymagaj paragonów, oznaczaj wysokie wydatki i nie tylko.',
},
+ timeTracking: {title: 'Czas', subtitle: 'Ustaw godzinową stawkę rozliczeniową, aby pracownicy byli wynagradzani za swój czas.'},
},
reports: {
reportsCustomTitleExamples: 'Przykłady:',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 0e7a3fa9..fec7715a 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5200,6 +5200,7 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
title: 'Regras',
subtitle: 'Exigir recibos, sinalizar gastos elevados e muito mais.',
},
+ timeTracking: {title: 'Hora', subtitle: 'Defina uma taxa horária faturável para que os funcionários sejam pagos pelo tempo trabalhado.'},
},
reports: {
reportsCustomTitleExamples: 'Exemplos:',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index c4218ae0..148ffdee 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5094,6 +5094,7 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
title: '规则',
subtitle: '要求收据、标记高额支出等。',
},
+ timeTracking: {title: '时间', subtitle: '为员工设置按小时计费的费率,以便根据他们的工作时间获得报酬。'},
},
reports: {
reportsCustomTitleExamples: '示例:',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9132af5165
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-26.at.21.25.42.movAndroid: mWeb ChromeScreen.Recording.2026-01-26.at.21.19.25.moviOS: HybridAppScreen.Recording.2026-01-26.at.21.27.53.moviOS: mWeb SafariScreen.Recording.2026-01-26.at.21.27.02.movMacOS: Chrome / SafariScreen.Recording.2026-01-26.at.18.08.24.mov |
|
@mhawryluk Currently, users can switch the time expense to workspaces that don't enable the time expense, we only display workspaces that enable the time expense in the participant list Screen.Recording.2026-01-26.at.18.08.24.mov |
good catch, thanks. I'm not sure why the participant is even editable in this case. I will look into this. but I don't think this is related to this PR |
|
issue logged #80489 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.9-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀
|
Explanation of Change
Adds Time to the feature list in Workspace > More features page. Allows enabling/disabling this feature in New Dot.
Fixed Issues
$ #77525
PROPOSAL: N/A
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2026-01-23.o.15.39.29.mov
Android: mWeb Chrome
Nagranie.z.ekranu.2026-01-23.o.15.41.21.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-01-23.at.15.37.09.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-01-23.at.15.38.28.mp4
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-01-23.o.11.17.30.mov