Repository navigation
[NO QA] Add Onyx skill - #81366
[NO QA] Add Onyx skill#81366
Conversation
tgolen
left a comment
There was a problem hiding this comment.
Really cool idea! I've only skimmed this, and one suggestion I had is that a lot of this is already written down in other docs across the place (such as the API docs for Onyx itself, and some of our best practices). It would be nice if we can refer to existing resources whenever possible so that we don't have to duplicate the information and worry about it getting outdated.
|
@youssef-lr what is the plan with this PR? |
|
I'll update it sometime later today or tomorrow. I'll bring you back once it's ready! |
|
Resuming this PR today. I think it's more important than ever now that Melvin generates proposals https://expensify.slack.com/archives/C01SKUP7QR0/p1771366542872379 |
|
|
||
| Onyx is a **persistent storage solution wrapped in a Pub/Sub library** that enables reactive, offline-first data management — key-value storage with automatic AsyncStorage persistence, reactive subscriptions, and collection management. | ||
|
|
||
| For the full API reference (initialization, storage providers, cache eviction, benchmarks, Redux DevTools), see `@../react-native-onyx/README.md`. |
There was a problem hiding this comment.
@justinpersaud when MelvinBot runs, it can access the file here just fine right?
There was a problem hiding this comment.
Should be safer to use the direct link to the repo readme file here
|
I'll make this PR ready for review tomorrow. |
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
OK this should be ready for review! cc @roryabraham @marcaaron @Julesssss if you guys are interested in reviewing as well |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 087ddce31e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Julesssss
left a comment
There was a problem hiding this comment.
Nice skill. Ideally it'd be much briefer though, 150 lines is a good target.
The examples could still be worthwhile if not duplicated in the linked files. But can you follow the structure shown here and put them into seperate md files.
That way only relevant parts of this skill will get pulled into the context and we'll get better results.
|
Updated @Julesssss |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
Explanation of Change
Context https://expensify.slack.com/archives/C03TQ48KC/p1770063245782299
Fixed Issues
None
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari