Repository navigation
fix: Some Categories Not Appearing in New Expensify After Migration - #81486
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mollfpr Please kick off a build, then we can ask the customer to test in the adhoc to verify it works. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b52555418
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ...existedValue, | ||
| name: category.name, | ||
| pendingAction: category.pendingAction, | ||
| enabled: category.enabled ?? false, |
There was a problem hiding this comment.
Preserve subcategories named "enabled"
Storing enabled directly on each hierarchy node makes enabled a reserved key, so any category segment literally named enabled is treated as metadata instead of a child. In flatHierarchy, destructuring pulls enabled out and excludes it from subcategories, which can drop categories like "Travel: enabled" (or corrupt a parent node when both "Travel" and "Travel: enabled" exist), causing valid categories to disappear from the picker.
Useful? React with 👍 / 👎.
|
🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
https://81486.pr-testing.expensify.com/ @DGephart can you please test this build? |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good from product 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-02-10.at.4.43.15.pm.mov |
|
🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.18-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀
|
Explanation of Change
fix: Some Categories Not Appearing in New Expensify After Migration
Fixed Issues
$ #79936
PROPOSAL: #79936 (comment)
Tests
Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-05.at.14.48.59.mov
Android: mWeb Chrome
Screen.Recording.2026-02-05.at.14.42.32.mov
iOS: Native
Screen.Recording.2026-02-05.at.14.45.06.mov
iOS: mWeb Safari
Screen.Recording.2026-02-05.at.14.42.58.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-05.at.14.40.17.mov