Repository navigation
[Single-use and Expire-by virtual cards]: update edit card flow - #81783
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcdf3a0a13
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
on it now |
trjExpensify
left a comment
There was a problem hiding this comment.
Core PR for a WN project rollout. 👍
Co-authored-by: dukenv0307 <129500732+dukenv0307@users.noreply.github.com>
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-09.at.23.17.38.movAndroid: mWeb ChromeScreen.Recording.2026-02-09.at.23.15.58.moviOS: HybridAppScreen.Recording.2026-02-09.at.23.18.10.moviOS: mWeb SafariScreen.Recording.2026-02-09.at.23.14.19.movMacOS: Chrome / SafariScreen.Recording.2026-02-09.at.23.12.14.mov |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.18-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀
|
| <View style={[styles.flexRow, styles.gap2, styles.flex2, styles.alignItemsCenter, styles.justifyContentStart]}> | ||
| <Text | ||
| numberOfLines={1} | ||
| style={[styles.textNormalThemeText, styles.lh16]} |
There was a problem hiding this comment.
NAB but setting line height of 16 px caused g to be cut-off. We fixed this in #82320
| validFrom: shouldClearValidityDates ? null : validFrom, | ||
| validThru: shouldClearValidityDates ? null : validThru, |
There was a problem hiding this comment.
During the optimistic update for issue, raw date strings (yyyy-MM-dd) are written directly to the card's validity properties. Because the detail page reads these fields expecting UTC datetimes, it reinterprets the bare date string as midnight UTC. For users located in timezones behind UTC, this causes the displayed date to shift backward by one calendar day until the backend response returns the correctly normalized data, resulting in a temporary visual flicker (#99336)
Explanation of Change
[Single-use and Expire-by virtual cards]: update edit card flow
Fixed Issues
$ #77672
PROPOSAL:
Tests
Precondition: Already assigned a virtual card with single-use limitType and set the expiry date
validFromandvalidThrudates are clearedvalidFromandvalidThrudates are updated.Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-09.at.15.09.57.mov
Android: mWeb Chrome
Screen.Recording.2026-02-09.at.15.14.16.mov
iOS: Native
Screen.Recording.2026-02-09.at.15.12.24.mov
iOS: mWeb Safari
Screen.Recording.2026-02-09.at.15.07.18.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-09.at.15.15.24.mov