Repository navigation
[Single-use and Expire-by virtual cards]: update card to display for employee - #81832
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fb053f280
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@nkdengineer can you check the comments above? |
| if (!validFrom || !validThru) { | ||
| return; | ||
| } | ||
| const formatDateForDisplay = (utcDateTime: string): string => { |
There was a problem hiding this comment.
let's move this function outside
|
@nkdengineer to review comments |
|
I already updated, just waiting another round from @dukenv0307 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-12.at.17.02.47.movAndroid: mWeb ChromeScreen.Recording.2026-02-12.at.16.56.29.moviOS: HybridAppScreen.Recording.2026-02-12.at.17.09.47.moviOS: mWeb SafariScreen.Recording.2026-02-12.at.16.55.30.movMacOS: Chrome / SafariScreen.Recording.2026-02-12.at.16.49.33.mov |
|
@Expensify/design can you guys please take a look? Thanks |
|
Yeah that looks correct to me 👍 |
|
Agree |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.19-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.19-5 🚀
|
|
This PR causes the limit type to be shown twice when the card is revealed. |
Explanation of Change
[Single-use and Expire-by virtual cards]: update card to display for employee
Fixed Issues
$ #77672
PROPOSAL:
Tests
Precondition: the employee has been assigned a single-use Expensify Card
Limit typerow is displayedOffline tests
No
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari