Repository navigation
Fixed race conditions and redundant writes in OnyxDerived initialisation - #82161
Conversation
|
@shubham1206agra Could you check if these concerns/follow-ups raised by Claude make sense? Proposal Review: Fix race conditions in OnyxDerived initialisationContextThis is a review of a proposal (with draft PR #82161) that claims to fix race conditions in Key files examined:
Verdict: The proposal is technically soundAll three problems identified are real and verifiable in the source code. The proposed solutions are correct. Below is a detailed breakdown. Problem 1:
|
|
@fabioh8010 1st is the valid concern. I can remove this dead code. 2nd one is not related to this PR. If it actually becomes a problem, we have bigger issues at hand such as bootsplash not getting removed. The 3rd one looks valid, but since we already assume that any Onyx value can be undefined, we already have this issue handled throughout the codebase. |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-25.at.20.20.35.movAndroid: mWeb ChromeScreen.Recording.2026-02-25.at.20.21.48.moviOS: HybridAppScreen.Recording.2026-02-25.at.19.36.26.moviOS: mWeb SafariScreen.Recording.2026-02-25.at.19.32.47.movMacOS: Chrome / SafariScreen.Recording.2026-02-25.at.19.27.27.movScreen.Recording.2026-02-25.at.19.26.23.mov |
|
@shubham1206agra My Android app is stuck on the splash screen, I can’t reproduce the issue on the main branch. See the recording below at 00:35 Screen.Recording.2026-02-25.at.19.47.34.mov |
@linhvovan29546 This seems odd since this system is not connected to Bootsplash logic in any way. |
|
@linhvovan29546 Also, check the logs please |
|
@shubham1206agra I can reproduce this on main after pulling the latest main branch locally, so it’s not caused by this PR. |
mountiny
left a comment
There was a problem hiding this comment.
Thanks for the changes, lets keep an eye out for any odd bugs
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Explanation of Change
Fixed Issues
$ #83426
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-02-25.at.3.49.16.PM.mov