Repository navigation
Use date-fns parse for split date range to fix timezone offset - #82501
Merged
mountiny merged 3 commits intoMar 2, 2026
Merged
Conversation
MobileMage
marked this pull request as ready for review
February 17, 2026 14:47
melvin-bot
Bot
requested review from
heyjennahay and
rojiphil
and removed request for
a team
February 17, 2026 14:47
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp82501-android-hybrid-001.mp4Android: mWeb Chrome82501-mweb-chrome-001.mp4iOS: HybridApp82501-ios-hybrid-001.mp4iOS: mWeb Safari82501-mweb-safari-001.mp4MacOS: Chrome / Safari82501-web-chrome-001.mp4 |
rojiphil
approved these changes
Feb 18, 2026
rojiphil
left a comment
Contributor
There was a problem hiding this comment.
Thanks @MobileMage for the PR.
@mountiny Changes LGTM and works well too.
Over to you. Thanks.
mountiny
requested changes
Feb 19, 2026
mountiny
left a comment
Contributor
There was a problem hiding this comment.
Can you make sure to add unit test for this @MobileMage
Contributor
|
@MobileMage Bump on addressing this comment |
mountiny
approved these changes
Mar 2, 2026
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.31-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When splitting an expense by date range,
new Date("2024-01-16")interprets the date string as midnight UTC. For users in negative UTC offset timezones (e.g. US Pacific at UTC-8), this gets converted to the previous day in local time, causing all split dates to shift one day earlier.This replaces
new Date(startDate)andnew Date(endDate)withparse()from date-fns, which interprets date strings as midnight in the local timezone instead of UTC. This matches the existing pattern used inDateUtils.tsandValidationUtils.ts.Fixed Issues
$ #80530
PROPOSAL: #80530 (comment)
Tests
Offline tests
N/A - The date parsing change is purely local computation and does not involve network requests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
80530.mp4