Repository navigation
[NoQA] Feature: Travel Invoicing – Release 7.2: Add “Pay Balance” Button - #82753
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Update needed: we shouldn't show the pay balance button if settlement frequency is daily. |
| [READ_COMMANDS.OPEN_POLICY_ACCOUNTING_PAGE]: Parameters.OpenPolicyAccountingPageParams; | ||
| [READ_COMMANDS.OPEN_POLICY_EXPENSIFY_CARDS_PAGE]: Parameters.OpenPolicyExpensifyCardsPageParams; | ||
| [READ_COMMANDS.OPEN_POLICY_TRAVEL_PAGE]: Parameters.OpenPolicyTravelPageParams; | ||
| [WRITE_COMMANDS.PAY_TRAVEL_INVOICING_SPEND]: Parameters.PayTravelInvoicingSpendParams; |
There was a problem hiding this comment.
parameter mapping was placed inside ReadCommandParameters instead of WriteCommandParameters, is this intentional?
There was a problem hiding this comment.
By mistake - I corrected ✅
There was a problem hiding this comment.
should be wrapped in TRAVEL_US: { ... } to match the other tests?
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✅ Updated the logic Updated the PR Author Checklist with manual tests (see Slack thread for details on full-flow testing), and completed the checklist. 🟢 Ready for review! |
|
|
||
| jest.mock('@libs/actions/TravelInvoicing', () => { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | ||
| const actual = jest.requireActual('@libs/actions/TravelInvoicing'); |
There was a problem hiding this comment.
❌ CONSISTENCY-5 (docs)
The eslint-disable-next-line comments on lines 65 and 67 lack accompanying justification comments explaining why the rules are being disabled.
Add a brief reason for each disable:
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- jest.requireActual returns `any` by design
const actual = jest.requireActual('@libs/actions/TravelInvoicing');
// eslint-disable-next-line @typescript-eslint/no-unsafe-return -- spreading the `any` result from requireActual
return {Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d528a9a99b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const travelSpend = getTravelSpend(travelSettings); | ||
|
|
||
| // Derive the payment queued state from the manual billing Onyx key | ||
| const isPaymentQueued = !!cardManualBilling; |
There was a problem hiding this comment.
Gate queued state by travel feed before hiding pay balance
This treats private_expensifyCardManualBilling_<workspaceAccountID> as a travel-specific queued signal, then hides the Travel “Pay balance” CTA and forces current spend to $0.00 whenever it is truthy. That Onyx key is workspace-wide and is also used by the regular Expensify Card settlement flow (see queueExpensifyCardForBilling(CONST.COUNTRY.US, defaultFundID) in WorkspaceCardsListLabel), so queueing a non-travel card payment can incorrectly make Travel Invoicing appear already queued/paid and remove the Travel pay action while travel balance is still outstanding.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
✅ That's how I've been instructed to have things work based on this Slack comment.
There was a problem hiding this comment.
Yeah, it is a good point, but I think it is how we expect this to work... @blimpich for a double check.
When we queue a travel invoicing payment we don't make any distinction what will be paid, but the
workspaceAccoutnID should be travel specific so this should not be an issue, is that right?
|
❌ Failing unit test not related to this PRs changes. |
|
BUG: Android: IOS: App crashing on clicking pay button. 06.03.2026_19.02.33_REC.mp406.03.2026_19.02.59_REC.mp4 |
✅ Fixed - it was caused by the View wrapping the button with ☑️ Merged main to resolve conflicts |
Screenshots🔲 iOS / native06.03.2026_23.46.35_REC.mp4🔲 iOS / Safari06.03.2026_18.59.58_REC.mp4🔲 MacOS / Chrome06.03.2026_18.52.37_REC.mp4🔲 Android / Chrome🔲 Android / native06.03.2026_23.46.13_REC.mp4 |
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
I didn't get around to testing this today, apologies. Will test early next week. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Part of an internal product and design initiative, so not going to review carefully.
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.35-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.35-1 🚀
|

Explanation of Change
UX Flow
WorkspaceTravelInvoicingSectionshows a “Pay balance” button within the Travel Invoicing summary area (e.g., below “Current Travel Spend / Limit” and settlement details).Data & Onyx
The button’s visibility and enabled state are driven by selectors on top of existing Onyx data:
getIsTravelInvoicingEnabled(policyID)– same as in Release 2; button only shows when this is true.private_expensifyCardSettingsobject (TRAVEL_USentry), not the policy object. Frontend should use a selector that reads the travel feed fromprivate_expensifyCardSettings.getOutstandingTravelBalanceAmount(policy)– used for display only if we choose to show the amount near the button (optional).After a successful pay‑now call, we rely on:
Policy.fetchPolicy(policyID)(or similar) to refreshONYXKEYS.COLLECTION.POLICYso that:hasOutstandingTravelBalance(policy)flips to false when the balance is cleared.Actions
In
src/libs/actions/TravelInvoicing.ts, add:PayTravelInvoicingSpend({policyID}):PayTravelInvoicingSpend(which itself wrapsQueueExpensifyCardForBillingon the server for thePROGRAM_TRAVEL_USfeed).Promise.Policy.fetchPolicy(policyID)to refresh the policy and outstanding balance.PromisesoWorkspaceTravelInvoicingSectioncan clear its loading state.Components
WorkspaceTravelInvoicingSection:getIsTravelInvoicingEnabled(policyID)istrue, andhasOutstandingTravelBalance(policy)istrue, andButton/TextButton) with:translate('travelInvoicing.payBalanceButton')→ “Pay balance”.onPresshandler that:isPayingBalanceflag.PayTravelInvoicingSpend({policyID}).isPayingBalanceonce thePromiseresolves/rejects.isPayingBalanceistrue, the button shows a loading spinner and is disabled.Testing
Component tests for
WorkspaceTravelInvoicingSection:getIsTravelInvoicingEnabled(policyID)istrueandhasOutstandingTravelBalance(policy)istrue, the “Pay balance” button renders; otherwise it does not.PayTravelInvoicingSpend({policyID})is called and the button enters a loading/disabled state.hasOutstandingTravelBalance(policy)switches to false, the “Pay balance” button no longer renders.Note
There's been updates to the design and BE logic, more details here in Slack 🧵.
Fixed Issues
$ #78704
PROPOSAL:
Tests
Precondition: Navigate to a workspace travel page with Central Invoicing enabled and settlement frequency set to Monthly.
Note
If Settlement frequency is set to Daily, verify the "Pay balance" button does not appear even with a positive travel spend.
getTravelSpendinTravelInvoicingUtils.tsto return a positive amount (e.g., return10000; for $100.00).PayTravelInvoicingSpendAPI call fires in the Network tab with the correctdomainAccountID.cardManualBillingto true (or setisPaymentQueued = truedirectly inWorkspaceTravelInvoicingSection) to simulate the payment queued status.Offline tests
Precondition: Same as online test above — Central Invoicing enabled, monthly frequency, positive travel spend (hardcoded).
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-03-05.at.17.48.44.mov
OFFLINE - BLOCKING (BUTTON DISABLED)