Skip to content

[NoQA] Feature: Travel Invoicing – Release 7.2: Add “Pay Balance” Button - #82753

Merged
rlinoz merged 10 commits into
Expensify:mainfrom
ikevin127:ikevin127-travel-invoicing-72
Mar 10, 2026
Merged

rlinoz merged 10 commits into
Expensify:mainfrom
ikevin127:ikevin127-travel-invoicing-72

Conversation

@ikevin127

@ikevin127 ikevin127 commented Feb 18, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

UX Flow

  • When Travel Invoicing is enabled and there is an outstanding travel balance, WorkspaceTravelInvoicingSection shows a “Pay balance” button within the Travel Invoicing summary area (e.g., below “Current Travel Spend / Limit” and settlement details).
  • The button is only visible to workspace admins (same permission gate as other billing‑sensitive controls on the page).
  • When the admin taps “Pay balance”:
    • We show a loading state on the button and disable it to prevent double‑submits.
    • We call the new backend command to pay the current Travel Invoicing balance immediately.
    • On success:
      • We show a localized success toast (e.g., “We’re processing payment for your current travel balance now.”).
      • We trigger a policy refresh so that the outstanding balance updates in the summary (and, if the balance becomes zero, the “Pay balance” button disappears automatically).
    • On failure:
      • We show a localized error toast.
      • We clear the loading state and leave the button enabled so the user can retry.

Data & Onyx
The button’s visibility and enabled state are driven by selectors on top of existing Onyx data:

  • getIsTravelInvoicingEnabled(policyID) – same as in Release 2; button only shows when this is true.
  • Button only shows when there is an outstanding travel balance. This value will come from the domain-level private_expensifyCardSettings object (TRAVEL_US entry), not the policy object. Frontend should use a selector that reads the travel feed from private_expensifyCardSettings.
  • getOutstandingTravelBalanceAmount(policy) – used for display only if we choose to show the amount near the button (optional).

After a successful pay‑now call, we rely on:

  • The backend updating the outstanding travel balance (and any related fields) in the policy NVP / travel‑balance Onyx key.
  • An existing Policy.fetchPolicy(policyID) (or similar) to refresh ONYXKEYS.COLLECTION.POLICY so that:
    • hasOutstandingTravelBalance(policy) flips to false when the balance is cleared.
    • The “Pay balance” button automatically hides because its visibility selector is now false.

Actions
In src/libs/actions/TravelInvoicing.ts, add:

  • PayTravelInvoicingSpend({policyID}):
    • Wraps the new backend command PayTravelInvoicingSpend (which itself wraps QueueExpensifyCardForBilling on the server for the PROGRAM_TRAVEL_US feed).
    • Returns a Promise.
    • On success:
      • Optionally calls Policy.fetchPolicy(policyID) to refresh the policy and outstanding balance.
      • Does not attempt to compute a new balance on the client – the backend remains the source of truth.
    • On failure:
      • Surfaces a localized error toast using existing error helpers.
      • Rejects the Promise so WorkspaceTravelInvoicingSection can clear its loading state.

Components
WorkspaceTravelInvoicingSection:

  • Adds a “Pay balance” button into the Travel Invoicing summary area, rendered only when:
    • getIsTravelInvoicingEnabled(policyID) is true, and
    • hasOutstandingTravelBalance(policy) is true, and
    • The viewer is an admin for the workspace.
  • Uses an existing button component (e.g., Button / TextButton) with:
    • Label: translate('travelInvoicing.payBalanceButton') → “Pay balance”.
    • onPress handler that:
      • Sets a local isPayingBalance flag.
      • Calls PayTravelInvoicingSpend({policyID}).
      • Clears isPayingBalance once the Promise resolves/rejects.
  • While isPayingBalance is true, the button shows a loading spinner and is disabled.

Testing
Component tests for WorkspaceTravelInvoicingSection:

  • When getIsTravelInvoicingEnabled(policyID) is true and hasOutstandingTravelBalance(policy) is true, the “Pay balance” button renders; otherwise it does not.
  • When the user taps “Pay balance”, PayTravelInvoicingSpend({policyID}) is called and the button enters a loading/disabled state.
  • After a mocked successful response and policy refresh where hasOutstandingTravelBalance(policy) switches to false, the “Pay balance” button no longer renders.
  • On a mocked failure, a localized error is shown and the button returns to the enabled state.

Note

There's been updates to the design and BE logic, more details here in Slack 🧵.

Fixed Issues

$ #78704
PROPOSAL:

Tests

Precondition: Navigate to a workspace travel page with Central Invoicing enabled and settlement frequency set to Monthly.

Note

If Settlement frequency is set to Daily, verify the "Pay balance" button does not appear even with a positive travel spend.

  1. Hardcode getTravelSpend in TravelInvoicingUtils.ts to return a positive amount (e.g., return 10000; for $100.00).
  2. Verify the "Pay balance" button is visible next to the current travel spend amount.
  3. Press the "Pay balance" button.
  4. Verify a confirmation modal appears with title "Pay balance of $100.00?" and body text warning the action cannot be undone.
  5. Press "Pay balance" in the confirmation modal.
  6. Verify the PayTravelInvoicingSpend API call fires in the Network tab with the correct domainAccountID.
  7. Hardcode cardManualBilling to true (or set isPaymentQueued = true directly in WorkspaceTravelInvoicingSection) to simulate the payment queued status.
  8. Verify the "Pay balance" button is no longer visible because the payment was queued.
  9. Verify the current travel spend shows $0.00.
  10. Verify a subtitle appears below the current spend amount: "Payment of $100.00 is queued and will be processed soon."
  • Verify that no errors appear in the JS console

Offline tests

Precondition: Same as online test above — Central Invoicing enabled, monthly frequency, positive travel spend (hardcoded).

  1. Verify the "Pay balance" button is visible and enabled while online.
  2. Toggle the device/simulator to offline mode.
  3. Verify the "Pay balance" button is still visible but disabled (grayed out, not pressable).
  4. Toggle back to online.
  5. Verify the button becomes enabled again and can be pressed.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-03-05.at.17.48.44.mov

OFFLINE - BLOCKING (BUTTON DISABLED)

offline-blocking

@melvin-bot

melvin-bot Bot commented Feb 18, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Feb 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/API/types.ts 100.00% <ø> (ø)
...rkspace/travel/WorkspaceTravelInvoicingSection.tsx 67.28% <95.00%> (+5.99%) ⬆️
src/libs/actions/TravelInvoicing.ts 57.35% <0.00%> (-4.56%) ⬇️
... and 12 files with indirect coverage changes

@blimpich

blimpich commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Update needed: we shouldn't show the pay balance button if settlement frequency is daily.

Comment thread src/libs/API/types.ts Outdated
[READ_COMMANDS.OPEN_POLICY_ACCOUNTING_PAGE]: Parameters.OpenPolicyAccountingPageParams;
[READ_COMMANDS.OPEN_POLICY_EXPENSIFY_CARDS_PAGE]: Parameters.OpenPolicyExpensifyCardsPageParams;
[READ_COMMANDS.OPEN_POLICY_TRAVEL_PAGE]: Parameters.OpenPolicyTravelPageParams;
[WRITE_COMMANDS.PAY_TRAVEL_INVOICING_SPEND]: Parameters.PayTravelInvoicingSpendParams;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter mapping was placed inside ReadCommandParameters instead of WriteCommandParameters, is this intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By mistake - I corrected ✅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be wrapped in TRAVEL_US: { ... } to match the other tests?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Done

@blimpich
blimpich requested review from blimpich and rlinoz March 5, 2026 23:12
@ikevin127
ikevin127 marked this pull request as ready for review March 6, 2026 02:17
@ikevin127
ikevin127 requested review from a team as code owners March 6, 2026 02:17
@melvin-bot
melvin-bot Bot requested review from parasharrajat and removed request for a team March 6, 2026 02:17
@melvin-bot

melvin-bot Bot commented Mar 6, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team March 6, 2026 02:17
@ikevin127

Copy link
Copy Markdown
Contributor Author

Update needed: we shouldn't show the pay balance button if settlement frequency is daily.

✅ Updated the logic


Updated the PR Author Checklist with manual tests (see Slack thread for details on full-flow testing), and completed the checklist. 🟢 Ready for review!


jest.mock('@libs/actions/TravelInvoicing', () => {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const actual = jest.requireActual('@libs/actions/TravelInvoicing');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CONSISTENCY-5 (docs)

The eslint-disable-next-line comments on lines 65 and 67 lack accompanying justification comments explaining why the rules are being disabled.

Add a brief reason for each disable:

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- jest.requireActual returns `any` by design
const actual = jest.requireActual('@libs/actions/TravelInvoicing');
// eslint-disable-next-line @typescript-eslint/no-unsafe-return -- spreading the `any` result from requireActual
return {

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d528a9a99b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

const travelSpend = getTravelSpend(travelSettings);

// Derive the payment queued state from the manual billing Onyx key
const isPaymentQueued = !!cardManualBilling;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate queued state by travel feed before hiding pay balance

This treats private_expensifyCardManualBilling_<workspaceAccountID> as a travel-specific queued signal, then hides the Travel “Pay balance” CTA and forces current spend to $0.00 whenever it is truthy. That Onyx key is workspace-wide and is also used by the regular Expensify Card settlement flow (see queueExpensifyCardForBilling(CONST.COUNTRY.US, defaultFundID) in WorkspaceCardsListLabel), so queueing a non-travel card payment can incorrectly make Travel Invoicing appear already queued/paid and remove the Travel pay action while travel balance is still outstanding.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ That's how I've been instructed to have things work based on this Slack comment.

@rlinoz rlinoz Mar 6, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is a good point, but I think it is how we expect this to work... @blimpich for a double check.

When we queue a travel invoicing payment we don't make any distinction what will be paid, but the
workspaceAccoutnID should be travel specific so this should not be an issue, is that right?

@ikevin127

Copy link
Copy Markdown
Contributor Author

❌ Failing unit test not related to this PRs changes.

@parasharrajat

Copy link
Copy Markdown
Member

BUG: Android: IOS: App crashing on clicking pay button.

06.03.2026_19.02.33_REC.mp4
06.03.2026_19.02.59_REC.mp4

@ikevin127

Copy link
Copy Markdown
Contributor Author

BUG: Android: IOS: App crashing on clicking pay button.

✅ Fixed - it was caused by the View wrapping the button with styles.wFitContent which was messing with the button's reanimated animation causing crash. I removed the wrapper view as it's not needed - checked both web / mobile and looks good 🟢

☑️ Merged main to resolve conflicts

@parasharrajat

Copy link
Copy Markdown
Member

Screenshots

🔲 iOS / native

06.03.2026_23.46.35_REC.mp4

🔲 iOS / Safari

06.03.2026_18.59.58_REC.mp4

🔲 MacOS / Chrome

06.03.2026_18.52.37_REC.mp4

🔲 Android / Chrome

🔲 Android / native

06.03.2026_23.46.13_REC.mp4

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@blimpich

blimpich commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

I didn't get around to testing this today, apologies. Will test early next week.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of an internal product and design initiative, so not going to review carefully.

@blimpich

blimpich commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Seems to work from my testing! Here's what I did

  1. setup a branch new account and enabled travel invoicing on it using ../script/clitools.sh expensifytravel:setupInvoicing --enable
  2. added fake transaction data to it using ../script/clitools.sh expensifytravel:billing
  3. went to workspaces > travel
  4. switched from daily settlement to monthly settlement
  5. confirmed the pay balance button appeared
  6. Switched back to daily settlement to confirm it works, then back to monthly. Worked as expected.

I tried running card billing locally in order to test clearing this, but I'm not sure if it's possible to test locally. It cleared the "private_expensifyCardManualBilling NVP when I ran it but didn't clear the transactions themselves, since card billing wasn't actually run for real. Either way, that's a backend problem, so I'm good with merging this 👍

Screenshot 2026-03-09 at 2 00 04 PM

@blimpich blimpich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlinoz final review goes to you

@rlinoz
rlinoz merged commit 39f0527 into Expensify:main Mar 10, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 10, 2026
46 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.35-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.35-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants