Repository navigation
[NoQA] Feature: Travel Invoicing – Release 10: Add Legal Name Capture Flow to NewDot - #82759
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@parasharrajat 🟢 Ready for review! Check latest Slack discussion for context. |
| [SCREENS.WORKSPACE.TRAVEL]: [ | ||
| SCREENS.WORKSPACE.TRAVEL_SETTINGS_ACCOUNT, | ||
| SCREENS.WORKSPACE.TRAVEL_SETTINGS_FREQUENCY, | ||
| SCREENS.WORKSPACE.TRAVEL_MISSING_PERSONAL_DETAILS, |
There was a problem hiding this comment.
❌ CONSISTENCY-2 (docs)
SCREENS.WORKSPACE.TRAVEL_MISSING_PERSONAL_DETAILS_ROOT and SCREENS.WORKSPACE.TRAVEL_MISSING_PERSONAL_DETAILS_CONFIRM_MAGIC_CODE are referenced here but never defined in src/SCREENS.ts. Only SCREENS.WORKSPACE.TRAVEL_MISSING_PERSONAL_DETAILS (under WORKSPACE) and SCREENS.TRAVEL.MISSING_PERSONAL_DETAILS_CONFIRM_MAGIC_CODE (under TRAVEL, not WORKSPACE) are defined in this PR. These undefined references will cause TypeScript compilation errors or runtime failures.
Remove the undefined references and use only the constants that are actually defined:
[SCREENS.WORKSPACE.TRAVEL]: [
SCREENS.WORKSPACE.TRAVEL_SETTINGS_ACCOUNT,
SCREENS.WORKSPACE.TRAVEL_SETTINGS_FREQUENCY,
SCREENS.WORKSPACE.TRAVEL_MISSING_PERSONAL_DETAILS,
],Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| const {isBetaEnabled} = usePermissions(); | ||
| const [isPreventionModalVisible, setPreventionModalVisibility] = useState(false); | ||
| const [isVerificationModalVisible, setVerificationModalVisibility] = useState(false); | ||
| const [privatePersonalDetails] = useOnyx(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, {canBeMissing: true}); |
There was a problem hiding this comment.
❌ PERF-11 (docs)
PRIVATE_PERSONAL_DETAILS is subscribed to without a selector, but only legalFirstName and legalLastName are needed (via areTravelPersonalDetailsMissing). Any change to other fields in private personal details (address, phone number, etc.) will cause an unnecessary re-render of this component.
Use a selector that computes the boolean directly:
const [areTravelDetailsMissing] = useOnyx(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, {
canBeMissing: true,
selector: (details) => \!details?.legalFirstName || \!details?.legalLastName,
});Then use areTravelDetailsMissing directly in the condition instead of calling areTravelPersonalDetailsMissing(privatePersonalDetails).
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true}); | ||
| const [bankAccountList] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST, {canBeMissing: true}); | ||
| const [reimbursementAccount] = useOnyx(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {canBeMissing: true}); | ||
| const [privatePersonalDetails] = useOnyx(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, {canBeMissing: true}); |
There was a problem hiding this comment.
❌ PERF-11 (docs)
PRIVATE_PERSONAL_DETAILS is subscribed to without a selector, but only legalFirstName and legalLastName are needed (via areTravelPersonalDetailsMissing). Any change to other fields in private personal details will trigger an unnecessary re-render.
Use a selector that computes the boolean directly:
const [areTravelDetailsMissing] = useOnyx(ONYXKEYS.PRIVATE_PERSONAL_DETAILS, {
canBeMissing: true,
selector: (details) => \!details?.legalFirstName || \!details?.legalLastName,
});Then use areTravelDetailsMissing directly in the condition.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| return; | ||
| } | ||
|
|
||
| if (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && areTravelPersonalDetailsMissing(privatePersonalDetails)) { |
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
This exact conditional pattern (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && areTravelPersonalDetailsMissing(privatePersonalDetails) followed by navigating to ROUTES.WORKSPACE_TRAVEL_MISSING_PERSONAL_DETAILS) is duplicated in WorkspaceTravelInvoicingSection.tsx. Both locations perform the same check and the same navigation.
Extract this into a shared helper function in a utils or actions module, e.g.:
function navigateIfTravelPersonalDetailsMissing(
isBetaEnabled: (beta: string) => boolean,
privatePersonalDetails: OnyxEntry<PrivatePersonalDetails>,
policyID: string,
): boolean {
if (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && areTravelPersonalDetailsMissing(privatePersonalDetails)) {
Navigation.navigate(ROUTES.WORKSPACE_TRAVEL_MISSING_PERSONAL_DETAILS.getRoute(policyID));
return true;
}
return false;
}Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dc9248028
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && areTravelPersonalDetailsMissing(privatePersonalDetails)) { | ||
| Navigation.navigate(ROUTES.WORKSPACE_TRAVEL_MISSING_PERSONAL_DETAILS.getRoute(policy?.id ?? String(CONST.DEFAULT_NUMBER_ID))); |
There was a problem hiding this comment.
Gate legal-name redirect on workspace invoicing state
This condition only checks the TRAVEL_INVOICING beta flag, so any beta-enabled user with missing legal names is redirected to the invoicing-specific personal-details flow even when the selected workspace is not using Travel Invoicing. Because this runs before the existing booking eligibility checks, it changes the normal booking/upgrade path for non-invoicing policies and introduces an unnecessary hard gate; the redirect should be conditioned on the workspace’s actual invoicing state, not just the beta.
Useful? React with 👍 / 👎.
| const handleSubmit = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.PERSONAL_DETAILS_FORM>) => { | ||
| updateLegalName(values.legalFirstName?.trim() ?? '', values.legalLastName?.trim() ?? '', formatPhoneNumber, currentUserPersonalDetails); |
There was a problem hiding this comment.
Submit travel legal name via SetPrivatePersonalDetails
The new travel legal-name page submits through updateLegalName (UpdateLegalName) and immediately exits, while the newly added SetPrivatePersonalDetails write command (with required validateCode) is never invoked by this flow. That means the travel-specific private-details update path introduced in this commit is bypassed, so the legal-name capture flow can complete without running the intended verified backend update for travel provisioning.
Useful? React with 👍 / 👎.
|
Hi, does it need c+ review? asking since it was requested. |
|
@abzokhattab Sorry for the ping, this will be reviewed by @parasharrajat as it's part of a project. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Design doc project
…7-travel-invoicing-10
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
24.02.2026_14.53.39_REC.mp4
🎀 👀 🎀 C+ reviewed
|
Looks good. |
|
The PR body description lists everything from release 10, including the backend changes. Can we please shorten it to just include the changes relevant to this PR? |
rlinoz
left a comment
There was a problem hiding this comment.
Looks good, just the validation thing about the name.
There was a problem hiding this comment.
I agree this would be better if we reused the LegalPageName
Validation Logic: The Travel page applies isValidLegalName to check for specific characters, whereas the profile settings page checks for reserved words via doesContainReservedWord.
As for this, we probably should have the same validate function we have in LegalPageName, no?
| return; | ||
| } | ||
|
|
||
| if (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && areTravelPersonalDetailsMissing(privatePersonalDetails)) { |
There was a problem hiding this comment.
NAB: We only display this section if the beta is enabled, so I think we could remove it here.
|
🟢 Ready for review |
|
This can be a follow up, but after setting the legal name we should continue the flow to the next screen instead of just dismissing the RHP Screen.Recording.2026-02-25.at.09.12.17.mov |
| const validate = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.PERSONAL_DETAILS_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.PERSONAL_DETAILS_FORM> => { | ||
| const errors = getFieldRequiredErrors(values, STEP_FIELDS, translate); | ||
|
|
||
| const firstName = values[INPUT_IDS.LEGAL_FIRST_NAME]; | ||
| if (!isRequiredFulfilled(firstName)) { | ||
| errors[INPUT_IDS.LEGAL_FIRST_NAME] = translate('common.error.fieldRequired'); | ||
| } else if (!isValidLegalName(firstName)) { | ||
| errors[INPUT_IDS.LEGAL_FIRST_NAME] = translate('privatePersonalDetails.error.hasInvalidCharacter'); | ||
| } else if (firstName.length > CONST.LEGAL_NAME.MAX_LENGTH) { | ||
| errors[INPUT_IDS.LEGAL_FIRST_NAME] = translate('common.error.characterLimitExceedCounter', firstName.length, CONST.LEGAL_NAME.MAX_LENGTH); | ||
| } | ||
|
|
||
| const lastName = values[INPUT_IDS.LEGAL_LAST_NAME]; | ||
| if (!isRequiredFulfilled(lastName)) { | ||
| errors[INPUT_IDS.LEGAL_LAST_NAME] = translate('common.error.fieldRequired'); | ||
| } else if (!isValidLegalName(lastName)) { | ||
| errors[INPUT_IDS.LEGAL_LAST_NAME] = translate('privatePersonalDetails.error.hasInvalidCharacter'); | ||
| } else if (lastName.length > CONST.LEGAL_NAME.MAX_LENGTH) { | ||
| errors[INPUT_IDS.LEGAL_LAST_NAME] = translate('common.error.characterLimitExceedCounter', lastName.length, CONST.LEGAL_NAME.MAX_LENGTH); | ||
| } | ||
|
|
||
| return errors; | ||
| }; |
There was a problem hiding this comment.
Why this is different than the one in LegalNamePage?
There was a problem hiding this comment.
No difference, unified to use LegalNamePage validation function ✅
| }; | ||
|
|
||
| function LegalNamePage() { | ||
| function BaseLegalNamePage<TFormID extends OnyxFormKey>({ |
There was a problem hiding this comment.
Can you create a separate component file for this?
✅ Fixed
🟢 Ready for review |
|
Wasn't able to get around to reviewing this today, apologies, will review first thing tomorrow morning |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Explanation of Change
Release 10: Capture Traveler's Legal Name
When travel cards are used at hotels and car rental agencies, we want the charge to display the traveler's actual legal name rather than a generic corporate billing name. This makes the card appear more like a personal credit card, reducing CCA (Credit Card Authorization) issues and friction for the traveler.
Since users don't always provide their legal name at signup, we need to capture it before they can book travel with Travel Invoicing. The existing
SetPrivatePersonalDetailscommand already handles updating the Marqeta card object. We'll extend it to also push the updated name to Spotnana.UX Flow:
SetPrivatePersonalDetailsupdates details + Marqeta card name + Spotnana profile10.1 Add navigation infrastructure
Register the new RHP routes and screens for the personal details capture flow:
TRAVEL_MISSING_PERSONAL_DETAILSandTRAVEL_MISSING_PERSONAL_DETAILS_CONFIRM_MAGIC_CODEroutes tosrc/ROUTES.tssrc/SCREENS.ts(both inRIGHT_MODALand root level)TravelMissingPersonalDetailsParamListtype tosrc/libs/Navigation/types.tsand include it inRightModalNavigatorParamListsrc/libs/Navigation/linkingConfig/config.tsTravelMissingPersonalDetailsModalStackNavigatorinsrc/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsxsrc/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsxThis follows the existing pattern used by MissingPersonalDetailsModalStackNavigator.
10.2 Create personal details RHP pages
Create two new pages under
src/pages/Travel/TravelMissingPersonalDetails/:index.tsx- Main RHP component that reuses MissingPersonalDetailsContent (same component used byExpensifyCardMissingDetailsPage). On completion, navigates to the magic code confirmation page.TravelMissingPersonalDetailsMagicCodePage.tsx- Handles magic code verification using ValidateCodeActionModal. CallsupdatePersonalDetailsAndShipExpensifyCardson submission, then redirects to travel.expensify.com on success.10.3 Add legal name check to BookTravelButton
Modify BookTravelButton.tsx to check for missing legal name when Travel Invoicing is enabled:
PRIVATE_PERSONAL_DETAILSareTravelPersonalDetailsMissinghelper that checks iflegalFirstNameorlegalLastNameis missing (can be added toPersonalDetailsUtils.ts)bookATripcallback, after theisPolicyProvisionedcheck and beforeopenTravelDotLink, add a check: if Travel Invoicing is enabled and legal name is missing, navigate to the new RHP instead of proceeding to travel booking10.4 Add translation keys
Add new translation keys to
src/languages/en.tsandsrc/languages/es.tsin thetravelsection:personalDetailsDescription- Explanation of why legal name is neededFixed Issues
$ #78720
PROPOSAL:
Tests
Test Scenario 1: Booking Travel via "Let's go" button
Pre-requisites:
Steps:
Test Scenario 2: Enabling Central Invoicing in Workspace settings
Pre-requisites:
Travel Invoicingbeta enabled and Travel Invoicing setup and ready to go.Steps:
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Test 1
1.mov
Test 2
2.mov