Skip to content

GIACT Personal Bank Account checks differ on New Dot and Old Dot - #82812

Merged
srikarparsi merged 11 commits into
Expensify:mainfrom
callstack-internal:bypass-giact
Apr 17, 2026
Merged

srikarparsi merged 11 commits into
Expensify:mainfrom
callstack-internal:bypass-giact

Conversation

@narefyev91

Copy link
Copy Markdown
Contributor

Explanation of Change

On Old Dot, if GIACT fails while adding a personal bank account, the user gets a warning and is able to resubmit. On New Dot, if GIACT fails, users are not able to add a personal bank account.

Fixed Issues

$ #82083
PROPOSAL:

Tests

  1. Start manual personal bank account setup
  2. Add all required details (account number, phone, user details) - move to last screen with confirmation - submit
  3. Verify that error "Unable to verify bank account ownership" - is presented
  4. Click submit again - verify that bank account is added
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Start manual personal bank account setup
  2. Add all required details (account number, phone, user details) - move to last screen with confirmation - submit
  3. Verify that error "Unable to verify bank account ownership" - is presented
  4. Click submit again - verify that bank account is added
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Details Screenshot 2026-02-18 at 13 33 16

@narefyev91
narefyev91 requested review from a team as code owners February 18, 2026 14:51
@melvin-bot
melvin-bot Bot requested review from heyjennahay and mananjadhav and removed request for a team February 18, 2026 14:51
@melvin-bot

melvin-bot Bot commented Feb 18, 2026

Copy link
Copy Markdown

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@narefyev91

Copy link
Copy Markdown
Contributor Author

we are waiting on BE fix

@codecov

codecov Bot commented Feb 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/BankAccounts.ts 9.41% <ø> (ø)
src/types/form/PersonalBankAccountForm.ts 0.00% <ø> (ø)
...tionalDepositAccount/PersonalInfo/PersonalInfo.tsx 0.00% <0.00%> (ø)
... and 13 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79e6becb67

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@narefyev91

Copy link
Copy Markdown
Contributor Author

@joekaufmanexpensify @mananjadhav ready for review

@joekaufmanexpensify
joekaufmanexpensify requested review from joekaufmanexpensify and removed request for heyjennahay March 5, 2026 16:55
@rafecolton

Copy link
Copy Markdown
Member

Would it be helpful for me to test this on an ad-hoc build? I encountered this bug in the wild while trying to add my personal deposit account.

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

@srikarparsi

Copy link
Copy Markdown
Contributor

Hey @rafecolton, I triggered an AdHoc build if you would like to test it out but I did test it locally and it seems to work

@srikarparsi

Copy link
Copy Markdown
Contributor

@mananjadhav do you think you could complete the review when you have a chance?

@github-actions

This comment has been minimized.

@rafecolton

Copy link
Copy Markdown
Member

I tested this, and it worked in the sense that after getting the generic error, I was able to submit the form again and add my account. However, there were a few issues:

  1. The name on the bank account was my name, which was a little weird, especially given that can't be changed in ND. (I changed it in OD.)
    Screenshot 2026-03-06 at 9 07 18 AM
  2. The three dots say to make it my "default payment method" which is unexpected since it's a deposit account
    Screenshot 2026-03-06 at 9 01 27 AM
  3. In OD, it still shows as needing to be updated. I reviewed my details in OD and then the message went away. Not sure what the implications of this are in terms of the bank account working, but my gut feeling is that when the account gets set up from ND, either the ND command is not sending all the details or the BE is not processing them correctly.
    Screenshot 2026-03-06 at 9 03 00 AM

@koko57

koko57 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Hello! I will take over this PR from @narefyev91. Please ping me if any further FE change will be necessary.
I will be ooo 6th March (bank holiday in PL).

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

@mananjadhav could you start your review here? We continue to have customers report this one

moveTo,
screenIndex,
goToTheLastStep,
// eslint-disable-next-line @typescript-eslint/no-deprecated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narefyev91 Any reason why we had to add eslint-disable-next-line?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mananjadhav I am taking this over as @narefyev91 is no longer working on the project. Please ping me in any comment.

Yes, eslint was complaining we're using useSubStep hook, that is deprecated now. We're working on the project that will remove the hook completely.

@mananjadhav

Copy link
Copy Markdown
Collaborator

I did already review, I missed submitting the comment. But I'll get to testing this as soon as I finish one of my PR.

@koko57

koko57 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@mananjadhav friendly bump

@mananjadhav

Copy link
Copy Markdown
Collaborator

I tried testing this on the dev with staging server. But with the manual bank account setup I can't get to the last step. I checked different combinations and also followed the credentials I have from here. I am unable to bypass Onfido step.

@joekaufmanexpensify Do you think may be you can help with the data here?

image

@koko57

koko57 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@mananjadhav to skip the verification step you need to pass:

First name: Alberta
Second name: Charleson
Birth date: 2000-08-08
Last 4 SSN: 3333

Then company name would be: Alberta Bobbeth Charleson

@mananjadhav

Copy link
Copy Markdown
Collaborator

Let me try that.

@mananjadhav

Copy link
Copy Markdown
Collaborator

@koko57 Doesn't allow me to select 2000-08-08 and still ends up with the verification screen.

Screenshot 2026-04-10 at 8 19 38 PM

@koko57

koko57 commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor

@mananjadhav the year selector doesn't open or what's happening there? Is the date already preselected when you reach this step?

@mananjadhav

Copy link
Copy Markdown
Collaborator

@koko57 I am still stuck as I can't reproduce this error. Is there any prerequisite for the data/workspace?

Screenshot 2026-04-11 at 4 00 29 PM

cc - @joekaufmanexpensify

@koko57

koko57 commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

@mananjadhav Ok, I see the problem here - I'm sorry, I also thought that it should be Business bank account, but in the test steps it says personal.

So you should be on a completely different route - not /bank-account but /settings/wallet/add-us-bank-account

Screenshot 2026-04-13 at 09 23 50

You need to follow different steps to go to the personal BA flow.
Unfortunately, I cannot edit the test steps in the PR description, but I'll post them here:

If you're an admin of at least one workspace

  1. Go to Wallet -> Add bank accout
  2. On the What do you want to do with your bank account? page choose Get reimbursed
    (if you don't have any workspace or you're not an admin of any workspace this step is skipped and you're redirected to the personal BA flow)
  3. Choose United States in the Country selector
  4. Verify that in the next step, you see 2 options - Log into your bank account and Connect manually
  5. Choose Connect manually
  6. Fill in Routing and Account number - you can use these: 011401533 (routing), 1111222233331111 (account) - as in the screenshot in the description
  7. Fill in the name, address and phone number fields in the next steps (important: do not use Alberta Charleson - type other name)
  8. On the confirmation page click Confirm
  9. You should see an error - "Unable to verify bank account ownership"
  10. Click Confirm once again - the error should be gone and the account should be added successfully

@mananjadhav

Copy link
Copy Markdown
Collaborator

@koko57 I followed the same steps (personal account) except I used Alberta name. Let me try that once more.

@mananjadhav

Copy link
Copy Markdown
Collaborator

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari web-bank-account-error web-bank-account-success

@melvin-bot
melvin-bot Bot requested a review from srikarparsi April 14, 2026 00:27
@srikarparsi
srikarparsi merged commit cf4bbd4 into Expensify:main Apr 17, 2026
32 of 34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@koko57

koko57 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

@joekaufmanexpensify @srikarparsi, as it's my last day working on Expensify project, please ping @MrMuzyk if any regressions from this PR will be reported next week.

Thank you for the collaboration, it's been a pleasure working with you! Wishing you all the best ❤️

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

It's been so great working with you @koko57! Best of luck going forward!

@srikarparsi

srikarparsi commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

Thanks @koko57! Really enjoyed working with you as well and best of luck with whatever's next!

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR and the relevant help site articles:

No help site changes are required.

This PR fixes a behind-the-scenes bug where GIACT bank account ownership verification failures blocked users from resubmitting on New Dot. The fix transparently passes a confirmedOwnershipDetails flag on retry — no user-facing steps, labels, or flows change. The existing help site articles describe the happy path for connecting a personal bank account, which remains unchanged.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants