Repository navigation
GIACT Personal Bank Account checks differ on New Dot and Old Dot - #82812
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
we are waiting on BE fix |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79e6becb67
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
# Conflicts: # src/pages/settings/Wallet/InternationalDepositAccount/PersonalInfo/PersonalInfo.tsx
|
@joekaufmanexpensify @mananjadhav ready for review |
|
Would it be helpful for me to test this on an ad-hoc build? I encountered this bug in the wild while trying to add my personal deposit account. |
|
🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here. |
|
Hey @rafecolton, I triggered an AdHoc build if you would like to test it out but I did test it locally and it seems to work |
|
@mananjadhav do you think you could complete the review when you have a chance? |
This comment has been minimized.
This comment has been minimized.
|
Hello! I will take over this PR from @narefyev91. Please ping me if any further FE change will be necessary. |
|
@mananjadhav could you start your review here? We continue to have customers report this one |
| moveTo, | ||
| screenIndex, | ||
| goToTheLastStep, | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated |
There was a problem hiding this comment.
@narefyev91 Any reason why we had to add eslint-disable-next-line?
There was a problem hiding this comment.
@mananjadhav I am taking this over as @narefyev91 is no longer working on the project. Please ping me in any comment.
Yes, eslint was complaining we're using useSubStep hook, that is deprecated now. We're working on the project that will remove the hook completely.
|
I did already review, I missed submitting the comment. But I'll get to testing this as soon as I finish one of my PR. |
|
@mananjadhav friendly bump |
|
I tried testing this on the dev with staging server. But with the manual bank account setup I can't get to the last step. I checked different combinations and also followed the credentials I have from here. I am unable to bypass Onfido step. @joekaufmanexpensify Do you think may be you can help with the data here?
|
|
@mananjadhav to skip the verification step you need to pass: First name: Alberta Then company name would be: Alberta Bobbeth Charleson |
|
Let me try that. |
|
@koko57 Doesn't allow me to select 2000-08-08 and still ends up with the verification screen.
|
|
@mananjadhav the year selector doesn't open or what's happening there? Is the date already preselected when you reach this step? |
|
@koko57 I am still stuck as I can't reproduce this error. Is there any prerequisite for the data/workspace?
cc - @joekaufmanexpensify |
|
@mananjadhav Ok, I see the problem here - I'm sorry, I also thought that it should be Business bank account, but in the test steps it says personal. So you should be on a completely different route - not /bank-account but /settings/wallet/add-us-bank-account
You need to follow different steps to go to the personal BA flow. If you're an admin of at least one workspace
|
|
@koko57 I followed the same steps (personal account) except I used Alberta name. Let me try that once more. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
|
🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@joekaufmanexpensify @srikarparsi, as it's my last day working on Expensify project, please ping @MrMuzyk if any regressions from this PR will be reported next week. Thank you for the collaboration, it's been a pleasure working with you! Wishing you all the best ❤️ |
|
It's been so great working with you @koko57! Best of luck going forward! |
|
Thanks @koko57! Really enjoyed working with you as well and best of luck with whatever's next! |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and the relevant help site articles:
No help site changes are required. This PR fixes a behind-the-scenes bug where GIACT bank account ownership verification failures blocked users from resubmitting on New Dot. The fix transparently passes a |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|









Explanation of Change
On Old Dot, if GIACT fails while adding a personal bank account, the user gets a warning and is able to resubmit. On New Dot, if GIACT fails, users are not able to add a personal bank account.
Fixed Issues
$ #82083
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Details