Repository navigation
[Home Page] Prevent Drag&Scan for anonymous users visiting public rooms - #82926
Conversation
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| ErrorModal, | ||
| shouldShowFooter, | ||
| }: SearchPageWideProps) { | ||
| const isAnonymousUser = useIsAnonymousUser(); |
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The anonymous user check is already centralized inside useReceiptScanDrop() and exposed as isDragDisabled. SearchPage.tsx already destructures isDragDisabled from the hook, but instead of passing it as a prop to SearchPageWide, a duplicate useIsAnonymousUser() call is added here.
Pass isDragDisabled as a prop from SearchPage (which already has it) instead of calling useIsAnonymousUser() independently:
// In SearchPageWide props type:
isDragDisabled: boolean;
// In SearchPageWide usage:
<DragAndDropProvider isDisabled={isDragDisabled}>
// In SearchPage.tsx where SearchPageWide is rendered:
<SearchPageWide
...
isDragDisabled={isDragDisabled}
/>This keeps the logic in one place (useReceiptScanDrop) and avoids the duplicate hook import and call.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Code Review - PR #82926Inconsistency in
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10c80ab910
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-02-19.at.6.16.32.PM.mov |
|
@grgia Would you like to add tests for this? |
|
oooof done @ShridharGoel |
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Explanation of Change
Problem: Anonymous users (guests in a public room) see a broken "not here" page when they drag and drop an image onto the Home or
Search screens.
Changes:
Home,Search(narrow)/(wide)useReceiptScanDropso any future screen using this hook gets the guard for freeFixed Issues
$ #82722
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
https://staging.new.expensify.com/r/6594704240385493while logged out, go to Home, drag an image. No drop zone should appearPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari