Repository navigation
fix: PEX should not appear as addable bank connection - #83192
carlosmiceli merged 15 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
@joekaufmanexpensify are we not supporting PEX cards at all in NewDot? 🤔
|
I expect we will support it eventually, though I haven't yet seen any demand for it. The connection hasn't been built yet, so this is just hiding the errant PEX option that was incorrectly added for now, because it doesn't work at all. |
Do we have the numbers on existing PEX connections? Coz' doesn't this mean they can't fix or assign new cards in NewDot once migrated? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
|
@chrispader Just to check, the PR description says that Pex is no longer an option, but it also removes the "Expensify" option. Is that correct? Thank you. |
@brunovjk yes, that was intendend. The original refactoring was invalid. Expensify card was not affected by it, but it should still be removed |
|
Great, thank you for clarifying. |
|
@amyevans ready if you wanna review too! |
Answer here: VL query (just linking since I'm not sure if it's alright to discuss the number in this repo) |
amyevans
left a comment
There was a problem hiding this comment.
One thought but otherwise looking good!
Yep, this is correct. That is already the case right now though. The |
|
just merged main, should fix failing tests |
amyevans
left a comment
There was a problem hiding this comment.
Sorry that the feedback is coming in piece-meal. I had just reviewed the full diff with fresh eyes and noticed a few more quick things 😅
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 099ab3d22f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [CONST.COMPANY_CARD.FEED_BANK_NAME.BREX]: CONST.COMPANY_CARDS.BANKS.BREX, | ||
| [CONST.COMPANY_CARD.FEED_BANK_NAME.AMEX_1205]: CONST.COMPANY_CARDS.BANKS.AMEX, | ||
| [CONST.COMPANY_CARD.FEED_BANK_NAME.AMEX_FILE_DOWNLOAD]: CONST.COMPANY_CARDS.BANKS.AMEX, | ||
| [CONST.COMPANY_CARD.FEED_BANK_NAME.PEX]: CONST.COMPANY_CARDS.BANKS.PEX, |
There was a problem hiding this comment.
The last commit looks like a bit of an overcorrection:
We still need PEX in the getBankName mapping, otherwise users with an existing PEX feed will not get a proper display name
There was a problem hiding this comment.
Yes, you're right, we still need PEX in getBankName.
|
@amyevans could you verify again that the UI is looking as expected after the last commit? I cannot test PEX locally and i'm not sure how the Company cards page is affected by the PEX entry in |
amyevans
left a comment
There was a problem hiding this comment.
@amyevans could you verify again that the UI is looking as expected after the last commit? I cannot test PEX locally and i'm not sure how the Company cards page is affected by the PEX entry in getBankName
Yeah I manually faked some data to be able to test it locally. Looks good with the change though! -
Separately (as not directly related to this PR), viewing a legacy feed like Pex is a bit broken in NewDot at the moment:
pex-company-card-feed-test.mov
- When you first go to the Company cards page, you do not see the feed, because you don't have the
cards_collection data in Onyx - If you open a member profile, then you get the data via the
OpenPolicyMemberProfilePagecall - Then return back to the Company cards page and you can see the feed
@trjExpensify or @joekaufmanexpensify, do you think that is something that will get fixed as a part of the Universal Feeds project? Or should I file a separate bug?
|
@amyevans did that PEX feed have the workspace set as the |
I set it up on prod too with my test account
prod-repro.movOr you can repro on prod too setting up the Discover feed on a domain in Classic |
|
Damn, I think we need to address that then. If the preferredPolicy is set, it should show. |
|
@amyevans addressed the request about the invalid |
|
@amyevans addressed the request about the invalid getBankName mapping. Awesome, thank you!
Nah no need to address in this PR, Applause is reproducing the issue currently and will open a separate bug GH for it! |
amyevans
left a comment
There was a problem hiding this comment.
LGTM! @carlosmiceli would you like another look?
|
🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|





@carlosmiceli @amyevans
Explanation of Change
Fixes an issue caused by this PR where PEX bank now appears as an addable bank connection in the "Add card" flow. This is due to a refactoring in which i re-arranged values in
CONST/index.ts.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/601495
PROPOSAL:
Tests
Offline tests
None needed.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-02-23.at.09.46.01.mov