Repository navigation
[No QA] Create Set-Up-Traveler-Messaging.md - #83392
Conversation
Per this https://expensify.slack.com/archives/C05S5EV2JTX/p1770220769286929 in Slack, we have enabled Traveler Messaging for travel customers, so we need a help doc. I confirmed multiple travel customers have the option available to them when viewing their travel setup.
|
A preview of your ExpensifyHelp changes have been deployed to https://95a060b7.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new help article for Traveler Messaging, a feature recently enabled for travel customers. The article is well-structured, clearly written, and covers the full lifecycle of Traveler messaging (creating, targeting, publishing, viewing, and troubleshooting). It is a strong addition to the travel documentation set. Scores Summary
Key FindingsPositive aspects:
Items to address:
Recommendations
Files Reviewed
This review covers only the proposed changes in the PR diff. Scores and feedback are based solely on added content. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@stephanieelliott - Just a question about level 3 headers (aka "###" headers). The SDO suggested them but the AI Readiness is saying don't use them. Is it okay to ignore the AI readiness for level 3 headers if it makes sense in the doc and helps with formatting and the flow of information? If not, can we update the SDO to not use them? |
|
@strepanier03 ah yeah the SDO loses some consistently and needs to be readjusted as it is "upgraded" to newer GPT models. I will update it to be more accurate on the headings! No ### is not a hard and fast rule, but we should use it deliberately -- here is what the SDO says about it:
Applying that to this bot suggestion, I think we should avoid the H3 heading as it would separate the instructions from the actual query ( |
|
Gotcha, that framing makes sense. I'll tweak this and let you know when it's ready for your review again. |
made some formatting updates to reduce level 3 headings.
strepanier03
left a comment
There was a problem hiding this comment.
I made the updates to the level three headers and think it looks a lot better, thanks for the recommendation @stephanieelliott!
|
Thanks @strepanier03, looks great! |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Per this https://expensify.slack.com/archives/C05S5EV2JTX/p1770220769286929 in Slack, we have enabled Traveler Messaging for travel customers, so we need a help doc.
I confirmed multiple travel customers have the option available to them when viewing their travel setup.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari