Repository navigation
[NO QA] Tag individual Slack users in cherry-pick conflict notifications #83512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1f03c8c
Resolve individual Slack mentions in cherry-pick conflict notifications
MelvinBot c3f5ea4
fallback to tagging the whole team
Julesssss 0655dd0
only detect deployers if cp fails
Julesssss 524cdfe
attempt to tag both PR merger and deployer
Julesssss dc58e16
require just one assignee, improve comments
Julesssss 7b575b9
action lint fixes
Julesssss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that this will only work if the
slackhandle is defined after thegithubkey in the whitelist (which it is now), but it could easily break if someone changes the whitelist.I don't think there's any plan to though, and it would be an easy fix anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for this is to change
grep -F -A 10togrep -F -B 10 -A 10so it searches both before and after thegithubkey match. This makes the lookup order-independent. I've posted the diff in a PR comment — I can't push it directly due to theworkflowscope limitation on the token.