Repository navigation
refactor trackExpense to use isSelfTourViewed #83531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fc84a8e
refactor trackExpense to use isSelfTourViewed
dukenv0307 f420dc8
lint fix
dukenv0307 5be9a99
Merge branch 'main' into fix/66424-part-4
dukenv0307 27717e3
update test
dukenv0307 aed6a45
Merge branch 'main' into fix/66424-part-4
dukenv0307 7306a1c
add tests
dukenv0307 4402de3
remove export
dukenv0307 e7d2f63
Merge branch 'main' into fix/66424-part-4
dukenv0307 85fa1e6
merge main
dukenv0307 ca5ca49
Merge branch 'main' into fix/66424-part-4
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -870,6 +870,7 @@ describe('MoneyRequest', () => { | |
| selfDMReport, | ||
| betas: [CONST.BETAS.ALL], | ||
| recentWaypoints: [] as RecentWaypoint[], | ||
| isSelfTourViewed: false, | ||
| amountOwed: 0, | ||
| }; | ||
| const splitShares: SplitShares = { | ||
|
|
@@ -938,6 +939,9 @@ describe('MoneyRequest', () => { | |
| expect(IOU.trackExpense).toHaveBeenCalledWith({ | ||
| report: baseParams.report, | ||
| isDraftPolicy: false, | ||
| activePolicyID: undefined, | ||
| introSelected: undefined, | ||
|
Comment on lines
+942
to
+943
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this necessary to pass an
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, they're required in trackExpense |
||
| isSelfTourViewed: false, | ||
| participantParams: { | ||
| payeeEmail: baseParams.currentUserLogin, | ||
| payeeAccountID: baseParams.currentUserAccountID, | ||
|
|
@@ -965,6 +969,9 @@ describe('MoneyRequest', () => { | |
| validWaypoints: undefined, | ||
| customUnitRateID: baseParams.customUnitRateID, | ||
| attendees: fakeTransaction?.comment?.attendees, | ||
| gpsCoordinates: undefined, | ||
| odometerStart: undefined, | ||
| odometerEnd: undefined, | ||
| }, | ||
| isASAPSubmitBetaEnabled: baseParams.isASAPSubmitBetaEnabled, | ||
| currentUserAccountIDParam: baseParams.currentUserAccountID, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to export this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 How about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I export to test this function