Repository navigation
Add unreported status to unapproved cards - #83567
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
I created the parent issue 👍
|
@JS00001 @trjExpensify Assuming this needs my review? |
|
Yes please |
|
all yours @mananjadhav |
|
@mananjadhav could you please review this one? |
|
Bump @mananjadhav |
|
I've been fixing my company card feed. I should have the checklist in a while. |
|
I am still having issues with my company card not loading transactions. But I did manage to test this with the filters on the UI as well as on the API call. I am approving based on that. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb-unreported-filter.mov |
mananjadhav
left a comment
There was a problem hiding this comment.
Approving but please check this comment.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.31-0 🚀
|
|
Deploy Blocker #84235 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
Explanation of Change
Adds unreported as a valid status in unapproved card
Fixed Issues
$ #83562
Tests
Add a company card feed
Assign a card to a cardholder to import transactions
Unreport some expenses (you'll need to delete the draft report they are on)
Go to Unapproved card
The transactions should be showingf
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined