Skip to content

fix: Reports page filter inconsistencies and clean-up - #83672

Merged
puneetlath merged 4 commits into
Expensify:mainfrom
TaduJR:fix-Reports-page-filter-inconsistencies-and-clean-up
Mar 4, 2026
Merged

puneetlath merged 4 commits into
Expensify:mainfrom
TaduJR:fix-Reports-page-filter-inconsistencies-and-clean-up

Conversation

@TaduJR

@TaduJR TaduJR commented Feb 27, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Addresses several filter inconsistencies on the Reports page:

1. Alphabetize Feed filter options

getFeedOptions in SearchUIUtils.ts now sorts results using localeCompare from the locale context instead of relying on arbitrary Object.values() insertion order.

2. Show search input when there are 12+ options

  • Added isSearchable prop to the Feed filter chip, gated on CONST.STANDARD_LIST_ITEM_LIMIT (12).
  • Fixed the Card filter which was incorrectly using CONST.COMPANY_CARDS.CARD_LIST_THRESHOLD (8) instead of the standard 12, and aligned the comparison operator from > to >= to match all other filters.

3. Standardize search input labels to "Search"

Replaced inconsistent labels with translate('common.search')

Fixed Issues

$ #80903
PROPOSAL: #80903 (comment)

Tests

Test Case 1: Feed filter — Alphabetical sorting

  1. Navigate to the Search page and set the type to Expense
  2. If you have multiple card feeds, click on the Feed filter chip in the filter bar
  3. Verify the feed options are displayed in alphabetical order

Test Case 2: Feed filter — Search input with 12+ options

  1. On the Feed filter popover from Test Case 1
  2. If you have 12 or more card feeds, verify a Search input appears at the top
  3. If you have fewer than 12 card feeds, verify the Search input does not appear

Test Case 3: Card filter — Threshold of 12

  1. Click the Filters button at the end of the filter chip bar
  2. Click on Card
  3. If you have 12 or more total card options (feeds + individual cards), verify a Search input appears
  4. If you have fewer than 12 total card options, verify the Search input does not appear

Test Case 4: Group Currency filter — Search label

  1. Navigate to the Search page and set a Group by option (e.g., Group by Category)
  2. If the Group currency chip appears, click it
  3. Verify the search input label says "Search" (not "Group currency")

Test Case 5: From filter — Chip popover label

  1. On the Search page (type: Expense), click the From filter chip
  2. If there are 12 or more people, verify the search input label says "Search" (not "Search for someone")

Test Case 6: From filter — Advanced filters page label

  1. Click the Filters button → click From
  2. Verify the search input is always visible (even with few items)
  3. Verify the search input label says "Search" (not "Name, email, or phone number")

Test Case 7: In filter — Advanced filters page label

  1. Switch the search type to Chat
  2. Click the Filters button → click In
  3. Verify the search input is always visible (even with few items)
  4. Verify the search input label says "Search" (not "Name, email, or phone number")
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-Native.mp4
Android: mWeb Chrome
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Macbook-Chome.mp4

@TaduJR
TaduJR requested review from a team as code owners February 27, 2026 10:44
@melvin-bot
melvin-bot Bot requested a review from ikevin127 February 27, 2026 10:44
@melvin-bot

melvin-bot Bot commented Feb 27, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team February 27, 2026 10:44
@TaduJR
TaduJR marked this pull request as draft February 27, 2026 10:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13a6dd9432

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Feb 27, 2026 •

Copy link
Copy Markdown

@TaduJR
TaduJR marked this pull request as ready for review February 27, 2026 13:33
@ikevin127

Copy link
Copy Markdown
Contributor

@ShridharGoel This one is yours to review.

@ShridharGoel

ShridharGoel commented Feb 28, 2026 •

Copy link
Copy Markdown
Contributor

Search bar is still showing when number of items are below 12, for some fields

Screen.Recording.2026-02-28.at.7.39.53.PM.mov
Screenshot 2026-02-28 at 7 40 51 PM

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@JmillsExpensify
JmillsExpensify self-requested a review February 28, 2026 18:34
@JmillsExpensify

Copy link
Copy Markdown
Contributor

Adding myself since I created the related issue.

@github-actions

This comment has been minimized.

@TaduJR

TaduJR commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

Search bar is still showing when number of items are below 12, for some fields

@ShridharGoel

Fixed! Tag, Tax Rate, Category, and Exported To filter pages now use the >= 12 item threshold to conditionally show/hide the search input, consistent with the other filters. I thought they were working correctly.

Regarding Withdrawal ID that field uses a text input (not a selection list with a search bar). The input itself is the filter where you type the withdrawal ID directly, so there's no list to threshold against. That behavior is intentional.

@ShridharGoel

ShridharGoel commented Mar 1, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-01.at.6.55.01.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-03-01.at.6.56.14.PM.mov
iOS: HybridApp
Screen.Recording.2026-03-01.at.6.48.21.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-03-01.at.6.50.32.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-01.at.6.42.14.PM.mov

@ShridharGoel

Copy link
Copy Markdown
Contributor

Can you add the recordings?

@trjExpensify
trjExpensify removed their request for review March 2, 2026 10:34
@TaduJR

TaduJR commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Fixed! Tag, Tax Rate, Category, and Exported To filter pages now use the >= 12 item threshold to conditionally show/hide the search input, consistent with the other filters.

Regarding Withdrawal ID — that field uses a text input (not a selection list with a search bar). The input itself is the filter where you type the withdrawal ID directly, so there's no list to threshold against. That behavior is intentional.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Started another test build. Will jump in shortly.

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@TaduJR

TaduJR commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Can you add the recordings?

Sure @ShridharGoel, removed the screenshots and added videos.

@TaduJR
TaduJR requested a review from stephanieelliott as a code owner March 2, 2026 13:50
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@TaduJR
TaduJR force-pushed the fix-Reports-page-filter-inconsistencies-and-clean-up branch from 3257676 to e58844f Compare March 2, 2026 13:50
@TaduJR

TaduJR commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

🤦‍♂️

Make a mistake during rebase. Idk why was the reason .git/index.lock was problematic.

Sorry for force push @ShridharGoel

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Tested the adhoc. Nice work! Noting that we've kept the signed-in user at the top of the From filter, which is expected. Everything else in the list is alphabetized, as it should be.

@ShridharGoel

Copy link
Copy Markdown
Contributor

removed the screenshots and added videos

Screenshots were also fine, I was just asking to add them for the pending platforms also. Thanks

@melvin-bot
melvin-bot Bot requested a review from puneetlath March 2, 2026 15:20
@stephanieelliott
stephanieelliott removed their request for review March 3, 2026 00:34
TaduJR added 3 commits March 4, 2026 13:29
…-page-filter-inconsistencies-and-clean-up

# Conflicts:
#	src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
#	tests/unit/Search/SearchUIUtilsTest.ts
@puneetlath

Copy link
Copy Markdown
Contributor

@ShridharGoel reviewer checklist check is failing for some reason.

@melvin-bot
melvin-bot Bot requested a review from puneetlath March 4, 2026 16:25
@ShridharGoel

ShridharGoel commented Mar 4, 2026 •

Copy link
Copy Markdown
Contributor

One item was unchecked, updated now

@puneetlath
puneetlath merged commit f5663ad into Expensify:main Mar 4, 2026
35 of 37 checks passed
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants