Repository navigation
fix: Reports page filter inconsistencies and clean-up - #83672
puneetlath merged 4 commits into
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13a6dd9432
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ShridharGoel This one is yours to review. |
|
🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
Adding myself since I created the related issue. |
This comment has been minimized.
This comment has been minimized.
Fixed! Tag, Tax Rate, Category, and Exported To filter pages now use the >= 12 item threshold to conditionally show/hide the search input, consistent with the other filters. I thought they were working correctly. Regarding Withdrawal ID that field uses a text input (not a selection list with a search bar). The input itself is the filter where you type the withdrawal ID directly, so there's no list to threshold against. That behavior is intentional. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-01.at.6.55.01.PM.movAndroid: mWeb ChromeScreen.Recording.2026-03-01.at.6.56.14.PM.moviOS: HybridAppScreen.Recording.2026-03-01.at.6.48.21.PM.moviOS: mWeb SafariScreen.Recording.2026-03-01.at.6.50.32.PM.movMacOS: Chrome / SafariScreen.Recording.2026-03-01.at.6.42.14.PM.mov |
|
Can you add the recordings? |
|
Fixed! Tag, Tax Rate, Category, and Exported To filter pages now use the Regarding Withdrawal ID — that field uses a text input (not a selection list with a search bar). The input itself is the filter where you type the withdrawal ID directly, so there's no list to threshold against. That behavior is intentional. |
|
Started another test build. Will jump in shortly. |
|
🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
Sure @ShridharGoel, removed the screenshots and added videos. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
|
3257676 to
e58844f
Compare
🤦♂️ Make a mistake during rebase. Idk why was the reason .git/index.lock was problematic. Sorry for force push @ShridharGoel |
|
Tested the adhoc. Nice work! Noting that we've kept the signed-in user at the top of the |
Screenshots were also fine, I was just asking to add them for the pending platforms also. Thanks |
…-page-filter-inconsistencies-and-clean-up # Conflicts: # src/components/Search/SearchPageHeader/SearchFiltersBar.tsx # tests/unit/Search/SearchUIUtilsTest.ts
…-page-filter-inconsistencies-and-clean-up
|
@ShridharGoel reviewer checklist check is failing for some reason. |
|
One item was unchecked, updated now |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.31-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|

Explanation of Change
Addresses several filter inconsistencies on the Reports page:
1. Alphabetize Feed filter options
getFeedOptionsinSearchUIUtils.tsnow sorts results usinglocaleComparefrom the locale context instead of relying on arbitraryObject.values()insertion order.2. Show search input when there are 12+ options
isSearchableprop to the Feed filter chip, gated onCONST.STANDARD_LIST_ITEM_LIMIT(12).CONST.COMPANY_CARDS.CARD_LIST_THRESHOLD(8) instead of the standard 12, and aligned the comparison operator from>to>=to match all other filters.3. Standardize search input labels to "Search"
Replaced inconsistent labels with
translate('common.search')Fixed Issues
$ #80903
PROPOSAL: #80903 (comment)
Tests
Test Case 1: Feed filter — Alphabetical sorting
Test Case 2: Feed filter — Search input with 12+ options
Test Case 3: Card filter — Threshold of 12
Test Case 4: Group Currency filter — Search label
Test Case 5: From filter — Chip popover label
Test Case 6: From filter — Advanced filters page label
Test Case 7: In filter — Advanced filters page label
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Macbook-Chome.mp4