Repository navigation
[NO QA] [Snyk] Fix for 2 vulnerabilities - #83920
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TOOTALLNATEONCE-15250612 - https://snyk.io/vuln/SNYK-JS-SERIALIZEJAVASCRIPT-570062
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Regenerate lock file to match package.json changes (copy-webpack-plugin ^14.0.0, jest-environment-jsdom ^30.0.0)
|
Fixed the failing checks. The Snyk PR updated I regenerated |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa583fa124
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "clean-webpack-plugin": "^4.0.0", | ||
| "concurrently": "^8.2.2", | ||
| "copy-webpack-plugin": "^10.1.0", | ||
| "copy-webpack-plugin": "^14.0.0", |
There was a problem hiding this comment.
Update lockfile with dependency bumps
The commit changes package.json to copy-webpack-plugin@^14.0.0 (and jest-environment-jsdom@^30.0.0) but leaves package-lock.json pinned to the old ranges/versions (copy-webpack-plugin still ^10.1.0 at line 232 and jest-environment-jsdom still ^29.7.0 at line 258), so the security remediation is not actually captured in the lockfile. In this repo’s CI, dependency installation is driven by .github/actions/composite/setupNode/action.yml (npm ci at lines 50-56) with cache keys based on package-lock.json, so this change can either be skipped on cache hits or fail unpredictably on cache misses instead of reliably applying the intended upgrades.
Useful? React with 👍 / 👎.
…7.0) jest-environment-jsdom@30 uses jsdom@26 which defines window as non-configurable, breaking React Native's jest/setup.js that calls Object.defineProperties on window. Keep copy-webpack-plugin@14 upgrade.
|
Fixed the failing test checks. The Snyk upgrade of
Fix: Reverted |
|
I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai. Run details: https://github.com/Expensify/Expensify/actions/runs/22589851391 |
The Snyk update bumped top-level http-proxy-agent to 7.x and tough-cookie to 5.x, but jest-environment-jsdom's nested jsdom still requires http-proxy-agent@^5.0.0 and tough-cookie@^4.1.2. Added nested entries under jest-environment-jsdom/node_modules/ for the required older versions (mirroring what jest-expo already has).
|
Fixed the failing checks. All CI jobs were failing because Root cause: The Snyk update bumped Fix: Added nested dependency entries under |
|
The failing checks have been resolved. All CI checks are now passing. Root cause: The initial Fix applied: Commit |
|
This built fine for me. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
All checks on this PR are currently passing — no failures found. This includes |
|
🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.31-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari