Repository navigation
[CP both] Fix subscription payment history not showing bills after merchant exact match change - #84297
Conversation
The merchant search in Auth was updated to use exact matching (Auth PR #20053). The billing receipts use merchant 'Expensify, Inc.' but the payment history search was filtering for 'Expensify', which no longer matches with exact matching. Made-with: Cursor
|
@MelvinBot pls test this |
|
Trying again. @MelvinBot please test this. |
|
I tested this PR on the web build. Here's what I found: Result: Pass ✅ The change from Verifications:
Note: The "View payment history" button on the Subscription page is only visible when Screenshots (web): No JS console errors related to this change. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…nt-exact-match [CP both] Fix subscription payment history not showing bills after merchant exact match change (cherry picked from commit b090886) (cherry-picked to staging by blimpich)
|
@Julesssss @neil-marcellini to QA this PR, we will need to trigger a new charge which doesnt seem possible from QA side. |
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-9 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-10 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|


Explanation of Change
The Auth PR #20053 changed the merchant search filter from partial matching (GLOB
*value*) to exact matching (= value) when using the defaulteqoperator. The "View payment history" button in subscription settings searches for expenses withmerchant:Expensify, but billing receipts are created with merchantExpensify, Inc.(viaBillingReceiptUploader::EXPENSIFY_INC_MERCHANT).This PR updates
CONST.EXPENSIFY_MERCHANTfrom'Expensify'to'Expensify, Inc.'to match the exact merchant name on billing receipts.Fixed Issues
$ #84076
Tests
pbpaste | git apply -diff
2026-03-05_10-52-44.mp4
Offline tests
N/A - This change only affects the search query string, which is built client-side. Offline behavior is unchanged.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Changes are platform independent. See the test video above.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Made with Cursor