Repository navigation
Stabilize hooks - #84340
Stabilize hooks#84340
Conversation
| const [newReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${newReportID}`); | ||
| const [newParentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${newReport?.parentReportID}`); |
There was a problem hiding this comment.
These values are always undefined because we just generated a new reportID above
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
PR doesn’t have any new product considerations as a performance PR. Unassigning and unsubscribing myself. |
|
@mananjadhav please prioritize this review when you're online! |
|
I’ll be able to review in a few hours. |
|
Thanks! |
mananjadhav
left a comment
There was a problem hiding this comment.
Small comments. Testing.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-10.at.8.33.16.PM.movAndroid: mWeb ChromeScreen.Recording.2026-03-10.at.8.35.30.PM.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-03-10.at.8.30.15.PM.movMacOS: Chrome / SafariScreen.Recording.2026-03-10.at.8.21.18.PM.movScreen.Recording.2026-03-10.at.8.24.10.PM.mov |
|
@mananjadhav how's review going? |
mananjadhav
left a comment
There was a problem hiding this comment.
Some issues with my iOS build and remote artefact also not working. Approving it based on other platforms.
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.35-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.35-1 🚀
|
Explanation of Change
Stabilizes two hooks to avoid re-renders of
SearchPage.Fixed Issues
$ #84343
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari