Skip to content

Hide automatic TAKE_CONTROL actions from OldDot auto-pay workflow - #84525

Merged
rlinoz merged 7 commits into
mainfrom
claude-hideAutoPayTakeControlAction
Mar 10, 2026
Merged

rlinoz merged 7 commits into
mainfrom
claude-hideAutoPayTakeControlAction

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Mar 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When a report is created and approved in OldDot with auto-pay enabled, NewDot displays an extra "Changed approver [owner name]" system message that shouldn't be there. This happens because OldDot's auto-pay workflow creates a TAKECONTROL report action as a side effect of reassigning the report manager during auto-reimbursement, and NewDot unconditionally renders it as a visible "changed the approver to [owner name]" message.

This PR adds a check in shouldReportActionBeVisible to hide these auto-pay TAKE_CONTROL actions: if the action's originalMessage has automaticAction: true and its mentionedAccountIDs array is empty (no new approver was explicitly tagged), the action is hidden. This combination identifies auto-pay side-effect actions — manual "Take Control" messages (per #69280) have mentionedAccountIDs populated with the new approver and don't have automaticAction: true, so they remain visible.

The automaticAction field is also added to the OriginalMessageTakeControl type definition.

Fixed Issues

$ #84288
PROPOSAL: #84288 (comment)

Tests

  1. Set up a Control policy with Instant submit, Submit & Approve enabled
  2. In OldDot, set "Manually approve all expenses over" to $0.01
  3. In NewDot, enable Auto-pay in the workspace Workflows tab
  4. Add a withdrawal-ready bank account for the workspace
  5. In OldDot, as the workspace owner, create a report and add a $1 expense, then approve it
  6. In NewDot, open the report
  7. Verify the "changed approver" system message is NOT shown — only the "paid with bank account via workspace rules" message should appear
  8. In NewDot, manually change the approver on a different submitted report (if applicable)
  9. Verify the manual "changed the approver to [name]" message IS still shown
  • Verify that no errors appear in the JS console

Offline tests

N/A — This change only affects visibility filtering of server-side report actions. No offline behavior changes.

QA Steps

  1. Set up a Control policy with auto-pay enabled (same setup as test steps above)
  2. In OldDot, create and approve a report that triggers auto-pay
  3. In NewDot, open the report
  4. Verify only the "paid with bank account via workspace rules" message appears — no "changed approver" message
  5. Verify manual "Take Control" actions from OldDot still display correctly
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - Logic-only change, no UI modifications

Android: mWeb Chrome

N/A - Logic-only change, no UI modifications

iOS: Native

N/A - Logic-only change, no UI modifications

iOS: mWeb Safari

N/A - Logic-only change, no UI modifications

MacOS: Chrome / Safari

N/A - Logic-only change, no UI modifications

MelvinBot and others added 2 commits March 9, 2026 04:23
When OldDot auto-pays a report, it creates a TAKECONTROL action as a
side effect of reassigning the report manager. This action has
automaticAction: true in its originalMessage. NewDot was unconditionally
rendering it as "changed the approver to [owner name]".

Add automaticAction to OriginalMessageTakeControl type and check it in
shouldReportActionBeVisible to hide auto-pay TAKE_CONTROL actions while
preserving manual take-control messages (which lack automaticAction).

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
…flag

For OldDot TAKE_CONTROL actions that may not have automaticAction set,
add a fallback heuristic: hide when the actor is the report owner AND
the report is in AUTOREIMBURSED state. This combination indicates the
TAKE_CONTROL was a side effect of auto-pay, not a manual approver change.

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
@linhvovan29546

Copy link
Copy Markdown
Contributor

@MelvinBot Remove the second condition https://github.com/Expensify/App/pull/84525/changes#diff-b8041d6cb129cc7b8a6223f8ffa570e79c326d8ea4affbad35c33cf6c8ea660dR1162-R1167. For the first condition plase add the check for mentionedAccountIDs

Per review feedback:
- Removed the fallback condition that checked report owner and AUTOREIMBURSED state
- Added mentionedAccountIDs check to the primary condition alongside automaticAction

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated per your feedback:

  1. Removed the fallback condition that checked report.ownerAccountID and AUTOREIMBURSED state
  2. Added mentionedAccountIDs check to the primary condition — now the action is hidden only when automaticAction is true AND the actor's accountID is in mentionedAccountIDs

The updated condition in src/libs/ReportActionsUtils.ts now reads:

if (
    takeControlOriginalMessage &&
    'automaticAction' in takeControlOriginalMessage &&
    takeControlOriginalMessage.automaticAction &&
    reportAction.actorAccountID &&
    takeControlOriginalMessage.mentionedAccountIDs?.includes(reportAction.actorAccountID)
) {
    return false;
}

MelvinBot and others added 2 commits March 9, 2026 04:54
…leakage

The APPROVED action test leaves automaticAction: true in originalMessage
via Onyx deep merge. When the TAKE_CONTROL test runs after, this leaked
property triggers the new automaticAction visibility check, hiding the
action and causing the test to expect non-empty text but receive "".

Switch to Onyx.set to replace (not merge) the report actions collection,
ensuring each test starts with clean data.

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
…com/Expensify/App into claude-hideAutoPayTakeControlAction

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
Comment thread src/libs/ReportActionsUtils.ts Outdated
Comment on lines +1157 to +1165
if (
takeControlOriginalMessage &&
'automaticAction' in takeControlOriginalMessage &&
takeControlOriginalMessage.automaticAction &&
reportAction.actorAccountID &&
takeControlOriginalMessage.mentionedAccountIDs?.includes(reportAction.actorAccountID)
) {
return false;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (
takeControlOriginalMessage &&
'automaticAction' in takeControlOriginalMessage &&
takeControlOriginalMessage.automaticAction &&
reportAction.actorAccountID &&
takeControlOriginalMessage.mentionedAccountIDs?.includes(reportAction.actorAccountID)
) {
return false;
}
const originalMessage = getOriginalMessage(reportAction as ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.TAKE_CONTROL>);
if (originalMessage?.automaticAction && !originalMessage?.mentionedAccountIDs?.length) {
return false;
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied your suggestion and added 4 unit tests:

  1. automaticAction: true + empty mentionedAccountIDs → hidden
  2. automaticAction: true + non-empty mentionedAccountIDs → visible
  3. automaticAction: false → visible
  4. automaticAction not set → visible

All tests pass.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing test (job 5) check.

Root cause: The TAKE_CONTROL action test in OptionsListUtilsTest.tsx was failing because of Onyx state leakage between tests. The preceding APPROVED action test sets automaticAction: true in its originalMessage. Since tests in the getLastMessageTextForReport block share Onyx state (no Onyx.clear() between them) and all use Onyx.merge with the same report/action IDs, the automaticAction: true property leaked into the TAKE_CONTROL action's originalMessage via deep merge. This triggered the new visibility check and hid the action, causing the test to receive "" instead of the expected message.

Fix: Changed Onyx.merge to Onyx.set for the TAKE_CONTROL and REROUTE tests so they fully replace the report actions collection instead of deep-merging, ensuring clean test isolation.

Note: The concurrent commit 154e7cf also addressed this by making the visibility check more strict (requiring mentionedAccountIDs match in addition to automaticAction), which independently prevents this particular leak from triggering. The Onyx.set fix still improves test robustness.

@linhvovan29546

Copy link
Copy Markdown
Contributor

@MelvinBot Please apply this suggestion: #84525 (comment). And add unit tests

@codecov

codecov Bot commented Mar 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/ReportActionsUtils.ts 53.67% <100.00%> (+0.09%) ⬆️
... and 9 files with indirect coverage changes

MelvinBot and others added 2 commits March 9, 2026 05:06
- Simplified TAKE_CONTROL visibility condition per review suggestion:
  hide when automaticAction is true and mentionedAccountIDs is empty
- Added 4 unit tests covering TAKE_CONTROL visibility scenarios

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
…echeck

The OriginalMessageTakeControl type is defined in both OriginalMessage.ts
and OldDotAction.ts with incompatible structures. Their intersection in
OriginalMessageMap requires properties from both types simultaneously.
Using type assertions (matching the established test pattern) avoids
this type conflict while keeping the test logic intact.

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing typecheck check. The issue was that OriginalMessageTakeControl is defined in both OriginalMessage.ts and OldDotAction.ts with incompatible structures — when intersected in OriginalMessageMap, TypeScript required properties from both types simultaneously (including actionName and originalMessage from the OldDot type). The test objects used direct type annotations which enforced this impossible intersection.

Changed the test objects to use as ReportAction<...> type assertions (matching the pattern used widely in this test file) and added explicit as number[] casts on empty arrays to prevent never[] inference.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is checklist (PR Author/Reviewer Checklist), which requires manual action — it can't be fixed with a code change. All code-related checks (ESLint, typecheck, Prettier, tests, verifySignedCommits, etc.) are passing.

To resolve the checklist failure, the PR author or reviewer needs to complete the checklist items in the PR description.

@linhvovan29546

Copy link
Copy Markdown
Contributor

@MelvinBot The Explanation of Change is outdated. Could you please update it with the new version?

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated the Explanation of Change section to reflect the current implementation — it now describes the single condition that checks both automaticAction and mentionedAccountIDs, with no mention of the removed fallback condition.

@linhvovan29546

Copy link
Copy Markdown
Contributor

@MelvinBot Mark this PR Ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review March 9, 2026 08:04
@MelvinBot
MelvinBot requested a review from a team as a code owner March 9, 2026 08:04
@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and trjExpensify and removed request for a team and linhvovan29546 March 9, 2026 08:04
@melvin-bot

melvin-bot Bot commented Mar 9, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Marked this PR as Ready for review as requested.

@melvin-bot
melvin-bot Bot removed the request for review from a team March 9, 2026 08:04

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you add videos and what not to confirm this is working correctly 👍

@linhvovan29546

linhvovan29546 commented Mar 9, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-09.at.22.34.39.mov
Android: mWeb Chrome
Screen.Recording.2026-03-09.at.22.32.26.mov
iOS: HybridApp
Screen.Recording.2026-03-09.at.22.26.57.mov
iOS: mWeb Safari
Screen.Recording.2026-03-09.at.22.24.07.mov
MacOS: Chrome / Safari Before
Screen.Recording.2026-03-09.at.22.30.48.mov

After

Screen.Recording.2026-03-09.at.22.21.26.mov

@linhvovan29546

Copy link
Copy Markdown
Contributor

@melvin-bot

melvin-bot Bot commented Mar 9, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #84288 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot
melvin-bot Bot requested a review from rlinoz March 9, 2026 15:48
@linhvovan29546

Copy link
Copy Markdown
Contributor

Make sure you add videos and what not to confirm this is working correctly 👍

@trjExpensify You can take a look at the MacOS: Chrome / Safari section #84525 (comment)

@rlinoz

rlinoz commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

@linhvovan29546 the videos are not from an auto pay workflow, are they?

@linhvovan29546

Copy link
Copy Markdown
Contributor

@linhvovan29546 the videos are not from an auto pay workflow, are they?

They come from the auto pay workflow.

@rlinoz

rlinoz commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Why they show up as approved/outstanding instead of paid though? 😕

@linhvovan29546

Copy link
Copy Markdown
Contributor

I used a test bank, so the auto pay did not succeed.

@linhvovan29546

Copy link
Copy Markdown
Contributor

But i still have the TAKE_CONTROL action correct, same as the OP.

@rlinoz

rlinoz commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Ah that makes sense, thanks! I was trying to match the video from applause to this one 😄

Comment thread tests/unit/OptionsListUtilsTest.tsx Resolved
Comment thread tests/unit/OptionsListUtilsTest.tsx Resolved
@rlinoz

rlinoz commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

@trjExpensify are you reviewing this one too?

@trjExpensify

Copy link
Copy Markdown
Contributor

I think it makes sense to not show this, it's weird. Though is that how Classic handles this? Simply hiding the reportAction?

image

@rlinoz

rlinoz commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

That is a good question. OldDot hides it in PHP by checking if TAKE_CONTROL is automatic or not, but NewDot actions come from Auth, and we don't have the same logic there, but also NewDot doesn't check reportAction.shouldShow in shouldReportActionBeVisible and I have no idea why.

The fix in this branch seems to be the way we have been hiding actions in NewDot though.

@trjExpensify

Copy link
Copy Markdown
Contributor

OldDot hides it in PHP by checking if TAKE_CONTROL is automatic or not

Gotcha. So the reportAction has traditionally still been recorded in the database in Classic, just hidden in PHP. That was my concern really, that we traditionally skipped creating this reportAction in the auto-pay case but are now storing it (and opting to hide it) with the NewDot case. 👍

@rlinoz

rlinoz commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Yep it is still generated in OldDot

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rlinoz
rlinoz merged commit 8ec7f7d into main Mar 10, 2026
34 of 37 checks passed
@rlinoz
rlinoz deleted the claude-hideAutoPayTakeControlAction branch March 10, 2026 13:54
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 10, 2026
46 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.35-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.35-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants