Repository navigation
[NO QA] Update PAYMENT_VIA_EXPENSIFY.md - #84659
Conversation
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf2e7dfeb7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| After approval it can take between 1 business day and a week, depending on the country and service you use. | ||
|
|
||
| ## For issues with deposits | ||
| If you're having an issue with the deposit, ie. a report gets _stuck_ in a state like Approved, start a chat with Concierge. Ask them to create a Github issue using [this template](https://github.com/Expensify/Expensify/issues/new?template=MISSING_REIMBURSEMENT_TEMPLATE.md.). Provide as many details below as possible |
There was a problem hiding this comment.
Use valid reimbursement issue template URL
The link to the GitHub issue template includes an extra trailing . in the template query value (MISSING_REIMBURSEMENT_TEMPLATE.md.), so it no longer matches the template filename exactly. When contributors follow this instruction for stuck deposits, they can be sent to a generic/new issue flow instead of the intended reimbursement template, which drops the required intake fields listed below this section.
Useful? React with 👍 / 👎.
Co-authored-by: Monil Bhavsar <monil@expensify.com>
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.36-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
Coming from https://expensify.slack.com/archives/C03TUCV48/p1772233736145099
Explanation of Change
Fixed Issues
$
PROPOSAL: N/A
Tests
No Tests needed, I'll check it.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari