Repository navigation
fix: filter deleted reports from navigation and disable in search list - #85292
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8ab13c321
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🤖 MelvinBot Code ReviewI reviewed the PR diff, the modified files, and the linked issue. Here are my findings: 1.
|
|
@TaduJR I am stuck following test cases. Can you share full reproduction videos for both cases? I am seeing "1 of 3" which is expected.
|
…-Total-report-number-x-of-y-does-not-update-when-new-report-is-created-offline
Sure here @aimane-chnaif Mac-Chrome.1.mp4 |
|
Please merge main |
…-Total-report-number-x-of-y-does-not-update-when-new-report-is-created-offline
…-Total-report-number-x-of-y-does-not-update-when-new-report-is-created-offline
|
Please address Melvin's review here |
…-Total-report-number-x-of-y-does-not-update-when-new-report-is-created-offline
Most of them are not valid. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
Please merge main and update. |
…-Total-report-number-x-of-y-does-not-update-when-new-report-is-created-offline # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Done. |
|
🚧 @tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.3.49-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.3.49-2 🚀
|

Explanation of Change
Filter deleted reports from navigation and disable them in the search list to prevent infinite loading when navigating to a deleted report.
Changes:
isReportPendingDeleteutility toReportUtils.tsthat checks bothpendingActionandpendingFields.previewfor DELETE statusallReportsinuseSearchSections.tsusing a narrow Onyx selector (only subscribes topendingAction/pendingFields)FullPageNotFoundViewinstead of infinite skeleton when navigating to a deleted report inMoneyRequestReportView.tsxExpenseReportListItem.tsxisReportPendingDeleteFixed Issues
$ #75935
PROPOSAL: #75935 (comment)
Tests
Test Case 1:
Expected Result
Actual Result (Before Fix)
Test Case 2:
Expected Result
Actual Result (Before Fix)
Navigation count still shows the old count including the deleted report (e.g., "1 of 4" instead of "1 of 3")
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Mac-Chrome.mp4