Repository navigation
[Payment due @abzokhattab] Add OpenSearchCardFiltersPage command to the Feed selector #86319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c40120b
add loading props
JS00001 41bc179
add loading indicator
JS00001 d15d6b6
add new component
JS00001 ce1490a
add back imports
JS00001 e536b43
use props instead
JS00001 efbb5dd
add a loading state to the component
JS00001 f69f29d
add isExpanded
JS00001 90d3404
update loading state UI
JS00001 38d739f
add props to everywhere else
JS00001 81ed014
add loading state to new action bar as well
JS00001 1700e69
Merge branch 'main' of github.com:Expensify/App into jsenyitko-feed-d…
JS00001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/components/Search/SearchPageHeader/FeedFilterPopup.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import React, {useEffect} from 'react'; | ||
| import type {MultiSelectItem} from '@components/Search/FilterDropdowns/MultiSelectPopup'; | ||
| import useNetwork from '@hooks/useNetwork'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
| import {openSearchCardFiltersPage} from '@libs/actions/Search'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import MultiSelectFilterPopup from './MultiSelectFilterPopup'; | ||
|
|
||
| type FeedFilterPopupProps = { | ||
| isExpanded: boolean; | ||
| items: Array<MultiSelectItem<string>>; | ||
| value: Array<MultiSelectItem<string>>; | ||
| closeOverlay: () => void; | ||
| onChangeCallback: (items: Array<MultiSelectItem<string>>) => void; | ||
| }; | ||
|
|
||
| function FeedFilterPopup({closeOverlay, items, value, isExpanded, onChangeCallback}: FeedFilterPopupProps) { | ||
| const {isOffline} = useNetwork(); | ||
| const [areCardsLoaded] = useOnyx(ONYXKEYS.IS_SEARCH_FILTERS_CARD_DATA_LOADED); | ||
|
|
||
| useEffect(() => { | ||
| if (isOffline || !isExpanded) { | ||
| return; | ||
| } | ||
| openSearchCardFiltersPage(); | ||
| }, [isOffline, isExpanded]); | ||
|
|
||
| const shouldShowLoadingState = !areCardsLoaded && !isOffline; | ||
|
|
||
| return ( | ||
| <MultiSelectFilterPopup | ||
| items={items} | ||
| value={value} | ||
| isExpanded={isExpanded} | ||
| loading={shouldShowLoadingState} | ||
| translationKey="search.filters.feed" | ||
| closeOverlay={closeOverlay} | ||
| onChangeCallback={onChangeCallback} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| export default FeedFilterPopup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB, but this is a bit more readable