Skip to content

[No QA] Add report-level reject documentation to help site - #87054

Merged
garrettmknight merged 7 commits into
mainfrom
claude-addReportLevelRejectDocs
Apr 16, 2026
Merged

garrettmknight merged 7 commits into
mainfrom
claude-addReportLevelRejectDocs

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Apr 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds help site documentation for the new report-level rejection feature (Expensify/Expensify#601475), which brings parity with Expensify Classic.

Changes:

  • Approve-Expenses.md: Added a new "Reject a report" section with step-by-step instructions, covering rejection reason, target selection (submitter vs. previous approver), and post-rejection behavior (Draft vs. Outstanding state, scheduled submit exclusion)
  • Expense-and-Report-Actions.md: Added a "Reject" row to the Secondary ("More" menu) Actions table

Test plan

  • Verify all three updated articles render correctly on the help site
  • Confirm the new "Reject a report" section in Approve-Expenses.md is clear and complete
  • Confirm the Reject row in Expense-and-Report-Actions.md is consistent with the table format
  • Confirm the report-level vs. expense-level distinction in Understanding-Report-Statuses-and-Actions.md is clear

cc @stephanieelliott

Update three help site articles to document the new report-level
rejection feature that brings parity with Expensify Classic.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@github-actions github-actions Bot changed the title Add report-level reject documentation to help site [No QA] Add report-level reject documentation to help site Apr 3, 2026
@OSBotify

OSBotify commented Apr 3, 2026 •

Copy link
Copy Markdown
Contributor

@stephanieelliott
stephanieelliott marked this pull request as ready for review April 15, 2026 01:04
@stephanieelliott
stephanieelliott self-requested a review as a code owner April 15, 2026 01:04
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck: typo rport → report in Approve-Expenses.md (line 41).

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds report-level reject documentation to the Approve-Expenses article and a corresponding row to the Expense-and-Report-Actions table. The rewrite significantly improves the article's structure by converting the old multi-# heading layout into a proper single-# title with ## task-based sections. The new reject-a-report workflow is well-documented with clear steps and post-rejection behavior. However, there is one critical and recurring naming convention violation that must be addressed before merge.

Scores Summary

  • Readability: 9/10 - Steps are clear, sequential, and action-oriented. Sections flow logically from overview to specific actions. The "What happens after a report is rejected" section is a strong addition that preempts user questions.
  • AI Readiness: 9/10 - YAML metadata now includes internalScope (was missing before). All ## headings are task-based with "How to" or "What" phrasing. Keywords are comprehensive and include the new reject terminology. Heading hierarchy is correct (one # title plus # FAQ).
  • Style Compliance: 5/10 - There is a critical recurring violation: the diff introduces "More" as a menu reference in six locations (e.g., "Click More at the top of the expense"). Per HELPSITE_NAMING_CONVENTIONS.md, the three dots menu must always be written as: Select the three dots **(three vertical dots)** -- it must never be called "More" or "More menu." This violation appears in almost every procedural section and must be corrected throughout. Additionally, one heading ends with a trailing space ("## What actions can be taken on expenses and reports submitted on a Workspace ").

Key Findings

  • Critical -- "More" menu references: Six instances in the diff use **More** to reference the three dots menu. The naming conventions file explicitly lists "Click More" and "Open the More menu" as incorrect. Every occurrence must be replaced with the prescribed phrasing: Select the three dots **(three vertical dots)**.
  • Positive -- Structural overhaul: The old article used multiple # headings (Expenses Sent to an Individual, Expenses Submitted on a Workspace, Approve an Expense, Change Approver, Hold an Expense, etc.). The new version correctly uses a single # title with ## sections, fully compliant with the authoring guidelines.
  • Positive -- internalScope added: The YAML frontmatter now includes the required internalScope field with clear audience and coverage boundaries.
  • Positive -- Cross-links use relative paths: Links to other articles use relative paths (e.g., /articles/new-expensify/...) rather than absolute URLs, compliant with cross-linking standards.
  • Positive -- New FAQ entries: The FAQ section is expanded with relevant questions (difference between rejecting a report vs. expense, why unapprove is unavailable, what happens after approval), which improves AI retrieval.
  • Minor -- Trailing spaces: Several added lines have trailing whitespace, which is cosmetic but worth cleaning up.
  • Note on Expense-and-Report-Actions.md: The new Reject row is well-structured and consistent with the existing table format.

Recommendations

  1. Must fix: Replace all six instances of **More** with the correct three dots menu phrasing per HELPSITE_NAMING_CONVENTIONS.md. This is the single blocking issue.
  2. Should fix: Remove the trailing space from the heading "## What actions can be taken on expenses and reports submitted on a Workspace " (line has a trailing space after "Workspace").
  3. Consider: The removed note about accounting export reconciliation ("If the expense was already exported to accounting software, unapproving it may cause reconciliation issues") contained useful information. Consider whether this warning should be retained or documented elsewhere.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md -- Major rewrite. Structure is greatly improved. Blocked by "More" menu naming violations.
  • docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md -- Single row addition. Consistent with existing table format. No issues found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f33251ff3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott

Copy link
Copy Markdown
Contributor

Applied all the relevant bot comments! All yours @garrettmknight

@garrettmknight garrettmknight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettmknight
garrettmknight merged commit 206ffc6 into main Apr 16, 2026
15 checks passed
@garrettmknight
garrettmknight deleted the claude-addReportLevelRejectDocs branch April 16, 2026 11:50
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/garrettmknight in version: 9.3.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants