Repository navigation
[No QA] [Zombie spans] Fix ManualAppStartup when signing out from OD - #87069
Conversation
…ut-from-OD # Conflicts: # src/HybridAppHandler.tsx
ManualAppStartup when signing out from ODManualAppStartup when signing out from OD
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Can you please generate adhoc build? I can verify logs in Sentry |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb Safari |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The change is purely internal — it ends two telemetry spans ( |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀
|


Explanation of Change
When signing out from OldDot in HybridApp, there is no bootsplash to hide, so the
ManualAppStartupandBootSplashtelemetry spans were never finished — resulting in zombie spans. This PR ends both spans (SPAN_APP_STARTUPandSPAN_BOOTSPLASH.ROOT) in theloggedOutFromOldDotbranch ofHybridAppHandler, alongside the already-endedSPAN_OD_ND_TRANSITION_LOGGED_OUT.Fixed Issues
$ #85882
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13907
Tests
ManualAppStartuporBootSplashspans remain active in telemetry logsSPAN_OD_ND_TRANSITION_LOGGED_OUTstill ends as beforeOffline tests
N/A - telemetry spans are local only.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - No UI changes, telemetry-only fix.
Android: mWeb Chrome
N/A
iOS: Native
N/A - No UI changes, telemetry-only fix.
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A