Repository navigation
[CP Staging] fix analytics event - #87210
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This is 2nd time wrong assignment from the same issue. Example: |
|
Thanks, I noted. |
|
@nkdengineer, |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-07.at.15.45.55.movAndroid: mWeb ChromeScreen.Recording.2026-04-07.at.15.48.01.moviOS: HybridAppScreen.Recording.2026-04-07.at.15.44.38.moviOS: mWeb SafariScreen.Recording.2026-04-07.at.15.45.29.movMacOS: Chrome / SafariScreen.Recording.2026-04-07.at.15.43.50.mov |
|
@eVoloshchak The issue only happens on native and I uploaded the video for IOS. |
|
Since it's blocker, I think this video is enough. |
It was caught on native, but we both have to go through all of the test steps on all of the platforms to verify it isn't present on other platforms |
@nkdengineer, are there any additional steps I'm missing? The tooltip doesn't show up when following the steps Screen.Recording.2026-04-07.at.15.35.35.movScreen.Recording.2026-04-07.at.15.32.38.mov |
|
@eVoloshchak The account shouldn't have any workspace. |
flaviadefaria
left a comment
There was a problem hiding this comment.
Performance improvement, no new product considerations. Unsubscribing myself.
|
@eVoloshchak Updated screenshots for other platforms |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] fix analytics event (cherry picked from commit 7b8fde7) (cherry-picked to staging by roryabraham)
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.53-7 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The only change is renaming three internal analytics event string values in |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.54-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The only changes are internal analytics event name renames in |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.54-7 🚀
|
Explanation of Change
fix analytics event
Fixed Issues
$ #87208
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-02.at.14.40.24.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-04-07.at.11.06.54.mov
iOS: mWeb Safari
Screen.Recording.2026-04-07.at.20.56.21.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-07.at.20.53.50.mov