Skip to content

Fix Radio buttons are hidden behind navigation bar, unable to scroll down filters - #87376

Merged
mjasikowski merged 5 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/landscape-mode/fix-search-page-popups-broken
Apr 14, 2026
Merged

mjasikowski merged 5 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/landscape-mode/fix-search-page-popups-broken

Conversation

@GCyganek

@GCyganek GCyganek commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixing layouts of the filter popups on the Reports screen to make sure nothing is cut off and that content is scrollable

Also making sure that with Navigation Bar enabled on Android there is no overlap of Navigation Bar with modals conents

Fixed Issues

$ #87307, #87369, #87374, #87375
PROPOSAL: N/A

Tests

Android with Navigation Bar enabled:

  1. Launch Expensify app in landscape mode.
  2. Go to Reports > Expenses.
  3. Tap Type quick filter and scroll down.
  4. Close the modal.
  5. Tap Status quick filter and scroll down.
  6. Verify that radio buttons are not hidden and filter modal can be scrolled down to reveal Apply and Reset button.

Android with Navigation Bar enabled:

  1. Launch app
  2. Open workspace chat
  3. Create a Manual distance expense with receipt capturing an image
  4. Open the expense
  5. Open the receipt
  6. Turn to landscape mode
  7. Tap Dots - delete
  8. Verify Delete and cancel button are not be partially hidden behind navigation bar in delete modal.

Android with Navigation Bar enabled:

  1. Launch app
  2. Open an expense
  3. Tap date
  4. Turn to landscape
  5. Note side arrow to navigate to next month
  6. Verify side arrow to navigate to next month must not be hidden behind navigation bar.

Android with Navigation Bar enabled:

  1. Launch app
  2. Open workspace chat with few expenses
  3. Long press and open context menu
  4. Turn to landscape
  5. Verify no emoji reaction button is partially hidden under nav bar

Test other filters (single & multi select, date filters, From filters) to verify that their layout is not broken (nothing cut off, content scrollable where needed)

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-04-08.at.14.41.13.mov
Screen.Recording.2026-04-10.at.12.28.40.mov
Screen.Recording.2026-04-10.at.12.38.12.mov
Screen.Recording.2026-04-10.at.12.43.50.mov
iOS: Native
Screen.Recording.2026-04-08.at.14.44.01.mov

@GCyganek
GCyganek requested review from a team as code owners April 8, 2026 12:44
@melvin-bot
melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team April 8, 2026 12:44
@melvin-bot

melvin-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Apr 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ponents/Search/FilterDropdowns/CardSelectPopup.tsx 0.00% <0.00%> (ø)
...s/Search/FilterDropdowns/DateSelectPopup/index.tsx 0.00% <0.00%> (ø)
...omponents/Search/FilterDropdowns/InSelectPopup.tsx 0.00% <0.00%> (ø)
...onents/Search/FilterDropdowns/MultiSelectPopup.tsx 0.00% <0.00%> (ø)
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx 0.00% <0.00%> (ø)
...stReportView/MoneyRequestReportTransactionList.tsx 0.00% <0.00%> (ø)
...components/Search/FilterDropdowns/GroupByPopup.tsx 0.00% <0.00%> (ø)
...nents/Search/FilterDropdowns/SingleSelectPopup.tsx 0.00% <0.00%> (ø)
src/styles/index.ts 47.80% <0.00%> (-0.96%) ⬇️
... and 84 files with indirect coverage changes

@shawnborton

Copy link
Copy Markdown
Contributor

Looks good to me. I'm kind of surprised the headers of these menus are fixed but that's an already-existing problem 🤣

@truph01

truph01 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

@GCyganek

Radio buttons are hidden behind navigation bar.

This issue is still reproducible in this PR:

Screen.Recording.2026-04-09.at.09.55.51.mov

Could you help check?

@GCyganek

GCyganek commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Radio buttons are hidden behind navigation bar.

This issue is still reproducible in this PR:

Ah, right, sorry for that, I focused on the scrolling issues and skipped that, thank you! I'm on it

@GCyganek

GCyganek commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

The hidden radio buttons are hard to crack, it's a global issue that in landscape mode for some reasone useSafeAreaInsets returns 0 for right and left insets where there is a navigation bar on Android. Working on solving this somehow...

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@GCyganek

GCyganek commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Ok, should be fixed with the patch I added:

Screen.Recording.2026-04-09.at.18.37.30.mov

@truph01

truph01 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-04-10.at.17.14.00.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-04-10.at.17.17.35.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

@truph01

truph01 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@GCyganek This one should be updated as well:

style={[styles.getUserSelectionListPopoverHeight(sections.flatMap((section) => section.data).length || 1, windowHeight, shouldUseNarrowLayout, true)]}

since getUserSelectionListPopoverHeight's been updated.

@truph01

truph01 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@codex review

@GCyganek

Copy link
Copy Markdown
Contributor Author

I just checked changes here also fix #87369

@GCyganek

Copy link
Copy Markdown
Contributor Author

@GCyganek This one should be updated as well:

style={[styles.getUserSelectionListPopoverHeight(sections.flatMap((section) => section.data).length || 1, windowHeight, shouldUseNarrowLayout, true)]}

since getUserSelectionListPopoverHeight's been updated.

Thanks, updated!

@GCyganek

Copy link
Copy Markdown
Contributor Author

#87374 also fixed here

Screen.Recording.2026-04-10.at.12.38.12.mov

@GCyganek

Copy link
Copy Markdown
Contributor Author

#87375 also fixed here

Screen.Recording.2026-04-10.at.12.43.50.mov

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf795aac09

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/styles/index.ts
},

getUserSelectionListPopoverHeight: (itemCount: number, windowHeight: number, shouldUseNarrowLayout: boolean, isSearchable = true) => {
getUserSelectionListPopoverHeight: (itemCount: number, windowHeight: number, shouldUseNarrowLayout: boolean, isInLandscapeMode: boolean, isSearchable = true) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Maintain getUserSelectionListPopoverHeight arg order

getUserSelectionListPopoverHeight now inserts isInLandscapeMode before the existing optional isSearchable parameter, but at least one existing caller (src/components/Search/FilterDropdowns/InSelectPopup.tsx:186) still passes four arguments in the old order. That true is now interpreted as isInLandscapeMode, so the “In” filter popup always uses landscape sizing logic even in portrait, which can produce incorrect popup height limits on phones. Please preserve backward compatibility (e.g., append new params or update all callers) to avoid this regression.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in last commit, already caught by @truph01 🥇

Comment thread src/styles/index.ts
const ESTIMATED_LIST_HEIGHT = itemCount * variables.optionRowHeightCompact + SEARCHBAR_HEIGHT + SEARCHBAR_PADDING + LIST_BOTTOM_PADDING;
const MAX_HEIGHT = CONST.POPOVER_DROPDOWN_MAX_HEIGHT - (PADDING + GAP + BUTTON_HEIGHT);
const popoverHeight = isInLandscapeMode ? CONST.MODAL_MAX_HEIGHT_TO_WINDOW_HEIGHT_RATIO_LANDSCAPE_MODE * windowHeight : CONST.POPOVER_DROPDOWN_MAX_HEIGHT;
const MAX_HEIGHT = popoverHeight - (PADDING + GAP + BUTTON_HEIGHT) - (shouldShowLabel ? LABEL_HEIGHT + GAP : 0);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a difference between this PR and main in portrait mode. I’m not sure whether this will be caught as a regression due to the discrepancy:

PR Main
Image Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be safe as long as we ensure that all logic introduced to fix landscape mode does not affect portrait mode.

@GCyganek GCyganek Apr 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change for portrait mode is now it will count label height with gap to the MAX_HEIGHT (if shouldShowLabel is true). IMO it's not harmful, it should be counted int landscape mode, but in portrait it makes no difference apart from a little bit taller popover

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it to count label height + gap only in landscape mode if you prefer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, don't need. Your explanation above sounds good!

Comment thread src/styles/index.ts
// the listHeight, the max height of the popover, or 90% of the window height, such that we never overflow the screen
// and never expand over the max height
const height = Math.min(ESTIMATED_LIST_HEIGHT, CONST.POPOVER_DROPDOWN_MAX_HEIGHT, windowHeight * 0.9);
const height = Math.min(ESTIMATED_LIST_HEIGHT, popoverHeight - MODAL_PADDING, windowHeight * 0.9);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a must-have for landscape mode, in portrait mode it will make the popover smaller by 32 in some cases at most. I can change it to landscape mode only if you prefer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, don't need. Your explanation above sounds good!

@melvin-bot
melvin-bot Bot requested a review from mjasikowski April 10, 2026 11:09
@mjasikowski

Copy link
Copy Markdown
Contributor

@Expensify/design over to you for a sanity check

@GCyganek

Copy link
Copy Markdown
Contributor Author

@Expensify/design any final feedback on this before we merge?

@dannymcclain

Copy link
Copy Markdown
Contributor

I think it's looking good to me 👍

@shawnborton

Copy link
Copy Markdown
Contributor

Yup same, send it 👍

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Looks great (nice to see some high contrast theme testing too 😅)

@mjasikowski
mjasikowski merged commit c99b0b5 into Expensify:main Apr 14, 2026
53 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.60-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR. It fixes UI layout issues with filter popups in landscape mode on Android (radio buttons hidden behind the navigation bar, content not scrollable). The changes are:

  • A patch to react-native-keyboard-controller for navigation bar insets in landscape
  • Style adjustments to getSelectionListPopoverHeight and getUserSelectionListPopoverHeight to account for landscape mode
  • Various filter dropdown components updated to pass landscape/screen-size parameters

No help site documentation changes are required — this is purely a visual/layout bug fix with no impact on user-facing features, workflows, settings, or terminology.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants