Repository navigation
Fix Radio buttons are hidden behind navigation bar, unable to scroll down filters - #87376
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Looks good to me. I'm kind of surprised the headers of these menus are fixed but that's an already-existing problem 🤣 |
This issue is still reproducible in this PR: Screen.Recording.2026-04-09.at.09.55.51.movCould you help check? |
Ah, right, sorry for that, I focused on the scrolling issues and skipped that, thank you! I'm on it |
|
The hidden radio buttons are hard to crack, it's a global issue that in landscape mode for some reasone useSafeAreaInsets returns 0 for right and left insets where there is a navigation bar on Android. Working on solving this somehow... |
…ehind navigation bar
|
|
|
Ok, should be fixed with the patch I added: Screen.Recording.2026-04-09.at.18.37.30.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-10.at.17.14.00.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-04-10.at.17.17.35.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
@GCyganek This one should be updated as well: since |
|
@codex review |
|
I just checked changes here also fix #87369 |
Thanks, updated! |
|
#87374 also fixed here Screen.Recording.2026-04-10.at.12.38.12.mov |
|
#87375 also fixed here Screen.Recording.2026-04-10.at.12.43.50.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf795aac09
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
|
|
||
| getUserSelectionListPopoverHeight: (itemCount: number, windowHeight: number, shouldUseNarrowLayout: boolean, isSearchable = true) => { | ||
| getUserSelectionListPopoverHeight: (itemCount: number, windowHeight: number, shouldUseNarrowLayout: boolean, isInLandscapeMode: boolean, isSearchable = true) => { |
There was a problem hiding this comment.
Maintain getUserSelectionListPopoverHeight arg order
getUserSelectionListPopoverHeight now inserts isInLandscapeMode before the existing optional isSearchable parameter, but at least one existing caller (src/components/Search/FilterDropdowns/InSelectPopup.tsx:186) still passes four arguments in the old order. That true is now interpreted as isInLandscapeMode, so the “In” filter popup always uses landscape sizing logic even in portrait, which can produce incorrect popup height limits on phones. Please preserve backward compatibility (e.g., append new params or update all callers) to avoid this regression.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in last commit, already caught by @truph01 🥇
| const ESTIMATED_LIST_HEIGHT = itemCount * variables.optionRowHeightCompact + SEARCHBAR_HEIGHT + SEARCHBAR_PADDING + LIST_BOTTOM_PADDING; | ||
| const MAX_HEIGHT = CONST.POPOVER_DROPDOWN_MAX_HEIGHT - (PADDING + GAP + BUTTON_HEIGHT); | ||
| const popoverHeight = isInLandscapeMode ? CONST.MODAL_MAX_HEIGHT_TO_WINDOW_HEIGHT_RATIO_LANDSCAPE_MODE * windowHeight : CONST.POPOVER_DROPDOWN_MAX_HEIGHT; | ||
| const MAX_HEIGHT = popoverHeight - (PADDING + GAP + BUTTON_HEIGHT) - (shouldShowLabel ? LABEL_HEIGHT + GAP : 0); |
There was a problem hiding this comment.
It should be safe as long as we ensure that all logic introduced to fix landscape mode does not affect portrait mode.
There was a problem hiding this comment.
The only change for portrait mode is now it will count label height with gap to the MAX_HEIGHT (if shouldShowLabel is true). IMO it's not harmful, it should be counted int landscape mode, but in portrait it makes no difference apart from a little bit taller popover
There was a problem hiding this comment.
I can change it to count label height + gap only in landscape mode if you prefer
There was a problem hiding this comment.
No, don't need. Your explanation above sounds good!
| // the listHeight, the max height of the popover, or 90% of the window height, such that we never overflow the screen | ||
| // and never expand over the max height | ||
| const height = Math.min(ESTIMATED_LIST_HEIGHT, CONST.POPOVER_DROPDOWN_MAX_HEIGHT, windowHeight * 0.9); | ||
| const height = Math.min(ESTIMATED_LIST_HEIGHT, popoverHeight - MODAL_PADDING, windowHeight * 0.9); |
There was a problem hiding this comment.
It's a must-have for landscape mode, in portrait mode it will make the popover smaller by 32 in some cases at most. I can change it to landscape mode only if you prefer
There was a problem hiding this comment.
No, don't need. Your explanation above sounds good!
|
@Expensify/design over to you for a sanity check |
|
@Expensify/design any final feedback on this before we merge? |
|
I think it's looking good to me 👍 |
|
Yup same, send it 👍 |
|
Looks great (nice to see some high contrast theme testing too 😅) |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. It fixes UI layout issues with filter popups in landscape mode on Android (radio buttons hidden behind the navigation bar, content not scrollable). The changes are:
No help site documentation changes are required — this is purely a visual/layout bug fix with no impact on user-facing features, workflows, settings, or terminology. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|


Explanation of Change
Fixing layouts of the filter popups on the Reports screen to make sure nothing is cut off and that content is scrollable
Also making sure that with Navigation Bar enabled on Android there is no overlap of Navigation Bar with modals conents
Fixed Issues
$ #87307, #87369, #87374, #87375
PROPOSAL: N/A
Tests
Android with Navigation Bar enabled:
Android with Navigation Bar enabled:
Android with Navigation Bar enabled:
Android with Navigation Bar enabled:
Test other filters (single & multi select, date filters, From filters) to verify that their layout is not broken (nothing cut off, content scrollable where needed)
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-08.at.14.41.13.mov
Screen.Recording.2026-04-10.at.12.28.40.mov
Screen.Recording.2026-04-10.at.12.38.12.mov
Screen.Recording.2026-04-10.at.12.43.50.mov
iOS: Native
Screen.Recording.2026-04-08.at.14.44.01.mov