Repository navigation
Add backward compatibility for paths migrated to dynamic routes - #87870
Conversation
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I believe @mananjadhav will review this as the C+ of the project, right? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9a188a384
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@bernhardoj Yeah, @mananjadhav or @huult will review this PR 🙂 |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-04-16.at.21.26.06.mp4 |
huult
left a comment
There was a problem hiding this comment.
LGTM! Nice, everything works for all the cases I tested.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes are internal navigation/routing updates (old-to-new URL redirects, wildcard matching improvements, dead route removal) that don't affect any user-facing content documented in |
|
Hi @collectioneur @mjasikowski Could you please share link for staging?
|
Yes you can replace the prefix of the URL |
|
@izarutskaya Of course, here are the same URLs but on staging: Yes, this needs to be tested on web only 😄 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
OldRoutes.tsfor routes whose URLs changed after migration to dynamic routes (e.g./r/*/settings/name→/r/$1/details/settings/name,/workspaces/*/overview/address→/workspaces/$1/overview/workspace-address, etc.). ImprovedgetMatchingNewRoutewildcard logic to support multiple wildcards and$1/$2replacement references.REPORT_SETTINGS_NAMEroute fromROUTES.tsleft over from incorrect merge conflict resolution.getRedirectedPathfunction and consolidated/home-page→/homeredirect intoOldRoutes.ts, sincegetMatchingNewRoutealready provides the same functionality.Fixed Issues
$ #87859
Tests
1 Test
https://dev.new.expensify.com:8082/home-page/homeand renders the home screen correctly2 Test
https://dev.new.expensify.com:8082/settings/workspaces/workspacesand displays the workspaces list3 Test
https://dev.new.expensify.com:8082/r/<reportID>/settings/name(replace<reportID>with a valid report ID of a workspace room)/r/<reportID>/details/settings/nameand renders the report name settings page4 Test
https://dev.new.expensify.com:8082/workspaces/<policyID>/overview/address(replace<policyID>with a valid workspace ID)/workspaces/<policyID>/overview/workspace-addressand renders the workspace address pageOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-14.at.13.30.21.mov