Repository navigation
[No QA] Update Import-Personal-Card-Transactions-From-a-Spreadsheet.md - #88011
Conversation
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted correction to the FAQ section of the personal card spreadsheet import article. It updates one FAQ entry to fix both the question wording and the answer content -- changing from "No, you cannot import additional transactions to the same card" to "Yes, you can." This is a factual correction paired with a minor language cleanup. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://ba018e5a.helpdot.pages.dev ⚡️ Updated articles: |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari