Skip to content

[No QA] Update Import-Personal-Card-Transactions-From-a-Spreadsheet.md - #88011

Merged
stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-3
Apr 16, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-3

Conversation

@brianlee-expensify

@brianlee-expensify brianlee-expensify commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

  • improved clarity and phrasing, coming from this slack thread

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, targeted correction to the FAQ section of the personal card spreadsheet import article. It updates one FAQ entry to fix both the question wording and the answer content -- changing from "No, you cannot import additional transactions to the same card" to "Yes, you can." This is a factual correction paired with a minor language cleanup.

Scores Summary

  • Readability: 9/10 - The revised question and answer are clear, concise, and scannable. The answer is direct and action-oriented. Minor note: "simply" is filler that could be removed ("You can repeat the import process" is slightly tighter), but this is a very minor stylistic preference.
  • AI Readiness: 8/10 - The FAQ heading is a well-formed question using the feature context (personal card imports). It follows the convention of starting with a question word. However, the heading does not include the full feature name "personal card spreadsheet import" which would improve semantic retrieval precision. The existing heading "Can I import additional transactions to the same card?" is functional but could be more explicit (e.g., "Can I import additional personal card transactions from a spreadsheet to the same card?").
  • Style Compliance: 9/10 - The FAQ question format follows governance rules. No prohibited language is used. No UI elements are referenced that would need bolding. The phrasing is natural and matches user search intent.

Key Findings

  • The primary change is a factual correction -- the previous answer incorrectly stated users cannot import additional transactions to the same card, and this PR corrects that to "Yes."
  • The question itself was also cleaned up: removed "spreadsheet later on the same card entry?" (awkward phrasing) and replaced with the cleaner "transactions to the same card?" -- a clear improvement.
  • The word "simply" in "You can simply repeat the import process" is unnecessary filler per general plain-language writing standards, though the governance docs do not explicitly prohibit it.

Recommendations

  • Consider removing "simply" from the answer for tighter prose: "Yes. You can repeat the import process."
  • Optionally, consider including the full feature name in the FAQ heading for better AI retrieval (e.g., "Can I import additional personal card transactions to the same card?").

Files Reviewed

  • docs/articles/new-expensify/connect-credit-cards/Import-Personal-Card-Transactions-From-a-Spreadsheet.md - FAQ correction: updated question wording and corrected the answer from "No" to "Yes" regarding re-importing transactions to the same card.

@github-actions github-actions Bot changed the title Update Import-Personal-Card-Transactions-From-a-Spreadsheet.md [No QA] Update Import-Personal-Card-Transactions-From-a-Spreadsheet.md Apr 15, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ba018e5a.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott merged commit 51b40cb into main Apr 16, 2026
18 checks passed
@stephanieelliott
stephanieelliott deleted the brianlee-expensify-patch-3 branch April 16, 2026 06:36
@melvin-bot melvin-bot Bot added the Emergency label Apr 16, 2026
@melvin-bot

melvin-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants