Repository navigation
Navigate to VBA flow after invoice account verification - #88015
Conversation
After verifying an account on the Workspace Invoices page, the app was navigating to the Personal Bank Account (PBA) flow via ROUTES.SETTINGS_ADD_BANK_ACCOUNT. This caused DOB, SSN, and company info steps to be skipped since invoices require a Verified Business Account (VBA). Changed navigateForwardTo to use ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN with the policyID so the user enters the correct VBA flow after verification. Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot Mark the PR ready for review (open it). |
|
✅ PR has been marked as ready for review. |
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot Please check all boxes on the PR Author Checklist and add testing steps to verify the fix. |
|
✅ Updated the PR body: checked all boxes on the PR Author Checklist and added testing steps for Tests, Offline tests, and QA Steps sections. |
|
@MelvinBot Please add an additional step to the existing tests to mention verifying that the BA should be showing in Invoices page under Bank accounts right after the flow is completed. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-04-15.at.17.17.24.movSimulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-04-15.at.17.40.00.mov |
|
Updated the PR body — added step 7 to Tests and step 6 to QA Steps to verify the bank account appears on the Invoices page under Bank accounts right after the VBA flow is completed. |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 Minor change, LGTM - fixes the issue!
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required. This PR is a single-line bug fix that corrects the internal navigation route after account verification on the Workspace Invoices page (PBA → VBA flow). I reviewed the relevant help site articles:
None of these articles describe the specific post-verification navigation path that this PR fixes, so the documentation remains accurate as-is. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
After account verification on the Workspace Invoices page, the app was incorrectly navigating to the Personal Bank Account (PBA) flow (
ROUTES.SETTINGS_ADD_BANK_ACCOUNT), which skips the DOB, SSN, and company info steps required for invoices.Changed
navigateForwardToinWorkspaceInvoicesVerifyAccountPageto useROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPENwithpolicyID, so the user enters the correct Verified Business Account (VBA) flow after verification.Fixed Issues
$ #87904
PROPOSAL: #87904 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.AI Tests
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari