Repository navigation
BT - Migrate QBO AUTO_SYNC and ACCOUNTING_METHOD - #88020
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@huult This is ready for review. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-20.at.09.02.55.mp4Android: mWeb ChromeScreen.Recording.2026-04-20.at.09.04.51.mp4iOS: HybridAppScreen.Recording.2026-04-20.at.09.06.55.mp4iOS: mWeb SafariScreen.Recording.2026-04-20.at.09.07.59.mp4MacOS: Chrome / SafariScreen.Recording.2026-04-20.at.09.09.21.mp4 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 090a725138
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const goBack = useCallback(() => { | ||
| Navigation.goBack(backTo ?? ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED.getRoute(policyID)); | ||
| }, [policyID, backTo]); | ||
| Navigation.goBack(backPath); |
There was a problem hiding this comment.
Honor legacy backTo target on QBO auto-sync back action
This migration drops backTo handling when leaving the QBO auto-sync page: goBack now always uses the computed dynamic parent path, so legacy links like /workspaces/.../connections/quickbooks-online/advanced/autosync?backTo=... (which are still redirected and query-preserved by OldRoutes) no longer return users to their explicit backTo destination and instead send them to the advanced page path. That is a behavior regression for migrated deep links/bookmarks that previously relied on backTo.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
'/workspaces/*/connections/quickbooks-online/advanced/autosync': '/workspaces/$1/accounting/quickbooks-online/advanced/quickbooks-online-autosync',
Could you check why the redirect is not working after the new update?
There was a problem hiding this comment.
I tested both the redirects are working. I uploaded the screencasts in the web section of the PR body.
There was a problem hiding this comment.
goBack now always uses the computed dynamic parent path, so legacy links lik
I think this is the expected behavior. The goal of the OldRoutes is to ensure the old links work. But once redirected, back to will be handled using computed dynamic route only.
There was a problem hiding this comment.
Weird it works fine with backTo at my end. Just tried with the URL https://dev.new.expensify.com:8082/workspaces/0A4437F694CAAAD7/connections/quickbooks-online/advanced/autosync?backTo=adejrnjnvrfjn
web-bt-autosync-redirect-with-backto.mov
There was a problem hiding this comment.
Screen.Recording.2026-04-20.at.10.22.57.mov
This issue is still happening.
There was a problem hiding this comment.
@collectioneur @mjasikowski Can one of you also please test this?
There was a problem hiding this comment.
@huult I'll create an ad hoc build without rock cache. Can you check if you can still replicate then?
There was a problem hiding this comment.
Screen.Recording.2026-04-20.at.21.54.50.mov
It's works!
|
PR doesn’t need product input as a code migration PR. Unassigning and unsubscribing myself. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes are required for this PR. This PR is a purely internal navigation refactor — it migrates the QBO Auto Sync and Accounting Method pages from legacy static routes to the newer "dynamic routes" pattern. Specifically:
No user-facing behavior, feature names, labels, or navigation paths have changed. The existing help site article (Configure QuickBooks Online) references "Auto-sync" only by its UI label, not by any internal route — so it remains accurate as-is. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
Explanation of Change
Fixed Issues
$ #83839
PROPOSAL:
Tests
Preconditions
backToquery param from the URL (if present) before starting.Case 1 :
DYNAMIC_QUICKBOOKS_ONLINE_AUTO_SYNC(regression test)
Case 2 :
DYNAMIC_QUICKBOOKS_ONLINE_ACCOUNTING_METHODOffline tests
Same as test steps.
QA Steps
Same as test steps.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-bt-qbo-adv.mov
Android: mWeb Chrome
mweb-chrome-bt-qbo-adv.mov
iOS: Native
ios-bt-qbo-adv.mov
iOS: mWeb Safari
mweb-safari-bt-qbo-adv.mov
MacOS: Chrome / Safari
web-bt-qbo-adv.mov
Redirects:
web-bt-autosync-accounting-method-redirect.mov
web-bt-autosync-redirect.mov