Skip to content

Add dividers to More menu actions - #90097

Merged
Julesssss merged 5 commits into
Expensify:mainfrom
aswin-s:aswin-87964-menu-dividers
May 27, 2026
Merged

Julesssss merged 5 commits into
Expensify:mainfrom
aswin-s:aswin-87964-menu-dividers

Conversation

@aswin-s

@aswin-s aswin-s commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds visual dividers/section separators to the "More" popover menu actions in money request and report headers. Introduces a PopoverMenuSections.ts utility to group menu items into logical sections with dividers, and updates PopoverMenu to render section dividers between grouped items.

Fixed Issues

$ #87964
PROPOSAL: #87964 (comment)

Tests

Report with multiple expenses (Money Report):

  1. Open a report that has multiple submitted expenses
  2. Click the More button next to the primary action button (e.g., Approve) to open the "More" menu
  3. Verify dividers separate the following sections:
    • Section 1 (primary actions): Add expense, Submit/Retract/Reject/Approve/Unapprove/Cancel Payment (whichever are applicable)
    • Section 2 (report actions): Duplicate report, Change workspace, Change approver
    • Section 3 (export actions): Export, Download PDF, Print
    • Section 4 (utility/destructive): View details, Delete
  4. Verify no divider appears above the first item or below the last item
  5. Verify only visible/applicable actions appear (hidden actions don't leave stray dividers)

Report with a single expense:

  1. Open a report that has exactly one expense
  2. Open the "More" dropdown menu
  3. Verify an additional section appears for expense-level actions:
    • Section 2 (expense actions): Split, Merge, Duplicate expense, Move expense
    • Other sections remain the same as multi-expense reports

Held expense on a report:

  1. Open a report where an expense is on hold
  2. Open the "More" dropdown menu
  3. Verify "Remove hold" appears in Section 1 (replacing "Hold") with no extra divider

Individual expense (Transaction header):

  1. Open a single expense/transaction
  2. Click the More button next to the primary action to open the "More" menu
  3. Verify dividers separate the following sections:
    • Section 1 (primary actions): Hold/Remove hold, Reject, Split, Merge
    • Section 2 (modification actions): Duplicate, Move to report
    • Section 3 (utility/destructive): View details, Delete
  4. Verify no divider at top or bottom

Primary action filtering:

  1. Find a report where the primary CTA is "Approve"
  2. Open the "More" menu
  3. Verify "Approve" does NOT appear in the menu, and dividers still render correctly (no double divider where Approve was removed)
  • Verify that no errors appear in the JS console

Offline tests

  1. Disconnect from the network
  2. Open a money request and tap the "More" menu
  3. Verify dividers still render correctly (no network dependency)
  4. Open a money report and tap the "More" dropdown
  5. Verify dividers render correctly

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Follow all test scenarios above on each platform (Web, mWeb Safari, mWeb Chrome, iOS native, Android native)
  2. Pay special attention to divider visual styling — should be a thin line with consistent horizontal margins
  3. Verify dividers look correct in both light and dark mode
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mp4
Android: mWeb Chrome
android-web.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.Web.mp4
MacOS: Chrome / Safari
MacOS.mp4

@codecov

codecov Bot commented May 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/PopoverMenuSections.ts 100.00% <100.00%> (ø)
...eaderActions/MoneyReportHeaderSecondaryActions.tsx 0.00% <0.00%> (ø)
.../components/MoneyRequestHeaderSecondaryActions.tsx 0.53% <0.00%> (-0.01%) ⬇️
src/components/PopoverMenu/index.tsx 79.53% <60.00%> (+0.09%) ⬆️
... and 12 files with indirect coverage changes

@aswin-s
aswin-s marked this pull request as ready for review May 9, 2026 16:22
@aswin-s
aswin-s requested review from a team as code owners May 9, 2026 16:22
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and rojiphil May 9, 2026 16:22
@melvin-bot

melvin-bot Bot commented May 9, 2026

Copy link
Copy Markdown

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team May 9, 2026 16:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 049fb16bbb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +16 to +20
REPORT_SECONDARY_ACTIONS.REOPEN,
REPORT_SECONDARY_ACTIONS.REJECT,
REPORT_SECONDARY_ACTIONS.APPROVE,
REPORT_SECONDARY_ACTIONS.UNAPPROVE,
REPORT_SECONDARY_ACTIONS.CANCEL_PAYMENT,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include receivedPayment in report menu section map

getSecondaryReportActions() can emit REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT (see src/libs/ReportSecondaryActionUtils.ts), but this action is missing from REPORT_MORE_MENU_SECTIONS. Because sortAndSectionPopoverMenuItems() sends unrecognized actions to the last section, Received payment is moved below utility/destructive items and gets an extra separator, which regresses the intended grouping/order whenever that action is available.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswin-s The review comment seems reasonable. What do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rojiphil RECEIVED_PAYMENT was added in PR #86174 but subsequently reverted in PR #90159. It no longer exists in CONST.REPORT.SECONDARY_ACTIONS on main, so there's nothing to map.

@rojiphil rojiphil Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RECEIVED_PAYMENT got added later which we added in #91928

@aswin-s
aswin-s force-pushed the aswin-87964-menu-dividers branch from f154aab to 8dbb566 Compare May 19, 2026 03:31
aswin-s added 5 commits May 21, 2026 09:42
Include RECEIVED_PAYMENT in the first section of
REPORT_MORE_MENU_SECTIONS between APPROVE and UNAPPROVE
so it groups correctly with payment workflow actions
instead of falling to the unrecognized section.
RECEIVED_PAYMENT no longer exists in CONST.REPORT.SECONDARY_ACTIONS
on main, so remove it from the section map and its test.
@aswin-s
aswin-s force-pushed the aswin-87964-menu-dividers branch from 8dbb566 to a1160b8 Compare May 21, 2026 04:13
@flaviadefaria
flaviadefaria self-requested a review May 22, 2026 09:54
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @flaviadefaria has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@flaviadefaria
flaviadefaria removed the request for review from JmillsExpensify May 22, 2026 10:16
@rojiphil

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
90097-android-hybrid-001.mp4
Android: mWeb Chrome
90097-mweb-chrome-001.mp4
iOS: HybridApp
90097-ios-hybrid-001.mp4
iOS: mWeb Safari
90097-mweb-safari-001.mp4
MacOS: Chrome / Safari
90097-web-chrome-001.mp4

@rojiphil rojiphil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswin-s Thanks for the PR.

@jules Changes LGTM and works well too.
All yours now. Thanks.

@melvin-bot
melvin-bot Bot requested a review from Julesssss May 23, 2026 10:59
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@Julesssss
Julesssss requested a review from a team May 26, 2026 16:21
@Julesssss

Copy link
Copy Markdown
Contributor

Hey design team, could you check out this PR to add menu dividers please. AdHoc build incoming

@github-actions

This comment has been minimized.

@dannymcclain

Copy link
Copy Markdown
Contributor

It's looking really good to me!

@shawnborton

Copy link
Copy Markdown
Contributor

Agree, feels nice!

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, lets see what @dubielzyk-expensify thinks

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Looks good to me as well 👍

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design approved, merging

@Julesssss
Julesssss merged commit b4aa030 into Expensify:main May 27, 2026
41 of 42 checks passed
@melvin-bot melvin-bot Bot added the Emergency label May 27, 2026
@melvin-bot

melvin-bot Bot commented May 27, 2026

Copy link
Copy Markdown

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 27, 2026
75 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.84-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR and the help site articles under App/docs/articles.

No help site changes are required.

This PR adds visual dividers (section separators) to the "More" popover menu — it's a purely visual/styling enhancement. No menu items were added, removed, or renamed, and no user-facing workflows changed.

The relevant help articles I checked:

  • docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md — documents available report/expense actions and the More menu, but describes what actions exist, not the visual layout of the menu
  • docs/articles/new-expensify/reports-and-expenses/Duplicate-a-Report.md — references the More menu in step-by-step instructions but only as a navigation step

Since the documentation describes actions and workflows rather than menu styling, no updates are needed.

@aswin-s, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #91912 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #91928 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.86-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR against the help site articles under App/docs/articles.

No help site changes are required.

This PR adds visual dividers (section separators) between grouped items in the "More" popover menu. It does not add, remove, or rename any menu actions, nor does it change any user-facing workflows or behaviors.

The relevant help articles — Expense-and-Report-Actions.md and Understanding-Report-Statuses-and-Actions.md — document what actions are available, when they appear, and who can use them. They do not describe the visual layout or grouping of menu items, so this UI enhancement has no impact on the documentation.

@aswin-s, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.88-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR and the existing help site articles under App/docs/articles.

No help site changes are required.

This PR adds visual dividers (thin separator lines) between logical sections of the "More" popover menu on reports and transactions. It is a purely cosmetic/UX enhancement:

  • No new actions, settings, or features are added
  • No existing actions are renamed, removed, or have their behavior changed
  • No user-facing workflows or instructions change

The relevant help site articles (Expense and Report Actions, Understanding Report Statuses and Actions, Duplicate a Report) document what actions are available and how to access them — they do not describe the visual layout or grouping of menu items, so no updates are needed.

@aswin-s, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants