Repository navigation
Create new temporaryGetDisplayNameOrDefault function - #90290
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@mountiny Could you please unassign me from this PR? |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
@shubham1206agra mind continuing your review here? |
|
@shubham1206agra mind continuing your review? |
|
@cretadn22 Add test cases. Also, screenshot for atleast 1 platform |
|
@shubham1206agra Done |
|
@shubham1206agra mind continuing your review? |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-06-12.at.5.48.13.PM.mov |
shubham1206agra
left a comment
There was a problem hiding this comment.
Fix the tests please
Pushed an update |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review — no documentation changes required. I reviewed the changes in this PR against the help site content under What this PR does: It's an internal code refactor. It introduces a new Why no docs are needed:
Since this is a non-functional refactor with no product-surface impact, there's nothing to add or update in @cretadn22, let me know if you'd expect a help site change here that I may have missed. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed the changes in this PR against the help site files under No help site changes are required. This PR is a pure internal refactor with no user-facing behavior or copy change:
The rendered archived-report-footer message (e.g. the account-merge "This chat is no longer active…" copy) is unchanged — only how the display name is computed internally. There are no new features, settings, tabs, or labels to document, so no draft PR was created. @cretadn22, since no docs PR was created, there is nothing to review here. If you believe a help site change is warranted, let me know what behavior should be documented and I'll open a draft PR. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
Explanation of Change
Fixed Issues
$ #66392
PROPOSAL: #66392
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari