Skip to content

Create new temporaryGetDisplayNameOrDefault function - #90290

Merged
mountiny merged 14 commits into
Expensify:mainfrom
cretadn22:remove-ARE_TRANSLATIONS_LOADING-key-1
Jun 17, 2026
Merged

mountiny merged 14 commits into
Expensify:mainfrom
cretadn22:remove-ARE_TRANSLATIONS_LOADING-key-1

Conversation

@cretadn22

@cretadn22 cretadn22 commented May 12, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #66392
PROPOSAL: #66392

Tests

  1. Sign in to NewDot as employee B.
  2. Go to Settings > Profile and set a first and last name
  3. Sign in to NewDot as employee C.
  4. Go to Settings > Profile and set a first and last name
  5. Sign in to OldDot as employee B.
  6. Go to Settings > Account > Account Details and merge employee C's account into employee B's account.
  7. Go back to NewDot and employee C's workspace chat
  8. Sign in to NewDot as the admin and find the workspace chat for employee C.
  9. Verify that the report is archived and the message show This chat is no longer active because account B has merged their account with account C
  • Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

  1. Sign in to NewDot as employee B.
  2. Go to Settings > Profile and set a first and last name
  3. Sign in to NewDot as employee C.
  4. Go to Settings > Profile and set a first and last name
  5. Sign in to OldDot as employee B.
  6. Go to Settings > Account > Account Details and merge employee C's account into employee B's account.
  7. Go back to NewDot and employee C's workspace chat
  8. Sign in to NewDot as the admin and find the workspace chat for employee C.
  9. The report is archived and the message show This chat is no longer active because account B has merged their account with account C
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-06-08 at 20 17 56

@cretadn22
cretadn22 requested review from a team as code owners May 12, 2026 02:32
@melvin-bot
melvin-bot Bot requested review from DylanDylann and trjExpensify May 12, 2026 02:32
@melvin-bot

melvin-bot Bot commented May 12, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team May 12, 2026 02:32
@cretadn22 cretadn22 changed the title Create new temporaryGetDisplayNameOrDefault function [No QA] Create new temporaryGetDisplayNameOrDefault function May 12, 2026
@codecov

codecov Bot commented May 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/PersonalDetailsUtils.ts 82.37% <100.00%> (+2.18%) ⬆️
src/components/ArchivedReportFooter.tsx 0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

Comment thread src/libs/PersonalDetailsUtils.ts Resolved
@DylanDylann

Copy link
Copy Markdown
Contributor

@mountiny Could you please unassign me from this PR?

@mountiny
mountiny removed the request for review from DylanDylann May 12, 2026 07:18
Comment thread src/libs/PersonalDetailsUtils.ts Resolved
@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@trjExpensify
trjExpensify removed their request for review May 12, 2026 21:40
Comment thread src/libs/PersonalDetailsUtils.ts Resolved
@cretadn22

Copy link
Copy Markdown
Contributor Author

@shubham1206agra mind continuing your review here?

@cretadn22

Copy link
Copy Markdown
Contributor Author

@shubham1206agra mind continuing your review?

@shubham1206agra

Copy link
Copy Markdown
Contributor

@cretadn22 Add test cases. Also, screenshot for atleast 1 platform

@cretadn22 cretadn22 changed the title [No QA] Create new temporaryGetDisplayNameOrDefault function Create new temporaryGetDisplayNameOrDefault function Jun 8, 2026
@cretadn22

Copy link
Copy Markdown
Contributor Author

@shubham1206agra Done

@cretadn22

Copy link
Copy Markdown
Contributor Author

@shubham1206agra mind continuing your review?

@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • xIf a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-06-12.at.5.48.13.PM.mov

@melvin-bot
melvin-bot Bot requested a review from mountiny June 12, 2026 12:32

@shubham1206agra shubham1206agra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the tests please

@cretadn22

Copy link
Copy Markdown
Contributor Author

@cretadn22 Please don't use useLocalize hook as this is not a component. Please see how other tests implement translate function.

Pushed an update

@mountiny
mountiny merged commit cb40305 into Expensify:main Jun 17, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 17, 2026
67 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review — no documentation changes required.

I reviewed the changes in this PR against the help site content under docs/articles.

What this PR does: It's an internal code refactor. It introduces a new temporaryGetDisplayNameOrDefault helper in PersonalDetailsUtils.ts that accepts a translate function as a parameter, and switches ArchivedReportFooter.tsx to use it (replacing getDisplayNameOrDefault).

Why no docs are needed:

  • No user-facing behavior changes — the archived-report footer message and the resolved display names render exactly as before.
  • No new feature, setting, tab, button, or workflow was added or renamed.
  • The only displayed copy is sourced from src/languages/* (unchanged), not from help site articles.

Since this is a non-functional refactor with no product-surface impact, there's nothing to add or update in docs/articles, and no draft docs PR was created.

@cretadn22, let me know if you'd expect a help site change here that I may have missed.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site files under docs/articles.

No help site changes are required.

This PR is a pure internal refactor with no user-facing behavior or copy change:

  • It adds a new temporaryGetDisplayNameOrDefault function in PersonalDetailsUtils.ts that accepts an explicit translate argument (to remove the dependency on the ARE_TRANSLATIONS_LOADING key).
  • It swaps getDisplayNameOrDefault → temporaryGetDisplayNameOrDefault inside ArchivedReportFooter.tsx.
  • The rest is unit tests.

The rendered archived-report-footer message (e.g. the account-merge "This chat is no longer active…" copy) is unchanged — only how the display name is computed internally. There are no new features, settings, tabs, or labels to document, so no draft PR was created.

@cretadn22, since no docs PR was created, there is nothing to review here. If you believe a help site change is warranted, let me know what behavior should be documented and I'll open a draft PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.14-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants