Repository navigation
Update Concierge welcome message to describe capabilities - #90384
Conversation
…sage Remove the tagline from the askConcierge translation string across all languages, keeping only the introductory sentence. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Change askConcierge text from 'This is your chat with Concierge, your personal AI agent.' to 'Concierge can answer questions, update expenses, and more.' across all 10 languages and the corresponding unit test. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
Updated the Concierge welcome message to |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 6262bd18..9590b82a 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -850,7 +850,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Dein Bereich',
welcomeToRoom: (roomName: string) => `Willkommen in ${roomName}!`,
usePlusButton: (additionalText: string) => `Verwende die +‑Taste, um eine Ausgabe zu ${additionalText}.`,
- askConcierge: 'Concierge kann Fragen beantworten, Ausgaben aktualisieren und vieles mehr.',
+ askConcierge: 'Concierge kann Fragen beantworten, Ausgaben aktualisieren und mehr.',
conciergeSupport: 'Dein persönlicher KI-Agent',
create: 'erstellen',
iouTypes: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 1eefa6e3..27ddb1d4 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1687,10 +1687,8 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Fondo del Modal',
},
nextStep: {
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas gastos.`;
@@ -1701,7 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_SUBMIT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> envíes los gastos.`;
@@ -1713,7 +1710,6 @@ const translations: TranslationDeepObject<typeof en> = {
},
[CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> añadas una cuenta bancaria.`;
@@ -1728,7 +1724,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` el ${eta} de cada mes` : ` ${eta}`;
}
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que tus gastos se envíen automáticamente${formattedETA}.`;
@@ -1739,7 +1734,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> soluciones ellos problemas.`;
@@ -1750,7 +1744,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> apruebes los gastos.`;
@@ -1761,7 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_EXPORT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> exportes este informe.`;
@@ -1772,7 +1764,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> pagues los gastos.`;
@@ -1783,7 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> termines de configurar una cuenta bancaria de empresa.`;
@@ -1803,7 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
[CONST.NEXT_STEP.MESSAGE_KEY.SUBMITTING_TO_SELF]: (_actor, _actorType, _eta, _etaType) =>
`¡Ups! Parece que estás enviando el informe a <strong>ti mismo</strong>. Aprobar tus propios informes está <strong>prohibido</strong> por tu espacio de trabajo. Por favor, envía este informe a otra persona o contacta a tu administrador para cambiar la persona a la que lo envías.`,
[CONST.NEXT_STEP.MESSAGE_KEY.REJECTED_REPORT]: (actor, actorType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Este informe fue rechazado. Esperando a que <strong>tú</strong> corrijas los problemas y lo vuelvas a enviar manualmente.`;
@@ -2458,7 +2447,6 @@ ${amount} para ${merchant} - ${date}`,
two: 'º',
few: 'º',
other: 'º',
- /* eslint-disable @typescript-eslint/naming-convention */
'1': 'Primero',
'2': 'Segundo',
'3': 'Tercero',
@@ -2469,7 +2457,6 @@ ${amount} para ${merchant} - ${date}`,
'8': 'Octavo',
'9': 'Noveno',
'10': 'Décimo',
- /* eslint-enable @typescript-eslint/naming-convention */
},
},
approverInMultipleWorkflows: 'Este miembro ya pertenece a otro flujo de aprobación. Cualquier actualización aquí se reflejará allí también.',
@@ -6931,7 +6918,6 @@ ${amount} para ${merchant} - ${date}`,
restrictedDescription: 'Sólo las personas en tu espacio de trabajo pueden encontrar esta sala',
privateDescription: 'Sólo las personas que están invitadas a esta sala pueden encontrarla',
publicDescription: 'Cualquier persona puede unirse a esta sala',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announceDescription: 'Cualquier persona puede unirse a esta sala',
createRoom: 'Crea una sala de chat',
roomAlreadyExistsError: 'Ya existe una sala con este nombre',
@@ -6951,7 +6937,6 @@ ${amount} para ${merchant} - ${date}`,
restricted: 'Espacio de trabajo',
private: 'Privada',
public: 'Público',
- // eslint-disable-next-line @typescript-eslint/naming-convention
public_announce: 'Anuncio Público',
},
},
@@ -7266,7 +7251,6 @@ ${amount} para ${merchant} - ${date}`,
updatedDefaultTitle: (newDefaultTitle, oldDefaultTitle) => `cambió la fórmula personalizada del nombre del informe a "${newDefaultTitle}" (previamente "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail, oldOwnerName, policyName) => `asumió la propiedad del espacio de trabajo ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled) => `${enabled ? 'habilitó' : 'deshabilitó'} el envío programado`,
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount,
budgetFrequency,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 878ce197..88168a28 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -853,7 +853,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Votre espace',
welcomeToRoom: (roomName: string) => `Bienvenue dans ${roomName} !`,
usePlusButton: (additionalText: string) => `Utilisez le bouton + pour ${additionalText} une dépense.`,
- askConcierge: 'Concierge peut répondre à vos questions, mettre à jour vos dépenses et bien plus encore.',
+ askConcierge: 'Concierge peut répondre aux questions, mettre à jour les dépenses, et plus encore.',
conciergeSupport: 'Votre agent IA personnel',
create: 'créer',
iouTypes: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 90864c49..06ffcebc 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -851,7 +851,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Il tuo spazio',
welcomeToRoom: (roomName: string) => `Benvenuto in ${roomName}!`,
usePlusButton: (additionalText: string) => `Usa il pulsante + per ${additionalText} una spesa.`,
- askConcierge: 'Concierge può rispondere alle domande, aggiornare le spese e molto altro.',
+ askConcierge: 'Concierge può rispondere alle domande, aggiornare le spese e altro ancora.',
conciergeSupport: 'Il tuo agente IA personale',
create: 'crea',
iouTypes: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index a5bd544f..a221f37d 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -837,7 +837,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'あなたのスペース',
welcomeToRoom: (roomName: string) => `${roomName} へようこそ!`,
usePlusButton: (additionalText: string) => `+ ボタンを使って経費を${additionalText}します。`,
- askConcierge: 'Conciergeは質問に答えたり、経費を更新したりすることができます。',
+ askConcierge: 'Concierge は、質問にお答えしたり、経費を更新したり、さまざまなことができます。',
conciergeSupport: 'あなた専用のAIエージェント',
create: '作成',
iouTypes: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 34276465..ec7a8876 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -850,7 +850,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Twoja przestrzeń',
welcomeToRoom: (roomName: string) => `Witaj w ${roomName}!`,
usePlusButton: (additionalText: string) => `Użyj przycisku +, aby ${additionalText} wydatek.`,
- askConcierge: 'Concierge może odpowiadać na pytania, aktualizować wydatki i wiele więcej.',
+ askConcierge: 'Concierge może odpowiadać na pytania, aktualizować wydatki i nie tylko.',
conciergeSupport: 'Twój osobisty agent AI',
create: 'utwórz',
iouTypes: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
The Failing check: Why it's unrelated: This PR only modifies translation strings ( The only other failing check is the PR Author Checklist, which is expected (unchecked boxes in the template). Recommendation: Re-run the |
|
The only real failing check is Failure: Why it's unrelated: This PR only changes language translation strings and a unit test. The same The other failing check ( |
|
@MelvinBot can you update the title and original comment of this pull request to reflect the updated changes it's making? |
|
Updated the PR title and description to reflect the current state of the changes:
|
|
The Failing check: Why it's unrelated: This PR only modifies translation strings in The only other failing check is |
|
The failing checks are:
The perf-test failure is a render count regression in No code fix is needed from this PR's side. You can re-run the |
|
The failing checks are:
No code fix is needed from this PR. You can re-run the perf-tests job to see if it passes on retry. |
|
The Failure: Evidence: The identical failure is occurring on the unrelated All other checks (ESLint, Prettier, typecheck, all 8 test shards, builds, spellcheck, etc.) are passing. |
mollfpr
left a comment
There was a problem hiding this comment.
It seems the translation from this PR was generated directly by Melvin. I think we should use Polyglot Parrot's suggestions instead.
The most notable gap is in the Japanese translations which is missing the "and more".
| welcomeToRoom: (roomName: string) => `${roomName} へようこそ!`, | ||
| usePlusButton: (additionalText: string) => `+ ボタンを使って経費を${additionalText}します。`, | ||
| askConcierge: 'こちらはあなた専属のAIエージェント、Conciergeとのチャットです。ほぼ何でもできますので、お試しください!', | ||
| askConcierge: 'Conciergeは質問に答えたり、経費を更新したりすることができます。', |
There was a problem hiding this comment.
@jamesdeanexpensify We can ask Melvin to apply the translation diff generated by the Polyglot.
There was a problem hiding this comment.
The updated Japanese translation from Polyglot Parrot now includes "and more" — applied as: Concierge は、質問にお答えしたり、経費を更新したり、さまざまなことができます。
|
The only actionable failing check is The
This PR only modifies translation strings in All code-quality checks (ESLint, Prettier, typecheck, all 8 test shards, Storybook, builds) are passing. |
|
The Analysis: The Reassure render-count check ( Evidence: This PR only modifies translation files ( The only other failing check is No action needed — the code checks (ESLint, Prettier, typecheck, all 8 test jobs, builds) are all passing. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine for product
|
The Failure: Why it's unrelated: This PR only modifies language string files ( The only other failing check is |
|
What's next here? |
|
@mollfpr need anything from me here? |
|
@jamesdeanexpensify You can ask Melvin to implement the translation from Polyglot Parrot 👍 |
|
@MelvinBot please implement the translations from Polyglot Parrot |
Co-authored-by: jamesdeanexpensify <jamesdeanexpensify@users.noreply.github.com> Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
Applied the Polyglot Parrot translation refinements for
Note: The |
|
The only failing checks on this PR are All code checks that have completed are passing: ESLint, Prettier, typecheck, builds, generateTranslations, Storybook, and spellcheck. Jest unit tests are currently in progress but have never failed on this branch. No code fix is needed. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
All checks on this PR are currently passing — there are no failing checks to fix. 🟢 |
|
@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and checked all help site articles under No help site changes are required. The old message text ("This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!") does not appear anywhere in the help docs. The existing Concierge articles ( @jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed all help site files under No help site changes are required. None of the existing help articles quote or reference the in-app welcome message text. The Concierge help articles ( @jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR (updating the Concierge welcome message from "This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!" to "Concierge can answer questions, update expenses, and more.") against all help site articles under No help site changes are required. None of the existing help articles quote or reference the specific in-app welcome message text. The Concierge-related articles ( @jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|

Slack
https://expensify.slack.com/archives/C090U774ZH7/p1778621853589979
Explanation of Change
Update the Concierge welcome message across all 10 supported languages (en, de, es, fr, it, ja, nl, pl, pt-BR, zh-hans) from "This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!" to "Concierge can answer questions, update expenses, and more." Updated the corresponding unit test assertion as well.
Fixed Issues
$
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari