Skip to content

Update Concierge welcome message to describe capabilities - #90384

Merged
deetergp merged 3 commits into
mainfrom
claude-removeAskConciergeTagline
May 27, 2026
Merged

deetergp merged 3 commits into
mainfrom
claude-removeAskConciergeTagline

Conversation

@MelvinBot

@MelvinBot MelvinBot commented May 12, 2026 •

Copy link
Copy Markdown
Contributor

Slack

https://expensify.slack.com/archives/C090U774ZH7/p1778621853589979

Explanation of Change

Update the Concierge welcome message across all 10 supported languages (en, de, es, fr, it, ja, nl, pl, pt-BR, zh-hans) from "This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!" to "Concierge can answer questions, update expenses, and more." Updated the corresponding unit test assertion as well.

Fixed Issues

$

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. In New Expensify, go to Account > Help > click "Concierge"
  2. Verify that the copy is updated here:
image
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…sage

Remove the tagline from the askConcierge translation string across all
languages, keeping only the introductory sentence.

Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team May 12, 2026 21:31
@OSBotify

This comment has been minimized.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@MelvinBot

  • Change this: This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!
  • To this: Concierge can answer questions, update expenses, and more.

Change askConcierge text from 'This is your chat with Concierge, your personal AI agent.'
to 'Concierge can answer questions, update expenses, and more.' across all
10 languages and the corresponding unit test.

Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated the Concierge welcome message to Concierge can answer questions, update expenses, and more. across all 10 languages and the unit test.

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 6262bd18..9590b82a 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -850,7 +850,7 @@ const translations: TranslationDeepObject<typeof en> = {
         yourSpace: 'Dein Bereich',
         welcomeToRoom: (roomName: string) => `Willkommen in ${roomName}!`,
         usePlusButton: (additionalText: string) => `Verwende die +‑Taste, um eine Ausgabe zu ${additionalText}.`,
-        askConcierge: 'Concierge kann Fragen beantworten, Ausgaben aktualisieren und vieles mehr.',
+        askConcierge: 'Concierge kann Fragen beantworten, Ausgaben aktualisieren und mehr.',
         conciergeSupport: 'Dein persönlicher KI-Agent',
         create: 'erstellen',
         iouTypes: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 1eefa6e3..27ddb1d4 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1687,10 +1687,8 @@ const translations: TranslationDeepObject<typeof en> = {
         backdropLabel: 'Fondo del Modal',
     },
     nextStep: {
-        /* eslint-disable @typescript-eslint/no-unused-vars */
         message: {
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> añadas gastos.`;
@@ -1701,7 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 }
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_SUBMIT]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> envíes los gastos.`;
@@ -1713,7 +1710,6 @@ const translations: TranslationDeepObject<typeof en> = {
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_actor, _actorType, _eta, _etaType) => `¡No se requiere ninguna acción adicional!`,
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> añadas una cuenta bancaria.`;
@@ -1728,7 +1724,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 if (eta) {
                     formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` el ${eta} de cada mes` : ` ${eta}`;
                 }
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que tus gastos se envíen automáticamente${formattedETA}.`;
@@ -1739,7 +1734,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 }
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> soluciones ellos problemas.`;
@@ -1750,7 +1744,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 }
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> apruebes los gastos.`;
@@ -1761,7 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 }
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_EXPORT]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> exportes este informe.`;
@@ -1772,7 +1764,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 }
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> pagues los gastos.`;
@@ -1783,7 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
                 }
             },
             [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: (actor, actorType, _eta, _etaType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Esperando a que <strong>tú</strong> termines de configurar una cuenta bancaria de empresa.`;
@@ -1803,7 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
             [CONST.NEXT_STEP.MESSAGE_KEY.SUBMITTING_TO_SELF]: (_actor, _actorType, _eta, _etaType) =>
                 `¡Ups! Parece que estás enviando el informe a <strong>ti mismo</strong>. Aprobar tus propios informes está <strong>prohibido</strong> por tu espacio de trabajo. Por favor, envía este informe a otra persona o contacta a tu administrador para cambiar la persona a la que lo envías.`,
             [CONST.NEXT_STEP.MESSAGE_KEY.REJECTED_REPORT]: (actor, actorType) => {
-                // eslint-disable-next-line default-case
                 switch (actorType) {
                     case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
                         return `Este informe fue rechazado. Esperando a que <strong>tú</strong> corrijas los problemas y lo vuelvas a enviar manualmente.`;
@@ -2458,7 +2447,6 @@ ${amount} para ${merchant} - ${date}`,
                 two: 'º',
                 few: 'º',
                 other: 'º',
-                /* eslint-disable @typescript-eslint/naming-convention */
                 '1': 'Primero',
                 '2': 'Segundo',
                 '3': 'Tercero',
@@ -2469,7 +2457,6 @@ ${amount} para ${merchant} - ${date}`,
                 '8': 'Octavo',
                 '9': 'Noveno',
                 '10': 'Décimo',
-                /* eslint-enable @typescript-eslint/naming-convention */
             },
         },
         approverInMultipleWorkflows: 'Este miembro ya pertenece a otro flujo de aprobación. Cualquier actualización aquí se reflejará allí también.',
@@ -6931,7 +6918,6 @@ ${amount} para ${merchant} - ${date}`,
         restrictedDescription: 'Sólo las personas en tu espacio de trabajo pueden encontrar esta sala',
         privateDescription: 'Sólo las personas que están invitadas a esta sala pueden encontrarla',
         publicDescription: 'Cualquier persona puede unirse a esta sala',
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         public_announceDescription: 'Cualquier persona puede unirse a esta sala',
         createRoom: 'Crea una sala de chat',
         roomAlreadyExistsError: 'Ya existe una sala con este nombre',
@@ -6951,7 +6937,6 @@ ${amount} para ${merchant} - ${date}`,
             restricted: 'Espacio de trabajo',
             private: 'Privada',
             public: 'Público',
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             public_announce: 'Anuncio Público',
         },
     },
@@ -7266,7 +7251,6 @@ ${amount} para ${merchant} - ${date}`,
         updatedDefaultTitle: (newDefaultTitle, oldDefaultTitle) => `cambió la fórmula personalizada del nombre del informe a "${newDefaultTitle}" (previamente "${oldDefaultTitle}")`,
         updatedOwnership: (oldOwnerEmail, oldOwnerName, policyName) => `asumió la propiedad del espacio de trabajo ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
         updatedAutoHarvesting: (enabled) => `${enabled ? 'habilitó' : 'deshabilitó'} el envío programado`,
-        // eslint-disable-next-line @typescript-eslint/max-params
         updatedIndividualBudgetNotification: (
             budgetAmount,
             budgetFrequency,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 878ce197..88168a28 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -853,7 +853,7 @@ const translations: TranslationDeepObject<typeof en> = {
         yourSpace: 'Votre espace',
         welcomeToRoom: (roomName: string) => `Bienvenue dans ${roomName} !`,
         usePlusButton: (additionalText: string) => `Utilisez le bouton + pour ${additionalText} une dépense.`,
-        askConcierge: 'Concierge peut répondre à vos questions, mettre à jour vos dépenses et bien plus encore.',
+        askConcierge: 'Concierge peut répondre aux questions, mettre à jour les dépenses, et plus encore.',
         conciergeSupport: 'Votre agent IA personnel',
         create: 'créer',
         iouTypes: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 90864c49..06ffcebc 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -851,7 +851,7 @@ const translations: TranslationDeepObject<typeof en> = {
         yourSpace: 'Il tuo spazio',
         welcomeToRoom: (roomName: string) => `Benvenuto in ${roomName}!`,
         usePlusButton: (additionalText: string) => `Usa il pulsante + per ${additionalText} una spesa.`,
-        askConcierge: 'Concierge può rispondere alle domande, aggiornare le spese e molto altro.',
+        askConcierge: 'Concierge può rispondere alle domande, aggiornare le spese e altro ancora.',
         conciergeSupport: 'Il tuo agente IA personale',
         create: 'crea',
         iouTypes: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index a5bd544f..a221f37d 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -837,7 +837,7 @@ const translations: TranslationDeepObject<typeof en> = {
         yourSpace: 'あなたのスペース',
         welcomeToRoom: (roomName: string) => `${roomName} へようこそ!`,
         usePlusButton: (additionalText: string) => `+ ボタンを使って経費を${additionalText}します。`,
-        askConcierge: 'Conciergeは質問に答えたり、経費を更新したりすることができます。',
+        askConcierge: 'Concierge は、質問にお答えしたり、経費を更新したり、さまざまなことができます。',
         conciergeSupport: 'あなた専用のAIエージェント',
         create: '作成',
         iouTypes: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 34276465..ec7a8876 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -850,7 +850,7 @@ const translations: TranslationDeepObject<typeof en> = {
         yourSpace: 'Twoja przestrzeń',
         welcomeToRoom: (roomName: string) => `Witaj w ${roomName}!`,
         usePlusButton: (additionalText: string) => `Użyj przycisku +, aby ${additionalText} wydatek.`,
-        askConcierge: 'Concierge może odpowiadać na pytania, aktualizować wydatki i wiele więcej.',
+        askConcierge: 'Concierge może odpowiadać na pytania, aktualizować wydatki i nie tylko.',
         conciergeSupport: 'Twój osobisty agent AI',
         create: 'utwórz',
         iouTypes: {

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The perf-tests failure is unrelated to this PR — it's a flaky render count check.

Failing check: [ReportActionCompose] should render Composer with text input interactions — render count difference of 1 exceeds the allowed deviation of 0.

Why it's unrelated: This PR only modifies translation strings (src/languages/*.ts) and a unit test (tests/unit/SidebarUtilsTest.ts). None of these files affect the ReportActionCompose component or its rendering behavior.

The only other failing check is the PR Author Checklist, which is expected (unchecked boxes in the template).

Recommendation: Re-run the perf-tests workflow — this should pass on retry.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only real failing check is perf-tests, and it's unrelated to this PR — it's a pre-existing flaky failure.

Failure: [ReportActionCompose] should render Composer with text input interactions — render count difference of 1 exceeds the allowed deviation of 0.

Why it's unrelated: This PR only changes language translation strings and a unit test. The same ReportActionCompose render count failure is also happening on completely unrelated branches (e.g., this run on rory/emoji-base/p1-app-dual-format-hex). This is a flaky perf test, not a regression from this PR.

The other failing check (checklist) is just unchecked PR template boxes — not a code issue.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@MelvinBot can you update the title and original comment of this pull request to reflect the updated changes it's making?

@MelvinBot MelvinBot changed the title Remove 'I can do almost anything, try me!' from Concierge welcome message Update Concierge welcome message to describe capabilities May 15, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Updated the PR title and description to reflect the current state of the changes:

  • Title: "Update Concierge welcome message to describe capabilities"
  • Description: Updated the explanation to reflect that the message changed from the original two-sentence version to "Concierge can answer questions, update expenses, and more." across all 10 languages plus the unit test.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The perf-tests failure is unrelated to this PR's changes.

Failing check: perf-tests — Render count difference exceeded the allowed deviation of 0. Current difference: 1 for [ReportActionCompose] should render Composer with text input interactions

Why it's unrelated: This PR only modifies translation strings in src/languages/*.ts and a unit test assertion in tests/unit/SidebarUtilsTest.ts. It does not touch any rendering logic, components, or anything related to ReportActionCompose. This is a flaky perf test render count deviation.

The only other failing check is checklist (PR Author Checklist), which is expected on draft/in-progress PRs.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing checks are:

  1. checklist — PR Author Checklist (unchecked boxes in the PR template, not a code issue)
  2. perf-tests — Unrelated to this PR

The perf-test failure is a render count regression in [ReportActionCompose] should render Composer with text input interactions (render count difference of 1 exceeded the allowed deviation of 0). This PR only changes language translation files (src/languages/*.ts) and tests/unit/SidebarUtilsTest.ts — none of which affect the ReportActionCompose component's render behavior. This is a pre-existing/flaky perf test failure.

No code fix is needed from this PR's side. You can re-run the perf-tests workflow to see if it passes on retry.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing checks are:

  1. checklist — PR Author Checklist (not a code failure, just unchecked boxes in the PR template)
  2. perf-tests — Unrelated to this PR. The failure is a render count deviation in [ReportActionCompose] should render Composer with text input interactions (current difference: 1, allowed: 0). This PR only modifies translation strings in src/languages/*.ts and tests/unit/SidebarUtilsTest.ts, none of which affect the ReportActionCompose render path. This appears to be a pre-existing/flaky perf regression.

No code fix is needed from this PR. You can re-run the perf-tests job to see if it passes on retry.

@jamesdeanexpensify
jamesdeanexpensify marked this pull request as ready for review May 15, 2026 22:21
@jamesdeanexpensify
jamesdeanexpensify requested a review from a team as a code owner May 15, 2026 22:21
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and mollfpr and removed request for a team May 15, 2026 22:21
@melvin-bot

melvin-bot Bot commented May 15, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The perf-tests failure is unrelated to this PR — it's a flaky Reassure test affecting multiple branches right now.

Failure: [ReportActionCompose] should render Composer with text input interactions — render count difference of 1 exceeds the allowed deviation of 0.

Evidence: The identical failure is occurring on the unrelated rory/emoji-base/p1-app-dual-format-hex branch. This PR only changes translation string values (not keys or component logic), so it cannot cause a render count regression.

All other checks (ESLint, Prettier, typecheck, all 8 test shards, builds, spellcheck, etc.) are passing.

@mollfpr mollfpr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the translation from this PR was generated directly by Melvin. I think we should use Polyglot Parrot's suggestions instead.

The most notable gap is in the Japanese translations which is missing the "and more".

Comment thread src/languages/ja.ts Outdated
welcomeToRoom: (roomName: string) => `${roomName} へようこそ!`,
usePlusButton: (additionalText: string) => `+ ボタンを使って経費を${additionalText}します。`,
askConcierge: 'こちらはあなた専属のAIエージェント、Conciergeとのチャットです。ほぼ何でもできますので、お試しください!',
askConcierge: 'Conciergeは質問に答えたり、経費を更新したりすることができます。',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation is missing "and more".

Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesdeanexpensify We can ask Melvin to apply the translation diff generated by the Polyglot.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated Japanese translation from Polyglot Parrot now includes "and more" — applied as: Concierge は、質問にお答えしたり、経費を更新したり、さまざまなことができます。

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only actionable failing check is perf-tests — the checklist failure is just unchecked boxes in the PR template.

The perf-tests failure is unrelated to this PR. The error is:

Render count difference exceeded the allowed deviation of 0. Current difference: 1
Measurement: [ReportActionCompose] should render Composer with text input interactions

This PR only modifies translation strings in src/languages/*.ts files and a unit test assertion in tests/unit/SidebarUtilsTest.ts. Changing string values cannot cause additional React component renders — this is a flaky Reassure performance test.

All code-quality checks (ESLint, Prettier, typecheck, all 8 test shards, Storybook, builds) are passing.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The perf-tests failure is unrelated to this PR's changes.

Analysis: The Reassure render-count check ([ReportActionCompose] should render Composer with text input interactions) is failing across many unrelated PRs right now — it's a pre-existing/flaky regression on main, not caused by language string changes.

Evidence: This PR only modifies translation files (src/languages/*.ts) and a unit test (tests/unit/SidebarUtilsTest.ts). The same perf-test is currently failing on at least 10 other unrelated branches (e.g., refactor-66578-shareTrackedExpense, fix/75306, fix/89624, etc.).

The only other failing check is checklist (PR Author Checklist), which is expected and not a code issue.

No action needed — the code checks (ESLint, Prettier, typecheck, all 8 test jobs, builds) are all passing.

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for product

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The perf-tests failure is unrelated to this PR.

Failure: [ReportActionCompose] should render Composer with text input interactions — render count difference exceeded the allowed deviation of 0 (current difference: 1).

Why it's unrelated: This PR only modifies language string files (src/languages/*.ts) and tests/unit/SidebarUtilsTest.ts. A render count regression in ReportActionCompose cannot be caused by changing static translation strings. This is a pre-existing flaky perf test.

The only other failing check is checklist (PR Author Checklist), which is not actionable here.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

What's next here?

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@mollfpr need anything from me here?

@mollfpr

mollfpr commented May 26, 2026

Copy link
Copy Markdown
Contributor

@jamesdeanexpensify You can ask Melvin to implement the translation from Polyglot Parrot 👍

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@MelvinBot please implement the translations from Polyglot Parrot

Co-authored-by: jamesdeanexpensify <jamesdeanexpensify@users.noreply.github.com>
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Applied the Polyglot Parrot translation refinements for askConcierge across 5 languages:

  • de: "und vieles mehr" → "und mehr"
  • fr: "répondre à vos questions, mettre à jour vos dépenses et bien plus encore" → "répondre aux questions, mettre à jour les dépenses, et plus encore"
  • it: "e molto altro" → "e altro ancora"
  • ja: Updated to include "and more" equivalent (さまざまなことができます)
  • pl: "i wiele więcej" → "i nie tylko"

Note: The es.ts changes in the Polyglot diff were only eslint comment removals (not translation changes), so those were skipped. The pt-BR, zh-hans, and nl translations were not in the Polyglot diff and remain unchanged.

@melvin-bot
melvin-bot Bot requested review from deetergp and removed request for a team May 26, 2026 18:33
@melvin-bot

melvin-bot Bot commented May 26, 2026

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing checks on this PR are PR Reviewer Checklist and PR Author Checklist — these are expected automated reminders, not code failures.

All code checks that have completed are passing: ESLint, Prettier, typecheck, builds, generateTranslations, Storybook, and spellcheck. Jest unit tests are currently in progress but have never failed on this branch. No code fix is needed.

@deetergp

deetergp commented May 26, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot

Copy link
Copy Markdown
Contributor Author

All checks on this PR are currently passing — there are no failing checks to fix. 🟢

@deetergp
deetergp merged commit b6a7a7b into main May 27, 2026
57 of 74 checks passed
@deetergp
deetergp deleted the claude-removeAskConciergeTagline branch May 27, 2026 00:02
@melvin-bot melvin-bot Bot added the Emergency label May 27, 2026
@melvin-bot

melvin-bot Bot commented May 27, 2026

Copy link
Copy Markdown

@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 27, 2026
75 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.84-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I reviewed the changes in this PR and checked all help site articles under App/docs/articles/ for references to the old Concierge welcome message.

No help site changes are required. The old message text ("This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!") does not appear anywhere in the help docs. The existing Concierge articles (Concierge-in-Expensify.md, Concierge-Intelligence.md) describe Concierge's capabilities in general terms and don't quote the in-app welcome message.

@jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.86-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I reviewed all help site files under App/docs/articles for references to the old Concierge welcome message ("This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!").

No help site changes are required. None of the existing help articles quote or reference the in-app welcome message text. The Concierge help articles (Concierge-Basics.md, What-Concierge-Can-Do.md, Support-Agent.md, Concierge-in-Expensify.md) describe Concierge in their own independent language and are unaffected by this string change.

@jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.88-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I reviewed the changes in this PR (updating the Concierge welcome message from "This is your chat with Concierge, your personal AI agent. I can do almost anything, try me!" to "Concierge can answer questions, update expenses, and more.") against all help site articles under App/docs/articles.

No help site changes are required. None of the existing help articles quote or reference the specific in-app welcome message text. The Concierge-related articles (Concierge-Basics.md, Concierge-in-Expensify.md, What-Concierge-Can-Do.md, etc.) describe Concierge's capabilities in their own words and don't include the UI copy being changed here.

@jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants