Repository navigation
migrate EXPENSIFY_CARD_DETAILS - #91161
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
The old route path does not need to be updated here because this route comes from the issue card message. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f16ee296c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [SCREENS.EXPENSIFY_CARD.DYNAMIC_EXPENSIFY_CARD_DETAILS]: { | ||
| policyID: string; | ||
| cardID: string; | ||
| // eslint-disable-next-line no-restricted-syntax -- `backTo` usages in this file are legacy. Do not add new `backTo` params to screens. See contributingGuides/NAVIGATION.md |
There was a problem hiding this comment.
Do we still have places using backTo?
There was a problem hiding this comment.
Yes, once the Expensify Card detail page is fully migrated, we will remove it.
|
|
||
| const goBack = useCallback(() => { | ||
| Navigation.goBack(backPath); | ||
| Navigation.goBack(backPath, {compareParams: false}); |
There was a problem hiding this comment.
why did we need to add compareParams?
There was a problem hiding this comment.
Because when we open the Expensify Card detail settings from the workspace chat, it causes issues similar to the QuickBooks Desktop export flow. For example, opening the company card can cause the back button to stop working with no action triggered. We used compareParams to fix it.
Thanks for the review. I responded to your question. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb-expensify-card-detail.mov |
|
@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed all changes in this PR against the help site articles under No help site changes are required. This PR is a purely internal navigation refactoring that migrates the |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|
| const navigateRoute = shouldNavigateToCardDetails | ||
| ? createDynamicRoute(DYNAMIC_ROUTES.EXPENSIFY_CARD_DETAILS.getRoute(String(cardID), policyID)) |
There was a problem hiding this comment.
Using createDynamicRoute here causes the issue in #95364
Explanation of Change
Fixed Issues
$ #83836
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
Precondition:
Steps:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-20.at.15.47.38.mov