Repository navigation
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppvideo_2026-05-25_14-48-04.mp4Android: mWeb ChromeScreen.Recording.2026-05-25.at.14.49.24.moviOS: HybridAppScreen.Recording.2026-05-25.at.14.46.14.moviOS: mWeb SafariScreen.Recording.2026-05-25.at.14.47.11.movMacOS: Chrome / SafariScreen.Recording.2026-05-25.at.14.49.54.mov |
eVoloshchak
left a comment
There was a problem hiding this comment.
LGTM!
Not sure why the checks are failing, @TaduJR, could you pull the latest main please?
…autofocus-in-the-name-editing-menu-taxes
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @flodnv has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
Deploy Blocker ##91901 was identified to be related to this PR. |
|
Deploy Blocker #91903 was identified to be related to this PR. |
|
Deploy Blocker #91916 was identified to be related to this PR. |
|
Deploy Blocker #91919 was identified to be related to this PR. |
|
@TaduJR I did some debugging as Melvin pointed deploy blocker on mine PR. #91901 (comment) I noticed that scroll handler is missing list ref value, I guess other blockers may be similar issue |
|
Revert PR here: #91937 |
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|
I double checked and all the DBs linked above are not related with this PR. Tried to Repo all after applying the changes they are not all repo. |
|
Deploy Blocker #92210 was identified to be related to this PR. |
Explanation of Change
This fixes the missing autofocus on the tax name editing field on iOS by updating the FullStory dependencies to versions that contain the upstream root-cause fix.
Root cause: On iOS,
@fullstory/babel-plugin-react-nativeinjects a syntheticrefinto every element with FullStory attributes (added by@fullstory/babel-plugin-annotate-react). In React 19 these synthetic refs were enumerable, so they leaked through{...rest}spreads in components that don't destructureref. InTextSelectorModal, the leaked phantom ref overwrote the legitimateinputCallbackRefon<InputWrapper>, leavinginputRef.currentnull — so theuseFocusEffectfocus logic silently skipped, and the keyboard never appeared.This only reproduced on iOS Native because FullStory's ref injection is guarded by
Platform.OS === 'ios'and the New Architecture (TurboModules) check.Fix: Reported and fixed upstream in
@fullstory/babel-plugin-react-native. Synthetic refs are now injected as non-enumerable viaObject.defineProperty, so they no longer leak through{...rest}spreads while still being visible to React's reconciler (coerceRefreadsprops.refvia direct property access). This resolves the issue app-wide rather than patching a single page.This PR bumps the FullStory packages to the latest published versions which include the fix:
@fullstory/babel-plugin-react-native^1.5.2^1.6.4@fullstory/babel-plugin-annotate-react^2.3.2^2.4.0@fullstory/browser^2.0.6^2.0.8Fixed Issues
$ #76650
PROPOSAL: #76650 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-23.at.12.24.33.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-05-23.at.12.28.46.AM.mov
iOS: Native
Screen.Recording.2026-05-23.at.12.11.24.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-05-23.at.12.18.41.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-23.at.12.16.45.AM.mov