Repository navigation
update LHN preview and thread name for SmartScan failure messages - #91692
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dukenv0307 I had a login issue with the Android App now, will update it later
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c9788329a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const iouAction = getReportAction(report?.parentReportID, report?.parentReportActionID); | ||
| const missingFields = getOriginalMessage(reportAction)?.missingFields; | ||
| setClipboardMessage(translate('violations.smartscanFailed', {canEdit: wasActionTakenByCurrentUser(iouAction), missingFields})); |
There was a problem hiding this comment.
Resolve the IOU action when copying SmartScan failures
The new RECEIPT_SCAN_FAILED copy-message branch derives canEdit from getReportAction(report?.parentReportID, report?.parentReportActionID), but in transaction threads that parentReportActionID points to the thread parent (the RECEIPT_SCAN_FAILED action), not the underlying IOU action. In that case wasActionTakenByCurrentUser(iouAction) is always false, so copied text can incorrectly switch to the non-editable variant even when the submitter is copying their own failure message. This creates a mismatch with the rendered message logic, which already has fallback IOU resolution for thread contexts.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@dukenv0307 I checked in the thread, the report is still transaction thread then the parent report is the IOU action. So we can ignore this comment.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-27.at.14.29.43.movAndroid: mWeb ChromeScreen.Recording.2026-05-27.at.11.36.37.moviOS: HybridAppScreen.Recording.2026-05-27.at.11.39.46.moviOS: mWeb SafariScreen.Recording.2026-05-27.at.11.36.55.movMacOS: Chrome / SafariScreen.Recording.2026-05-27.at.11.28.07.mov |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
Yes, help site changes are required. This PR updates the SmartScan failure message to include specific missing fields (e.g., "Receipt scanning failed — missing merchant, date, and amount"), and the help article I've created a draft PR with the updates: #91870 Changes made:
@nkdengineer, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|

Explanation of Change
update LHN preview and thread name for SmartScan failure messages
Fixed Issues
$ #90466
PROPOSAL: #90466 (comment)
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2026-05-26.at.13.46.08.mov
iOS: Native
Screen.Recording.2026-05-26.at.13.43.57.mov
iOS: mWeb Safari
Screen.Recording.2026-05-26.at.13.43.23.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-26.at.13.34.44.mov