Repository navigation
Fix spacing in workspace rows table - #92678
Conversation
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required I reviewed the changes in this PR against Expensify's help site files under This PR is a purely cosmetic styling fix — it changes the spacing between the avatar and owner name in the workspace rooms table from - <View style={[styles.flex1, styles.flexRow, styles.gap3, styles.alignItemsCenter]}>
+ <View style={[styles.flex1, styles.flexRow, styles.gap2, styles.alignItemsCenter]}>The single changed file is The help site documents product features, workflows, settings, and how‑tos. This change introduces no new feature, no renamed feature/tab/setting/button, and no behavioral change — it only adjusts pixel spacing in an existing table. Nothing in Result: No help site documentation changes are needed, and therefore no draft docs PR was created.
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
Explanation of Change
Fixes the spacing between the user avatar & name
Fixed Issues
$ https://expensify.slack.com/archives/C07NMDKEFMH/p1780556707843729?thread_ts=1780331772.804479&cid=C07NMDKEFMH
Tests
Ensure that the gap between the user name & avatar in the workspace rooms table is 8px, not 12px
Offline tests
N/A
QA Steps
Same
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos