Repository navigation
fix- Blocked Report Submission Briefly Shows “Submitted” State Before Reverting - #92835
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85792040c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@FitseTLT do you think we can increase the test coverage in this PR? We also got an automated review comment, what do you think about it? |
We only added clearPeningAction util that clears pending action on a report meta data not worthy of adding tests. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine for product
|
Great, I requested DEW be enabled in my workspace. Once it's done, I'll come back to complete the checklist. Thank you. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp92835_android_web.movAndroid: mWeb Chrome92835_android_web.moviOS: HybridApp92835_ios_web.moviOS: mWeb Safari92835_ios_web.movMacOS: Chrome / Safari92835_web_chrome.mov |
|
@mountiny ready for you |
|
@FitseTLT I think since this is sort of the same issue, it would make sense to handle it with the scope of the GH, but in order to keep the PRs small and self contained, I will go ahead, review this PR and merge it. Can you prepare second PR to address the other issue specifically? Can you make sure that the solution is holistic for any of the animations / state changes? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed the changes in this PR and no help site updates are required under Why: This is a transient UI fix. The change makes the Submit button display a loading spinner while the Dynamic External Workflow (DEW) backend validation runs, instead of briefly flashing a "Submitted" state before reverting when submission is blocked. It does not introduce or alter any documented feature, setting, tab, label, or workflow. What I checked
No draft docs PR was created, so there is no linked help site PR to review. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required I reviewed the changes in this PR against the help site articles under Why: This is a purely visual/timing fix to the Submit button micro-interaction. When a report is blocked from submission under a Dynamic External Workflow (DEW), the button now shows a loading spinner while the backend validates, instead of briefly flashing the "Submitted" state and reverting. The changes are limited to a new pending-action constant ( The help site documents what features do and how to configure/use them — not transient button states or loading-spinner behavior. I searched If you believe a help article should describe this submission flow (e.g., how DEW-blocked submissions behave), let me know and I can scope a docs update. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
Explanation of Change
Fixed Issues
$ #90067
PROPOSAL: #90067 (comment)
Tests
Offline tests
same as tests
QA Steps
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
a.mp4
Android: mWeb Chrome
aw.mp4
iOS: Native
2026-06-08.21-17-03.mp4
iOS: mWeb Safari
2026-06-08.21-22-47.mp4
MacOS: Chrome / Safari
2026-06-08.21-22-09.mp4