Repository navigation
[BATCH 2] Migrate Navigation usage, part 3 - #93020
roryabraham merged 6 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Pujan92 @ikevin127 @daledah One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45e726313a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-11.at.21.13.54.movAndroid: mWeb ChromeScreen.Recording.2026-06-11.at.21.17.36.moviOS: HybridAppim.moviOS: mWeb Safariim.movMacOS: Chrome / Safari1.mov2.mov3.mov |
daledah
left a comment
There was a problem hiding this comment.
LGTM. The migration approach and the 300ms delay to prevent flickering look good.
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
luacmartins
left a comment
There was a problem hiding this comment.
Thanks for working on this
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.6-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under This PR is an internal UI-polish refactor: it fixes flickering in the reports/expenses list when deleting an expense or report from the RHP. The changes:
Why no docs update is needed
Files changed (all code, no copy):
Since no help site changes are required, no draft docs PR was created. @collectioneur, if you believe any article should be updated, let me know and I'll open one. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.6-4 🚀
|
Explanation of Change
Fix flickering in the reports/expenses list when deleting an expense or report from the RHP. This PR migrates
InteractionManager.runAfterInteractionstoTransitionTracker.runAfterTransitionsandNavigation.goBack/navigateBackToLastSuperWideRHPScreenafterTransitioncallbacks, adding a delay (EXPENSE_REPORT_DELETE_DELAY_MS: 300) so the deletion happens a little bit later (the user will see the report/expense in the list for an additional 300 ms). For details see: #92036 (comment)Fixed Issues
$ #92036
$ #71913
$ #83062
Tests
Test 1
Test 2
Test 3
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Test 1:
Screen.Recording.2026-06-11.at.14.01.13.mov
Test 2:
Screen.Recording.2026-06-11.at.14.01.48.mov
Test 3:
Screen.Recording.2026-06-11.at.14.02.28.mov