Repository navigation
[Submit] Add editor role to the filter for submit workspace - #93022
Conversation
|
Sorry for the ping @eh2077. @abzokhattab will handle it. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85a6f13322
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| case WORKSPACE_MEMBER_FILTER_VALUES.EDITORS: | ||
| return employee?.role === CONST.POLICY.ROLE.EDITOR; |
There was a problem hiding this comment.
Reset editor filter when leaving Submit workspaces
When the reused Members screen switches from a Submit workspace to another workspace after the user selected the new Editor filter, selectedRoleFilter is not reset, but this predicate still applies EDITORS even though the new roleFilterOptions no longer include Editor. In that context the non-Submit member list is filtered to editor-role employees (usually none) and shows an unexpected empty state until the user manually changes the hidden stale filter; reset the role filter on policyID/policy type changes or ignore role values that are not valid for the current options.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is an edge case, after upgrading it will look like this, let me know if we want to fix it:
Screen.Recording.2026-06-09.at.17.07.51.mov
There was a problem hiding this comment.
Similar case when we select Auditor filter and downgrade from Control to collect.
JmillsExpensify
left a comment
There was a problem hiding this comment.
Part of an existing product initiative.
|
I think we should filter out all other types. The list should contain only the |
|
That's a good point. I agree with that. |
Which option should we keep? Because |
|
Is |
No. It appears with every plan. The only special role for submit is |
|
There is no |
|
I think you're just talking about the filter though, right? e.g. in the dropdown we show |
Yep. I believe so. Screen.Recording.2026-06-11.at.17.40.43.movSince Submit workspace will also have submitsTo, do you want to keep it as a filter option? |
|
Ok thanks! Sorry to dig in on that, just wanted to make sure I understand. |
|
All good on my end to add |
|
Just noticed an issue The new filter label uses
cc @hungvu193 |
|
@abzokhattab You're right |
|
@MelvinBot Can you address this comment? Let's add plural version for "Editor" |
|
Addressing I've prepared and verified the change locally (lint, prettier, and typecheck all pass — the only remaining typecheck errors are pre-existing in Changes
if (isSubmitPolicy(policy)) {
roleFilterOptions.push({
- text: translate('common.editor'),
+ text: translate('workspace.people.editors'),
value: WORKSPACE_MEMBER_FILTER_VALUES.EDITORS,
});
}
|
|
@MelvinBot Please try again. |
Add a dedicated workspace.people.editors translation key and use it for the Submit-policy Editor filter option, replacing the singular common.editor so the filter label matches the other pluralized options (Admins, Approvers, Auditors). Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
Pushed a fix addressing The Editor filter option now uses a dedicated pluralized Verified locally: lint, prettier, and typecheck pass (the only remaining typecheck errors are pre-existing in
|
|
Lgtm |
|
🚧 @iwiznia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
Help site review — docs update requiredThis PR adds an Editors option to the role filter dropdown on the Workspace Members page, shown for Submit workspaces. The help article Managing Workspace Members in New Expensify documents the available role filters but was missing this new option. I created a draft help site PR adding the Editors filter to the "Filter Workspace Members by Role" section, following the existing pattern used for the Auditors and Card Admins entries and matching the live UI label: ➡️ Draft PR: #93867 No other docs reference this filter dropdown, so no further help site changes are needed. @MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review — no docs changes required I reviewed this PR's changes against the help site articles under What this PR does: Adds an Editors option to the role filter dropdown on the Workspace Members page, and adjusts which filters appear per workspace type — for Submit workspaces the dropdown now shows All members, Approvers, and Editors (and no longer shows Admins). Why no docs update is needed (yet): The new Editors filter only renders for Submit workspaces, and the The right time to document the Editors filter is when Submit workspaces are documented holistically as part of that feature's GA launch — not as an isolated filter line now. Evidence
If you'd like me to go ahead and add an Editors entry to the role-filter section anyway (or pre-stage Submit-workspace docs), reply with |
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review — docs PR already exists (superseding my earlier comment) Correcting my previous comment: a draft help site PR for this change already exists and is the right call, so I did not create a new one. ➡️ Draft docs PR: #93867 It adds an Editors – Shows only members with the Editor role (Submit workspaces only) entry to the "Filter Workspace Members by Role" section of Managing Workspace Members in New Expensify, following the same workspace-type-scoped pattern the article already uses for Auditors and Card Admins (Control workspaces only). That keeps the documented filter list complete and matches the live UI label I withdraw the "no docs changes required" conclusion — it was based on the feature being @MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #93933 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|

Explanation of Change
Add Editor filter to the dropdown of WorkspaceMemberPage for Submit workspace.
Fixed Issues
$ #92828
PROPOSAL: N/A
Tests
Same as QA steps.
Offline tests
Same as QA steps.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-06-09.at.16.21.02.mov