Repository navigation
[No QA] Update retry logic - #9306
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When a persisted network request fails for a retry-able reason, such as Auth being down, we will now retry the request until it succeeds using exponential backoff. That means that the request will initially be retried after a random wait time between 10 and 100ms, and then each subsequent retry will double the wait time.
Previously, we only retried requests up to a maximum of 10 times and then they were discarded, resulting in data loss.
Most of the changes in this PR are updating or adding tests. I also added handling for requests that are throttled, or internal server errors.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/210356
Tests
sudo systemctl stop authin your vmsudo systemctl start authin your vmOffline tests
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
I only tested on Web because these changes are platform independent.
Web
Backoff
backoff.mov
Offline
offline.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android